jared/cc-os
Watch
1
0
Fork
You've already forked cc-os
 0
Code Issues 147 Pull requests Projects Releases Packages Wiki Activity

Review unsafe-only (-A) rubocop offenses in os-aidd-lint and os-adr #383

New issue
Closed
opened 2026-08-14 20:13:14 +00:00 by jared · 3 comments
jared commented 2026-08-14 20:13:14 +00:00
Owner
Copy link

Parent

#368

What to build

After safe autocorrect (#373/#374), 66 offenses in os-aidd-lint and 50 in os-adr are only -A (unsafe) correctable — mostly Style/FrozenStringLiteralComment and Style/MutableConstant. Review per cop, apply the safe-in-practice ones as reviewable per-plugin commits, tests green.

Acceptance criteria

  • Each unsafe cop category decided: apply or document why not
  • Per-plugin commits, tests green

Blocked by

  • None — can start immediately.
## Parent #368 ## What to build After safe autocorrect (#373/#374), 66 offenses in os-aidd-lint and 50 in os-adr are only -A (unsafe) correctable — mostly Style/FrozenStringLiteralComment and Style/MutableConstant. Review per cop, apply the safe-in-practice ones as reviewable per-plugin commits, tests green. ## Acceptance criteria - [ ] Each unsafe cop category decided: apply or document why not - [ ] Per-plugin commits, tests green ## Blocked by - None — can start immediately.
jared commented 2026-08-14 20:30:04 +00:00
Author
Owner
Copy link

Starting: review 116 unsafe-only offenses

Starting: review 116 unsafe-only offenses
jared commented 2026-08-14 20:34:23 +00:00
Author
Owner
Copy link

Done: 66 (os-aidd-lint) + 53 (os-adr) unsafe offenses applied (FrozenStringLiteralComment/MutableConstant/StringConcatenation/SpecialGlobalVars/HashEachMethods), 1 HashEachMethods autocorrect reverted (wrong on Array, broke 11 tests) with rubocop:disable. Tests green: 495/47. Commits 860865b, eb6d361. Not closing per instructions.

Done: 66 (os-aidd-lint) + 53 (os-adr) unsafe offenses applied (FrozenStringLiteralComment/MutableConstant/StringConcatenation/SpecialGlobalVars/HashEachMethods), 1 HashEachMethods autocorrect reverted (wrong on Array, broke 11 tests) with rubocop:disable. Tests green: 495/47. Commits 860865b, eb6d361. Not closing per instructions.
jared commented 2026-08-14 20:35:03 +00:00
Author
Owner
Copy link

Resolution

Done: Reviewed all unsafe-only offenses in os-aidd-lint (66) and os-adr (53): applied FrozenStringLiteralComment, MutableConstant, StringConcatenation, SpecialGlobalVars; reverted one wrong HashEachMethods rewrite (Array of tuples, not Hash) with justified inline disable

Evidence: Commits 860865b, eb6d361; os-aidd-lint 495 runs green, os-adr 47 runs green; refresh-plugins run

Follow-ups: Remaining Metrics/Minitest/Dry offenses in both plugins are tracked by the census on #368; metadata_value data-shape restructure suggestion dropped as not worth a ticket

## Resolution **Done:** Reviewed all unsafe-only offenses in os-aidd-lint (66) and os-adr (53): applied FrozenStringLiteralComment, MutableConstant, StringConcatenation, SpecialGlobalVars; reverted one wrong HashEachMethods rewrite (Array of tuples, not Hash) with justified inline disable **Evidence:** Commits 860865b, eb6d361; os-aidd-lint 495 runs green, os-adr 47 runs green; refresh-plugins run **Follow-ups:** Remaining Metrics/Minitest/Dry offenses in both plugins are tracked by the census on #368; metadata_value data-shape restructure suggestion dropped as not worth a ticket
jared closed this issue 2026-08-14 20:35:03 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
P0
Priority 0 — drop everything

  
P1
Priority 1 — next up

  
P2
Priority 2 — normal

  
P3
Priority 3 — someday

  
bug
Something is broken

  
create
Ticket creates something new

  
delete
Ticket removes something

  
enhancement
New feature or improvement

  
filed-by/agent

   
filed-by/user

   
frozen
Pre-reset backlog freeze 2026-08-16; do not work unless rediscovered by a live run

  
lint-rule
Ticket proposes/modifies a lint rule or cop

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
next
Human-curated next up — AI never applies or removes

  
plugin/cc-architect
Scope: the cc-architect plugin

  
plugin/os
Scope: the os plugin

  
plugin/os-adr
Scope: the os-adr plugin

  
plugin/os-aidd-lint
Scope: the os-aidd-lint plugin

  
plugin/os-backlog
Scope: the os-backlog plugin

  
plugin/os-context
Scope: the os-context plugin

  
plugin/os-doc-hygiene
Scope: the os-doc-hygiene plugin

  
plugin/os-sdlc
Scope: the os-sdlc plugin

  
plugin/os-vault
Scope: the os-vault plugin

  
project/cc-os
Parent-scope: cc-os repo-wide, not specific to one plugin

  
ready-for-agent
Triage complete; an agent can pick this up

  
ready-for-human
Human-owned; never picked up autonomously

  
recurring
Recurring flavor: occurrence outcomes commented, never closed by AI

  
review
Shipped semi work awaiting human sign-off

  
update
Ticket updates something existing

  
waiting
Blocked; blocker named in a comment

  
wayfinder:grilling

   
wayfinder:map

   
wayfinder:map
wayfinder map ticket

  
wayfinder:research

   
wayfinder:task

   
wayfinder:task
wayfinder map child: task

  
wontfix
Will not be actioned

  
worklist/deviations
Deviation incidents from skill/pipeline runs — evidence pile for correcting the owning artifact

  
worklist/lint-rule
Proposed os-sdlc or os-aidd-lint rule

  
worklist/new-implement-build
Updated implementation harness (ast-grep + stepper)

No labels
P0
P1
P2
P3
bug
create
delete
enhancement
filed-by/agent
filed-by/user
frozen
lint-rule
needs-info
needs-triage
next
plugin/cc-architect
plugin/os
plugin/os-adr
plugin/os-aidd-lint
plugin/os-backlog
plugin/os-context
plugin/os-doc-hygiene
plugin/os-sdlc
plugin/os-vault
project/cc-os
ready-for-agent
ready-for-human
recurring
review
update
waiting
wayfinder:grilling
wayfinder:map
wayfinder:map
wayfinder:research
wayfinder:task
wayfinder:task
wontfix
worklist/deviations
worklist/lint-rule
worklist/new-implement-build
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jared/cc-os#383
No description provided.