Autocorrect os-adr rubocop offenses #374

Closed
opened 2026-08-14 20:02:13 +00:00 by jared · 2 comments
Owner

Parent

#368

What to build

One reviewable commit that runs rubocop autocorrect over the os-adr plugin, taking its ~640 autocorrectable offenses (of 838) to zero, with the plugin's tests still green.

Acceptance criteria

  • Autocorrectable offense count for os-adr is zero after the run
  • os-adr tests pass after the change
  • Exactly one commit scoped to os-adr

Blocked by

  • #372 (fixture excludes change every later offense count)
## Parent #368 ## What to build One reviewable commit that runs rubocop autocorrect over the os-adr plugin, taking its ~640 autocorrectable offenses (of 838) to zero, with the plugin's tests still green. ## Acceptance criteria - [ ] Autocorrectable offense count for os-adr is zero after the run - [ ] os-adr tests pass after the change - [ ] Exactly one commit scoped to os-adr ## Blocked by - #372 (fixture excludes change every later offense count)
Author
Owner

Started: rubocop autocorrect over plugins/os-adr.

Started: rubocop autocorrect over plugins/os-adr.
Author
Owner

Resolution

Done: Safe rubocop autocorrect over plugins/os-adr: 737 -> 109 offenses, 0 safe-correctable remain

Evidence: Commit ba09c6d, 27 files all under plugins/os-adr; tests 47 runs 0 failures before and after; bin/refresh-plugins run; 9 Lint/Syntax misparses left for #379

Follow-ups: #383 review of 50 unsafe-only (-A) offenses; TargetRubyVersion misparses already ticketed as #379

## Resolution **Done:** Safe rubocop autocorrect over plugins/os-adr: 737 -> 109 offenses, 0 safe-correctable remain **Evidence:** Commit ba09c6d, 27 files all under plugins/os-adr; tests 47 runs 0 failures before and after; bin/refresh-plugins run; 9 Lint/Syntax misparses left for #379 **Follow-ups:** #383 review of 50 unsafe-only (-A) offenses; TargetRubyVersion misparses already ticketed as #379
jared closed this issue 2026-08-14 20:13:26 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jared/cc-os#374
No description provided.