Exclude document-renderer test files from Sdlc/Structural/RawFileContentAssertion #381

Closed
opened 2026-08-14 20:12:07 +00:00 by jared · 2 comments
Owner

Parent #369.

Build: add rubocop Exclude entries (no cop code change) for the test files whose subject class's entire public contract IS the rendered document:

  • plugins/os-adr/tests/{cli,index,migrator}_test.rb (Adr::Index / MigrationReport markdown)
  • plugins/os-aidd-lint/tests/{aidd_lint_bin,report,hooks/post_tool_use_hook,hooks/session_end_hook}_test.rb (Report.md is a line-oriented artifact per ADR-0027; --fix asserts rewritten bytes)
    Add a one-line YAML comment above the Exclude block naming the reason (rendered-document contract).

Acceptance:

  • 30 of 36 offenses gone; the 6 real ones (os-backlog checkout_test.rb 96/109/158/168, issues_test.rb:367, cc-architect test_cli.rb:143) still reported.
  • no change to raw_file_content_assertion.rb.

Blocked-by: none.

Parent #369. Build: add rubocop Exclude entries (no cop code change) for the test files whose subject class's entire public contract IS the rendered document: - plugins/os-adr/tests/{cli,index,migrator}_test.rb (Adr::Index / MigrationReport markdown) - plugins/os-aidd-lint/tests/{aidd_lint_bin,report,hooks/post_tool_use_hook,hooks/session_end_hook}_test.rb (Report.md is a line-oriented artifact per ADR-0027; --fix asserts rewritten bytes) Add a one-line YAML comment above the Exclude block naming the reason (rendered-document contract). Acceptance: - 30 of 36 offenses gone; the 6 real ones (os-backlog checkout_test.rb 96/109/158/168, issues_test.rb:367, cc-architect test_cli.rb:143) still reported. - no change to raw_file_content_assertion.rb. Blocked-by: none.
Author
Owner

Starting: RawFileContentAssertion excludes + 6 defect fixes

Starting: RawFileContentAssertion excludes + 6 defect fixes
Author
Owner

Resolution

Done: Added RawFileContentAssertion excludes for the 5 document-renderer test files in plugins/os-sdlc/.rubocop.yml; fixed the 6 real raw-file assertion defects (5 in os-backlog tests; the cc-architect one was already fixed by #384 commit 38bc1cc)

Evidence: Commit 66e8b40; 30 of 36 offenses excluded, 6 fixed, cop now 0 offenses on defect files; os-backlog 17-file suite green, cc-architect plugin_config suite green

Follow-ups: cc-architect lint-gating question captured as ticket #388; the uncommitted duplicated_statement_sequence.rb working-tree changes belong to in-flight #380 work, not lost

## Resolution **Done:** Added RawFileContentAssertion excludes for the 5 document-renderer test files in plugins/os-sdlc/.rubocop.yml; fixed the 6 real raw-file assertion defects (5 in os-backlog tests; the cc-architect one was already fixed by #384 commit 38bc1cc) **Evidence:** Commit 66e8b40; 30 of 36 offenses excluded, 6 fixed, cop now 0 offenses on defect files; os-backlog 17-file suite green, cc-architect plugin_config suite green **Follow-ups:** cc-architect lint-gating question captured as ticket #388; the uncommitted duplicated_statement_sequence.rb working-tree changes belong to in-flight #380 work, not lost
jared closed this issue 2026-08-14 20:35:53 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jared/cc-os#381
No description provided.