jared/cc-os
Watch
1
0
Fork
You've already forked cc-os
 0
Code Issues 147 Pull requests Projects Releases Packages Wiki Activity

os-sdlc: lint-worklist should scan conventional dirs (tests/ missing today) #287

New issue
Closed
opened 2026-08-06 15:39:33 +00:00 by jared · 4 comments
jared commented 2026-08-06 15:39:33 +00:00
Owner
Copy link

Context

bin/lint-worklist scans only the project's code_path plus its sibling bin/ (LintWorklistTarget#lint_path), so tests/ never enters the worklist — 75 offenses sat invisible until the 2026-08-06 fix-lints pass (commit cdf1596); bin/ had the same gap, fixed in #267.

Proposal (convention over configuration): scan the conventional directories that exist — lib/, bin/, tests/|test/|spec/ — plus an additive lint_paths: key in .sdlc/project.yaml for non-standard layouts, written by setup-project / os-status:fix. No exclude mechanism until a real need appears. Decide and record the convention (ADR if it changes the project.yaml contract).

## Context bin/lint-worklist scans only the project's code_path plus its sibling bin/ (LintWorklistTarget#lint_path), so tests/ never enters the worklist — 75 offenses sat invisible until the 2026-08-06 fix-lints pass (commit cdf1596); bin/ had the same gap, fixed in #267. Proposal (convention over configuration): scan the conventional directories that exist — lib/, bin/, tests/|test/|spec/ — plus an additive lint_paths: key in .sdlc/project.yaml for non-standard layouts, written by setup-project / os-status:fix. No exclude mechanism until a real need appears. Decide and record the convention (ADR if it changes the project.yaml contract).
jared commented 2026-08-06 16:15:52 +00:00
Author
Owner
Copy link

Decomposition (2026-08-06):
Key tension for the ADR: Project already has an unused test_path field (default "test") — reuse it for lint scanning (no schema change) or add the ticket's proposed additive lint_paths: key?

  1. HUMAN — decide and record convention (ADR, per ADR-0100 pattern): (a) which conventional dirs auto-scan (lib/, bin/, tests/|test/|spec/ — first existing or all existing), (b) test_path reuse vs new lint_paths:, (c) precedence if both, (d) confirm no exclude mechanism.
  2. AGENT (after 1) — extend LintWorklistTarget#lint_path per the ADR (mirror bin_files helper), honor lint_paths: additively if adopted; update Project ATTR_DEFAULTS etc. only if schema changed; tests mirroring existing bin_files test shapes.
  3. AGENT (after 1,2) — wire lint_paths: into setup-project SKILL.md step 2 and check os-status:fix remediation; logic stays in Ruby per plugin CLAUDE.md.
  4. AGENT (after 2,3) — run bin/lint-worklist across cc-os, confirm the formerly invisible tests/ offenses surface; add lint_paths: only for non-standard layouts.
Decomposition (2026-08-06): Key tension for the ADR: Project already has an unused test_path field (default "test") — reuse it for lint scanning (no schema change) or add the ticket's proposed additive lint_paths: key? 1. HUMAN — decide and record convention (ADR, per ADR-0100 pattern): (a) which conventional dirs auto-scan (lib/, bin/, tests/|test/|spec/ — first existing or all existing), (b) test_path reuse vs new lint_paths:, (c) precedence if both, (d) confirm no exclude mechanism. 2. AGENT (after 1) — extend LintWorklistTarget#lint_path per the ADR (mirror bin_files helper), honor lint_paths: additively if adopted; update Project ATTR_DEFAULTS etc. only if schema changed; tests mirroring existing bin_files test shapes. 3. AGENT (after 1,2) — wire lint_paths: into setup-project SKILL.md step 2 and check os-status:fix remediation; logic stays in Ruby per plugin CLAUDE.md. 4. AGENT (after 2,3) — run bin/lint-worklist across cc-os, confirm the formerly invisible tests/ offenses surface; add lint_paths: only for non-standard layouts.
jared commented 2026-08-06 16:23:46 +00:00
Author
Owner
Copy link

Work started on main (no feature branch). Decision recorded as ADR-0102 (docs/adr/0102-lint-worklist-scans-all-existing-conventional-dirs-plus-an-additive-lint-paths-key.md): scan all existing conventional dirs (lib/, bin/, tests/|test/|spec/) plus additive lint_paths: key; test_path untouched; no exclude mechanism.

Work started on main (no feature branch). Decision recorded as ADR-0102 (docs/adr/0102-lint-worklist-scans-all-existing-conventional-dirs-plus-an-additive-lint-paths-key.md): scan all existing conventional dirs (lib/, bin/, tests/|test/|spec/) plus additive lint_paths: key; test_path untouched; no exclude mechanism.
jared commented 2026-08-06 16:40:11 +00:00
Author
Owner
Copy link

Implemented on main: commit f042d6c (code) + e979bb5 (ADR-0102). LintWorklistTarget#lint_path now scans code_path, bin/, all existing tests/|test/|spec/ dirs, plus the new additive lint_paths: project.yaml key (default []); test_path untouched; no exclude mechanism. setup-project SKILL.md documents the key; os-status needed no change. Verified: 738 runs / 1994 assertions green; rubocop lib/ tests/ clean. Running bin/lint-worklist against os-sdlc immediately surfaced a previously invisible Sdlc/Structural/BinScriptLoad offense — follow-up captured as #289. No PR gate — open for human sign-off.

Implemented on main: commit f042d6c (code) + e979bb5 (ADR-0102). LintWorklistTarget#lint_path now scans code_path, bin/, all existing tests/|test/|spec/ dirs, plus the new additive lint_paths: project.yaml key (default []); test_path untouched; no exclude mechanism. setup-project SKILL.md documents the key; os-status needed no change. Verified: 738 runs / 1994 assertions green; rubocop lib/ tests/ clean. Running bin/lint-worklist against os-sdlc immediately surfaced a previously invisible Sdlc/Structural/BinScriptLoad offense — follow-up captured as #289. No PR gate — open for human sign-off.
jared commented 2026-08-06 17:15:05 +00:00
Author
Owner
Copy link

Resolution

Done: lint-worklist now scans all existing conventional test dirs (tests/ test/ spec/) plus additive lint_paths: key in .sdlc/project.yaml

Evidence: commits f042d6c + e979bb5 (ADR-0102); 738 tests green; rubocop clean over 219 files; user signed off 2026-08-06

Follow-ups: #289 (BinScriptLoad offense in trim_status_table_test.rb + multi-target lint sweep)

## Resolution **Done:** lint-worklist now scans all existing conventional test dirs (tests/ test/ spec/) plus additive lint_paths: key in .sdlc/project.yaml **Evidence:** commits f042d6c + e979bb5 (ADR-0102); 738 tests green; rubocop clean over 219 files; user signed off 2026-08-06 **Follow-ups:** #289 (BinScriptLoad offense in trim_status_table_test.rb + multi-target lint sweep)
jared closed this issue 2026-08-06 17:15:05 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
P0
Priority 0 — drop everything

  
P1
Priority 1 — next up

  
P2
Priority 2 — normal

  
P3
Priority 3 — someday

  
bug
Something is broken

  
create
Ticket creates something new

  
delete
Ticket removes something

  
enhancement
New feature or improvement

  
filed-by/agent

   
filed-by/user

   
frozen
Pre-reset backlog freeze 2026-08-16; do not work unless rediscovered by a live run

  
lint-rule
Ticket proposes/modifies a lint rule or cop

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
next
Human-curated next up — AI never applies or removes

  
plugin/cc-architect
Scope: the cc-architect plugin

  
plugin/os
Scope: the os plugin

  
plugin/os-adr
Scope: the os-adr plugin

  
plugin/os-aidd-lint
Scope: the os-aidd-lint plugin

  
plugin/os-backlog
Scope: the os-backlog plugin

  
plugin/os-context
Scope: the os-context plugin

  
plugin/os-doc-hygiene
Scope: the os-doc-hygiene plugin

  
plugin/os-sdlc
Scope: the os-sdlc plugin

  
plugin/os-vault
Scope: the os-vault plugin

  
project/cc-os
Parent-scope: cc-os repo-wide, not specific to one plugin

  
ready-for-agent
Triage complete; an agent can pick this up

  
ready-for-human
Human-owned; never picked up autonomously

  
recurring
Recurring flavor: occurrence outcomes commented, never closed by AI

  
review
Shipped semi work awaiting human sign-off

  
update
Ticket updates something existing

  
waiting
Blocked; blocker named in a comment

  
wayfinder:grilling

   
wayfinder:map

   
wayfinder:map
wayfinder map ticket

  
wayfinder:research

   
wayfinder:task

   
wayfinder:task
wayfinder map child: task

  
wontfix
Will not be actioned

  
worklist/deviations
Deviation incidents from skill/pipeline runs — evidence pile for correcting the owning artifact

  
worklist/lint-rule
Proposed os-sdlc or os-aidd-lint rule

  
worklist/new-implement-build
Updated implementation harness (ast-grep + stepper)

No labels
P0
P1
P2
P3
bug
create
delete
enhancement
filed-by/agent
filed-by/user
frozen
lint-rule
needs-info
needs-triage
next
plugin/cc-architect
plugin/os
plugin/os-adr
plugin/os-aidd-lint
plugin/os-backlog
plugin/os-context
plugin/os-doc-hygiene
plugin/os-sdlc
plugin/os-vault
project/cc-os
ready-for-agent
ready-for-human
recurring
review
update
waiting
wayfinder:grilling
wayfinder:map
wayfinder:map
wayfinder:research
wayfinder:task
wayfinder:task
wontfix
worklist/deviations
worklist/lint-rule
worklist/new-implement-build
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jared/cc-os#287
No description provided.