os-sdlc: clear tests/ offenses surfaced by the conventional-dir lint scan #289

New issue

Closed

opened 2026-08-06 16:38:59 +00:00 by jared · 3 comments

jared commented

2026-08-06 16:38:59 +00:00

Owner

Context

The #287 fix (ADR-0102, commit f042d6c) widened bin/lint-worklist to conventional test dirs, immediately surfacing a previously invisible Sdlc/Structural/BinScriptLoad offense in plugins/os-sdlc/tests/trim_status_table_test.rb (loads code from a bin/ executable into a test). Fix it, and sweep bin/lint-worklist across the other cc-os targets (os-backlog, cc-architect, os-aidd-lint) for anything else the wider scan now surfaces.

## Context The #287 fix (ADR-0102, commit f042d6c) widened bin/lint-worklist to conventional test dirs, immediately surfacing a previously invisible Sdlc/Structural/BinScriptLoad offense in plugins/os-sdlc/tests/trim_status_table_test.rb (loads code from a bin/ executable into a test). Fix it, and sweep bin/lint-worklist across the other cc-os targets (os-backlog, cc-architect, os-aidd-lint) for anything else the wider scan now surfaces.

jared referenced this issue

2026-08-06 16:40:11 +00:00

os-sdlc: lint-worklist should scan conventional dirs (tests/ missing today) #287

jared referenced this issue

2026-08-06 17:15:05 +00:00

os-sdlc: lint-worklist should scan conventional dirs (tests/ missing today) #287

jared commented

2026-08-06 17:15:20 +00:00

Author

Owner

Starting work: fix BinScriptLoad offense in trim_status_table_test.rb, then sweep other targets.

jared added the

review

label

2026-08-06 17:23:03 +00:00

jared commented

2026-08-06 17:23:23 +00:00

Author

Owner

Fixed: StatusTableTrimmer extracted to lib/status_table_trimmer.rb; bin script now a thin wrapper; test requires the lib class (commit dacbfc6). Verified: 738 os-sdlc runs green, rubocop clean (219 files), standalone trimmer test 8 runs green, hook runs standalone. Sweep: other targets share the same repo-root tests/ dir; findings reported in session. Open for sign-off.

Fixed: StatusTableTrimmer extracted to lib/status_table_trimmer.rb; bin script now a thin wrapper; test requires the lib class (commit dacbfc6). Verified: 738 os-sdlc runs green, rubocop clean (219 files), standalone trimmer test 8 runs green, hook runs standalone. Sweep: other targets share the same repo-root tests/ dir; findings reported in session. Open for sign-off.

jared referenced this issue

2026-08-06 17:37:26 +00:00

os-sdlc: clear remaining offenses on tests/trim_status_table_test.rb under os-sdlc cop set #290

jared referenced this issue

2026-08-06 17:37:32 +00:00

os-sdlc: scope lint-worklist conventional test dirs per-target instead of project root #291

jared commented

2026-08-06 18:09:54 +00:00

Author

Owner

Resolution

Done: StatusTableTrimmer extracted to lib/status_table_trimmer.rb; bin script now a thin wrapper; test requires the lib class, clearing Sdlc/Structural/BinScriptLoad

Evidence: commits dacbfc6 + 0193ce1; 738 os-sdlc runs green, rubocop clean (219 files), standalone trimmer test green, hook runs standalone; user signed off 2026-08-06

Follow-ups: #290 and #291 (captured from the sweep findings)

## Resolution **Done:** StatusTableTrimmer extracted to lib/status_table_trimmer.rb; bin script now a thin wrapper; test requires the lib class, clearing Sdlc/Structural/BinScriptLoad **Evidence:** commits dacbfc6 + 0193ce1; 738 os-sdlc runs green, rubocop clean (219 files), standalone trimmer test green, hook runs standalone; user signed off 2026-08-06 **Follow-ups:** #290 and #291 (captured from the sweep findings)

jared closed this issue

2026-08-06 18:09:54 +00:00

jared referenced this issue from a commit

2026-08-06 18:11:19 +00:00

os-sdlc: extract StatusTableTrimmer to lib, drop bin load in test (#289)

jared referenced this issue from a commit

2026-08-06 18:11:19 +00:00

os-sdlc: record #289 BinScriptLoad fix in status leaf