Clean up test files flagged by the three new POODR cops #283

New issue

Closed

opened 2026-08-06 13:11:47 +00:00 by jared · 2 comments

jared commented

2026-08-06 13:11:47 +00:00

Owner

Context

Mine-lints run 2026-08-06 shipped three cops from tickets #280-#282 (RawFileContentAssertion, StaticFactAssertion, BinScriptLoad). Report-only sweep of plugins/os-sdlc/tests/: 26 RawFileContentAssertion hits (cli_test.rb, lint_init_test.rb, rubocop_delta_header_test.rb, lint_worklist_report_test.rb, lint_worklist_residual_dispatch_test.rb, lint_worklist_rubocop_config_test.rb, workspace_test.rb, artifact_test.rb +), 2 StaticFactAssertion hits (iteration_tracker_test.rb:5, project_test.rb:341), 2 BinScriptLoad hits (both bin/lint-worklist loaders — fix requires moving LintWorklistReport/residual-dispatch classes into lib/). Until cleaned, the three cops go red on the existing suite.

## Context Mine-lints run 2026-08-06 shipped three cops from tickets #280-#282 (RawFileContentAssertion, StaticFactAssertion, BinScriptLoad). Report-only sweep of plugins/os-sdlc/tests/: 26 RawFileContentAssertion hits (cli_test.rb, lint_init_test.rb, rubocop_delta_header_test.rb, lint_worklist_report_test.rb, lint_worklist_residual_dispatch_test.rb, lint_worklist_rubocop_config_test.rb, workspace_test.rb, artifact_test.rb +), 2 StaticFactAssertion hits (iteration_tracker_test.rb:5, project_test.rb:341), 2 BinScriptLoad hits (both bin/lint-worklist loaders — fix requires moving LintWorklistReport/residual-dispatch classes into lib/). Until cleaned, the three cops go red on the existing suite.

jared commented

2026-08-06 13:46:29 +00:00

Author

Owner

AI says, "During #283, genuinely format-contract tests will need Exclude: entries under RawFileContentAssertion." User needs more clarity on what this is about this before it earns an Exclusion.

Re-pitch that: give me a little bit of context, talk in ASD-STE100 Simplified Technical English, and use the ubiquitous language from CONTEXT.md.

AI says, "During #283, genuinely format-contract tests will need Exclude: entries under RawFileContentAssertion." User needs more clarity on what this is about this before it earns an Exclusion. Re-pitch that: give me a little bit of context, talk in ASD-STE100 Simplified Technical English, and use the ubiquitous language from CONTEXT.md.

jared commented

2026-08-06 16:03:12 +00:00

Author

Owner

Resolution

Done: Cleaned all test files flagged by the three POODR cops and the wider tests/ rubocop sweep: 75 offenses -> 1 (commits cdf1596, 524df42). All RawFileContentAssertion, StaticFactAssertion, and BinScriptLoad hits resolved; LintWorklistReport/AssignmentFile extracted from bin/lint-worklist into lib/; user-approved scoped Excludes added for the two dispatch-artifact test files whose raw bytes are the contract.

Evidence: Suite green 731 runs / 1978 assertions / 0 failures; rubocop on tests/ lib/ bin: 1 remaining offense (RequireRelativeDensity, tracked separately). Commits cdf1596 and 524df42 on main.

Follow-ups: #286 (Zeitwerk autoloading for tests/, clears the last offense, needs ADR); #287 (lint-worklist conventional scan dirs so tests/ drift is caught by the normal loop)

## Resolution **Done:** Cleaned all test files flagged by the three POODR cops and the wider tests/ rubocop sweep: 75 offenses -> 1 (commits cdf1596, 524df42). All RawFileContentAssertion, StaticFactAssertion, and BinScriptLoad hits resolved; LintWorklistReport/AssignmentFile extracted from bin/lint-worklist into lib/; user-approved scoped Excludes added for the two dispatch-artifact test files whose raw bytes are the contract. **Evidence:** Suite green 731 runs / 1978 assertions / 0 failures; rubocop on tests/ lib/ bin: 1 remaining offense (RequireRelativeDensity, tracked separately). Commits cdf1596 and 524df42 on main. **Follow-ups:** #286 (Zeitwerk autoloading for tests/, clears the last offense, needs ADR); #287 (lint-worklist conventional scan dirs so tests/ drift is caught by the normal loop)

jared closed this issue

2026-08-06 16:03:12 +00:00

jared referenced this issue from a commit

2026-08-06 16:12:58 +00:00

os-sdlc: lint test files to zero mechanical offenses (#283)

jared referenced this issue from a commit

2026-08-06 16:12:58 +00:00

os-sdlc: resolve remaining RawFileContentAssertion offenses (#283)