os-sdlc: scope lint-worklist conventional test dirs per-target instead of project root

jared commented

2026-08-06 17:37:32 +00:00

Owner

Context

The #287 widening (ADR-0102) computes conventional_test_dirs from the project ROOT in plugins/os-sdlc/lib/os_sdlc/lint_worklist_target.rb, so in an aggregate config every named target scans the same repo-root tests/ dir under its own rubocop config — the #289 sweep found all four cc-os targets colliding on tests/trim_status_table_test.rb, 35 style offenses under the three default-config targets vs clean under os-sdlc's. Likely an ADR-0102 amendment: resolve conventional dirs relative to each target's own subtree (as bin_files already does via code_path's sibling).

## Context The #287 widening (ADR-0102) computes conventional_test_dirs from the project ROOT in plugins/os-sdlc/lib/os_sdlc/lint_worklist_target.rb, so in an aggregate config every named target scans the same repo-root tests/ dir under its own rubocop config — the #289 sweep found all four cc-os targets colliding on tests/trim_status_table_test.rb, 35 style offenses under the three default-config targets vs clean under os-sdlc's. Likely an ADR-0102 amendment: resolve conventional dirs relative to each target's own subtree (as bin_files already does via code_path's sibling).

jared commented

2026-08-06 17:38:05 +00:00

Author

Owner

Work started this session. Decision recorded as ADR-0103: conventional test dirs resolve from the target subtree (code_path's parent, same anchor as bin_files); shared repo-root code opts into the os-sdlc target via lint_paths.

jared referenced this issue

2026-08-06 17:38:06 +00:00

os-sdlc: clear remaining offenses on tests/trim_status_table_test.rb under os-sdlc cop set #290

jared added the

review

label

2026-08-06 17:47:22 +00:00

jared commented

2026-08-06 17:47:23 +00:00

Author

Owner

Done in commit 86257b1 per ADR-0103 (commit 60d6f82). 739 os-sdlc runs green, rubocop clean (219 files); verified only os-sdlc sees repo-root tests/. Open for sign-off.

Done in commit 86257b1 per ADR-0103 (commit 60d6f82). 739 os-sdlc runs green, rubocop clean (219 files); verified only os-sdlc sees repo-root tests/. Open for sign-off.

jared referenced this issue

2026-08-06 18:09:54 +00:00

os-sdlc: clear tests/ offenses surfaced by the conventional-dir lint scan #289

jared commented

2026-08-06 18:09:57 +00:00

Author

Owner

Resolution

Done: conventional_test_dirs resolves per-target (code_path's parent, same anchor as bin_files); repo-root tests/ and lib/ claimed by os-sdlc via lint_paths

Evidence: commits 60d6f82 (ADR-0103) + 86257b1 + 6a73513; 739 os-sdlc runs green, rubocop clean (219 files); verified only os-sdlc sees repo-root tests/; user signed off 2026-08-06

Follow-ups: none

## Resolution **Done:** conventional_test_dirs resolves per-target (code_path's parent, same anchor as bin_files); repo-root tests/ and lib/ claimed by os-sdlc via lint_paths **Evidence:** commits 60d6f82 (ADR-0103) + 86257b1 + 6a73513; 739 os-sdlc runs green, rubocop clean (219 files); verified only os-sdlc sees repo-root tests/; user signed off 2026-08-06 **Follow-ups:** none

jared closed this issue

2026-08-06 18:09:57 +00:00

jared referenced this issue from a commit

2026-08-06 18:11:19 +00:00

os-sdlc: resolve conventional test dirs per-target (#291)

Rows
Columns

os-sdlc: scope lint-worklist conventional test dirs per-target instead of project root #291

Context

Resolution