Show staged changes in the code_changes brief fact #887

New issue

Closed

opened 2026-10-01 16:33:33 +00:00 by jared · 1 comment

jared commented

2026-10-01 16:33:33 +00:00

Owner

Problem

The code_changes brief fact does not show a file deletion that the programmer staged with git rm. The behavior-verifier reads that fact. It then reports a deletion ticket's acceptance criteria as outstanding, although the files are deleted. The run goes back to the test-writer, which cannot write a red test, and the Runner escalates with unexpected_pass.

Observed

In #883 implementation 2, the programmer deleted plugins/os-sdlc/maps/coding.yaml and plugins/os-sdlc/maps/poodr-implementation.yaml. git status --short showed both as staged deletions (D ). Behavior-verifier dispatch 13 failed AC 1 and AC 2 because its production diff showed no deletion. Its handoff said that staged deletions may be missing from code_changes. Test-writer dispatch 14 found no red test possible. The Runner returned:

{"type":"escalation","node":"needs-orchestrator","reason":"unexpected_pass:test-writer/diff-test"}

The orchestrator finished the ticket by hand.

Reproduce

n/a: needs a live pipeline run; stage a deletion with git rm in a programmer dispatch, then read the behavior-verifier brief's code_changes.

Origin

Trigger: /os-sdlc:implement 883 (implementation 2), 2026-10-01
Improvised this session: hand-finished #883 after the escalation
Chain: behavior-verifier wrong fail verdict ← code_changes (query/brief/facts.rb:99) is built from Project::Changes#code_diff (query/project/changes.rb:31) ← Git::Repo#changed_paths (adapter/git/repo.rb:55) runs git diff --name-only plus untracked files, which omits every staged change; staged_paths exists but is not used ← DESIGN (plugins/os-sdlc/lib/os_sdlc/adapter/git/repo.rb)
Root candidate: none
Where: plugins/os-sdlc/lib/os_sdlc/adapter/git/repo.rb (changed_paths)

VERDICT: CREATE — the source confirms that changed_paths omits staged changes, so a git rm deletion never reaches the behavior-verifier (ticket-skeptic, 2026-10-01).

Session: 48007765-88b8-473d-a30b-3a551275ef48
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/48007765-88b8-473d-a30b-3a551275ef48.jsonl

## Problem The `code_changes` brief fact does not show a file deletion that the programmer staged with `git rm`. The behavior-verifier reads that fact. It then reports a deletion ticket's acceptance criteria as outstanding, although the files are deleted. The run goes back to the test-writer, which cannot write a red test, and the Runner escalates with `unexpected_pass`. ## Observed In #883 implementation 2, the programmer deleted `plugins/os-sdlc/maps/coding.yaml` and `plugins/os-sdlc/maps/poodr-implementation.yaml`. `git status --short` showed both as staged deletions (`D `). Behavior-verifier dispatch 13 failed AC 1 and AC 2 because its production diff showed no deletion. Its handoff said that staged deletions may be missing from `code_changes`. Test-writer dispatch 14 found no red test possible. The Runner returned: ``` {"type":"escalation","node":"needs-orchestrator","reason":"unexpected_pass:test-writer/diff-test"} ``` The orchestrator finished the ticket by hand. ## Reproduce n/a: needs a live pipeline run; stage a deletion with `git rm` in a programmer dispatch, then read the behavior-verifier brief's `code_changes`. ## Origin - Trigger: /os-sdlc:implement 883 (implementation 2), 2026-10-01 - Improvised this session: hand-finished #883 after the escalation - Chain: behavior-verifier wrong fail verdict ← `code_changes` (`query/brief/facts.rb:99`) is built from `Project::Changes#code_diff` (`query/project/changes.rb:31`) ← `Git::Repo#changed_paths` (`adapter/git/repo.rb:55`) runs `git diff --name-only` plus untracked files, which omits every staged change; `staged_paths` exists but is not used ← DESIGN (`plugins/os-sdlc/lib/os_sdlc/adapter/git/repo.rb`) - Root candidate: none - Where: plugins/os-sdlc/lib/os_sdlc/adapter/git/repo.rb (`changed_paths`) VERDICT: CREATE — the source confirms that `changed_paths` omits staged changes, so a `git rm` deletion never reaches the behavior-verifier (ticket-skeptic, 2026-10-01). - Session: 48007765-88b8-473d-a30b-3a551275ef48 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/48007765-88b8-473d-a30b-3a551275ef48.jsonl

jared added the

plugin/os-sdlc

filed-by/agent

labels

2026-10-01 16:33:33 +00:00

jared referenced this issue

2026-10-01 16:35:27 +00:00

Delete the coding and poodr-implementation maps #883

jared referenced this issue

2026-10-01 18:17:51 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared referenced this issue from a commit