Runner diff facts omit staged deletions, so verifier roles cannot see removed files #726

New issue

Open

opened 2026-09-25 16:58:30 +00:00 by jared · 1 comment

jared commented

2026-09-25 16:58:30 +00:00

Owner

Problem

Implementation 47 of #712 deleted lib/os_sdlc/pipeline/lsp_daemon_lifecycle.rb and eight test files. The code_changes and test_changes facts given to behavior-verifier and test-reviewer carried no deletion entries. behavior-verifier marked acceptance criterion 3 (no lib reference to LspDaemonLifecycle) outstanding although grep -rl LspDaemonLifecycle plugins/os-sdlc/lib returned nothing and the file was gone. Its charter forbids running commands, so it had no other evidence. The orchestrator hand-verified and hand-finished.

Reproduce

Open an implementation whose ticket deletes a lib file.
Stage the deletion.
Inspect the code_changes fact in the behavior-verifier brief; the deleted path is absent.

Approach

Required work:

Include staged and unstaged deletions in the diff-fact builder with a deleted marker.
Give retired_tests the same visibility for test deletions.

Acceptance criteria

A fixture implementation with one staged file deletion shows it in code_changes and test_changes.
behavior-verifier can pass a deletion-based acceptance criterion from the fact alone.

Origin

Session: ecfe6e11-0810-4431-88e5-8e24d34a239e
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/ecfe6e11-0810-4431-88e5-8e24d34a239e.jsonl
Where: plugins/os-sdlc/lib/os_sdlc (diff fact builder)
Parent: #712
VERDICT: CREATE — diff-fact builder drops staged/unstaged deletions, causing behavior-verifier/test-reviewer to hand-verify; no existing ticket covers this gap.

## Problem Implementation 47 of #712 deleted lib/os_sdlc/pipeline/lsp_daemon_lifecycle.rb and eight test files. The `code_changes` and `test_changes` facts given to behavior-verifier and test-reviewer carried no deletion entries. behavior-verifier marked acceptance criterion 3 (no lib reference to LspDaemonLifecycle) outstanding although `grep -rl LspDaemonLifecycle plugins/os-sdlc/lib` returned nothing and the file was gone. Its charter forbids running commands, so it had no other evidence. The orchestrator hand-verified and hand-finished. ## Reproduce 1. Open an implementation whose ticket deletes a lib file. 2. Stage the deletion. 3. Inspect the code_changes fact in the behavior-verifier brief; the deleted path is absent. ## Approach Required work: 1. Include staged and unstaged deletions in the diff-fact builder with a `deleted` marker. 2. Give `retired_tests` the same visibility for test deletions. ## Acceptance criteria 1. A fixture implementation with one staged file deletion shows it in code_changes and test_changes. 2. behavior-verifier can pass a deletion-based acceptance criterion from the fact alone. ## Origin - Session: ecfe6e11-0810-4431-88e5-8e24d34a239e - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/ecfe6e11-0810-4431-88e5-8e24d34a239e.jsonl - Where: plugins/os-sdlc/lib/os_sdlc (diff fact builder) - Parent: #712 - VERDICT: CREATE — diff-fact builder drops staged/unstaged deletions, causing behavior-verifier/test-reviewer to hand-verify; no existing ticket covers this gap.

jared added the

plugin/os-sdlc

filed-by/agent

labels

2026-09-25 16:58:30 +00:00

jared referenced this issue

2026-09-25 16:58:43 +00:00

Route the ruby-lsp daemon lifecycle through the procman gem (ADR-0219 slice 1) #712

jared added the

category/code-change

label

2026-10-10 13:32:03 +00:00

jared commented

2026-10-18 18:58:39 +00:00

Author

Owner

Resolution

Done: Mechanism: Brief::Facts code_changes/test_changes do not show the real increment. Occurrence: #887 "Show staged changes in the code_changes brief fact".

Evidence: #887 adds a second case: in #883 implementation 2, git rm staged deletions of maps/coding.yaml and maps/poodr-implementation.yaml were absent from code_changes, so behavior-verifier failed AC1/AC2 and test-writer hit unexpected_pass.

Follow-ups: none

## Resolution **Done:** Mechanism: Brief::Facts code_changes/test_changes do not show the real increment. Occurrence: #887 "Show staged changes in the code_changes brief fact". **Evidence:** #887 adds a second case: in #883 implementation 2, git rm staged deletions of maps/coding.yaml and maps/poodr-implementation.yaml were absent from code_changes, so behavior-verifier failed AC1/AC2 and test-writer hit unexpected_pass. **Follow-ups:** none

jared referenced this issue

2026-10-18 18:59:17 +00:00

Show staged changes in the code_changes brief fact #887