jared/cc-os

Watch

Fork 0

Delete the coding and poodr-implementation maps #883

New issue

Closed

opened 2026-10-01 15:26:49 +00:00 by jared · 2 comments

jared commented

2026-10-01 15:26:49 +00:00

Owner

Problem

ADR-0259 decision 11 deletes maps/coding.yaml and maps/poodr-implementation.yaml. The ticket map maps/poodr-ticket-implementation.yaml is then the only approved map. Today tests and docs still load or name the two maps: tests/support/cli_next_instruction_helpers.rb:8 and tests/pipeline/cli_subagent_start_test.rb:11 (CODING_MAP, also used by tests/support/subagent_start_cli.rb:58), tests/adapter/map/loader_test.rb:82 (test_coding_map_loads_and_validates), tests/command/implementation/open_ticket_shape_test.rb:8 (NON_TICKET_MAP), CONTEXT.md:5, reference/handoff-artifact-format.md:28-29, and the header comment of maps/poodr-ticket-implementation.yaml:3.

Reproduce

n/a: housekeeping decision, nothing to reproduce.

Approach

Delete the two map files. Git history keeps them. Point the CLI tests that drove the coding map at a fixture copy under tests/fixtures/maps/ (reuse one if #868 already added it). Point the ticket-shape test for a map without the ticket-shape check at a fixture map. Delete test_coding_map_loads_and_validates. Replace the two doc examples with maps/poodr-ticket-implementation.yaml. Drop the "Per-behavior fallback" comment line from the ticket map.

The implement skill text at skills/implement/SKILL.md:56 that substitutes poodr-implementation changes in #874 (prose ticket).

Required work:

Delete both maps and the fallback comment — check: absent poodr-implementation in plugins/os-sdlc/maps/*.yaml
Delete the coding map — check: absent name: coding in plugins/os-sdlc/maps/*.yaml
Move tests off the real coding map — check: absent maps/coding.yaml in plugins/os-sdlc/tests/**/*.rb
Move the ticket-shape test off the real poodr-implementation map — check: absent maps/poodr-implementation.yaml in plugins/os-sdlc/tests/**/*.rb
Delete the coding map load test — check: absent test_coding_map_loads_and_validates in plugins/os-sdlc/tests/adapter/map/loader_test.rb
Replace the CONTEXT example — check: absent maps/coding.yaml in plugins/os-sdlc/CONTEXT.md
Replace the handoff format example — check: absent maps/coding.yaml in plugins/os-sdlc/reference/handoff-artifact-format.md

Acceptance criteria

Given the default map catalog, when implementation-open runs with map name coding, then it fails loudly and names the missing map file.
Given the default map catalog, when implementation-open runs with map name poodr-implementation, then it fails loudly and names the missing map file.
Given the CLI tests that drove the coding map, when the suite runs, then they drive the fixture copy and pass.
Given a fixture map that is not the ticket map, when implementation-open runs with a ticket body that has no ## Owner sketch, then it opens the run without the ticket-shape check.

Owner sketch

# no new class: two map files deleted; tests and docs point at fixtures and the ticket map

Origin

Trigger: user ruling A4 on the map reroute design, 2026-10-01 (ADR-0259 decision 11)
Improvised this session: none
Chain: maps with no required-work gate cannot be reroute targets ← two legacy maps stay approved ← DESIGN (docs/adr/0259)
Root candidate: #859
Where: plugins/os-sdlc/maps/
Session: 55a56279-83ee-47d5-a21e-ee67f9e28abd
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/55a56279-83ee-47d5-a21e-ee67f9e28abd.jsonl

Parent: #859
Blocked by: #868

## Problem ADR-0259 decision 11 deletes `maps/coding.yaml` and `maps/poodr-implementation.yaml`. The ticket map `maps/poodr-ticket-implementation.yaml` is then the only approved map. Today tests and docs still load or name the two maps: `tests/support/cli_next_instruction_helpers.rb:8` and `tests/pipeline/cli_subagent_start_test.rb:11` (`CODING_MAP`, also used by `tests/support/subagent_start_cli.rb:58`), `tests/adapter/map/loader_test.rb:82` (`test_coding_map_loads_and_validates`), `tests/command/implementation/open_ticket_shape_test.rb:8` (`NON_TICKET_MAP`), `CONTEXT.md:5`, `reference/handoff-artifact-format.md:28-29`, and the header comment of `maps/poodr-ticket-implementation.yaml:3`. ## Reproduce n/a: housekeeping decision, nothing to reproduce. ## Approach Delete the two map files. Git history keeps them. Point the CLI tests that drove the coding map at a fixture copy under `tests/fixtures/maps/` (reuse one if #868 already added it). Point the ticket-shape test for a map without the ticket-shape check at a fixture map. Delete `test_coding_map_loads_and_validates`. Replace the two doc examples with `maps/poodr-ticket-implementation.yaml`. Drop the "Per-behavior fallback" comment line from the ticket map. The implement skill text at `skills/implement/SKILL.md:56` that substitutes `poodr-implementation` changes in #874 (prose ticket). Required work: 1. Delete both maps and the fallback comment — check: absent `poodr-implementation` in `plugins/os-sdlc/maps/*.yaml` 2. Delete the coding map — check: absent `name: coding` in `plugins/os-sdlc/maps/*.yaml` 3. Move tests off the real coding map — check: absent `maps/coding.yaml` in `plugins/os-sdlc/tests/**/*.rb` 4. Move the ticket-shape test off the real poodr-implementation map — check: absent `maps/poodr-implementation.yaml` in `plugins/os-sdlc/tests/**/*.rb` 5. Delete the coding map load test — check: absent `test_coding_map_loads_and_validates` in `plugins/os-sdlc/tests/adapter/map/loader_test.rb` 6. Replace the CONTEXT example — check: absent `maps/coding.yaml` in `plugins/os-sdlc/CONTEXT.md` 7. Replace the handoff format example — check: absent `maps/coding.yaml` in `plugins/os-sdlc/reference/handoff-artifact-format.md` ## Acceptance criteria 1. Given the default map catalog, when implementation-open runs with map name `coding`, then it fails loudly and names the missing map file. 2. Given the default map catalog, when implementation-open runs with map name `poodr-implementation`, then it fails loudly and names the missing map file. 3. Given the CLI tests that drove the coding map, when the suite runs, then they drive the fixture copy and pass. 4. Given a fixture map that is not the ticket map, when implementation-open runs with a ticket body that has no `## Owner sketch`, then it opens the run without the ticket-shape check. ## Owner sketch ```ruby # no new class: two map files deleted; tests and docs point at fixtures and the ticket map ``` ## Origin - Trigger: user ruling A4 on the map reroute design, 2026-10-01 (ADR-0259 decision 11) - Improvised this session: none - Chain: maps with no required-work gate cannot be reroute targets ← two legacy maps stay approved ← DESIGN (docs/adr/0259) - Root candidate: #859 - Where: plugins/os-sdlc/maps/ - Session: 55a56279-83ee-47d5-a21e-ee67f9e28abd - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/55a56279-83ee-47d5-a21e-ee67f9e28abd.jsonl Parent: #859 Blocked by: #868

jared added the

plugin/os-sdlc

filed-by/user

labels

2026-10-01 15:26:49 +00:00

jared referenced this issue

2026-10-01 15:28:59 +00:00

Make escalation a waiting position at needs-orchestrator #872

jared referenced this issue

2026-10-01 15:29:00 +00:00

Add fits/entries map headers, entry-gates validator rule, and ticket_shape flag #870

jared referenced this issue

2026-10-01 15:29:01 +00:00

Document reroute recovery in implement skill and escalation procedure #874

jared added the

ready-for-agent

label

2026-10-01 15:29:14 +00:00

jared added a new dependency

2026-10-01 15:29:26 +00:00

#870 Add fits/entries map headers, entry-gates validator rule, and ticket_shape flag

jared added a new dependency

2026-10-01 15:29:26 +00:00

#872 Make escalation a waiting position at needs-orchestrator

jared added a new dependency

2026-10-01 15:29:27 +00:00

#868 Bind implementations to a map name through Map::Catalog

jared referenced this issue

2026-10-01 15:29:41 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared commented

2026-10-01 16:24:21 +00:00

Author

Owner

Work started on branch ticket-883 (os-sdlc pipeline, map poodr-ticket-implementation).

jared referenced this issue

2026-10-01 16:33:33 +00:00

Show staged changes in the code_changes brief fact #887

jared commented

2026-10-01 16:35:27 +00:00

Author

Owner

Resolution

Done: Deleted maps/coding.yaml and maps/poodr-implementation.yaml and the fallback comment; opening either name fails loudly naming the missing file (AC1/AC2 tests); CLI tests drive tests/fixtures/maps/coding.yaml; subprocess briefing/completion tests open poodr-ticket-implementation; ticket-shape test uses the toy fixture; test_coding_map_loads_and_validates deleted; CONTEXT.md and handoff-artifact-format.md name the ticket map. Deviations: implementation 2 escalated unexpected_pass:test-writer/diff-test after behavior-verifier dispatch 13 failed AC1/AC2 on a wrong verdict (code_changes omits staged deletions); HAND-FINISHED by a sonnet agent (no code changes needed beyond the pipeline's) plus a correction moving the coding fixture from a Ruby hash in tests/support to the YAML fixture the ticket names.

Evidence: main d155aaa8, History row; seven Required-work checks verified absent; bin/test on main: 9 suites passed; rubocop clean on changed files.

Follow-ups: Captured #887 (code_changes omits staged changes; ticket-skeptic VERDICT: CREATE). Dropped: reference/pipeline-stages.md:36 still says 'shipped coding map' - prose about routing history outside this ticket's Required work.

## Resolution **Done:** Deleted maps/coding.yaml and maps/poodr-implementation.yaml and the fallback comment; opening either name fails loudly naming the missing file (AC1/AC2 tests); CLI tests drive tests/fixtures/maps/coding.yaml; subprocess briefing/completion tests open poodr-ticket-implementation; ticket-shape test uses the toy fixture; test_coding_map_loads_and_validates deleted; CONTEXT.md and handoff-artifact-format.md name the ticket map. Deviations: implementation 2 escalated unexpected_pass:test-writer/diff-test after behavior-verifier dispatch 13 failed AC1/AC2 on a wrong verdict (code_changes omits staged deletions); HAND-FINISHED by a sonnet agent (no code changes needed beyond the pipeline's) plus a correction moving the coding fixture from a Ruby hash in tests/support to the YAML fixture the ticket names. **Evidence:** main d155aaa8, History row; seven Required-work checks verified absent; bin/test on main: 9 suites passed; rubocop clean on changed files. **Follow-ups:** Captured #887 (code_changes omits staged changes; ticket-skeptic VERDICT: CREATE). Dropped: reference/pipeline-stages.md:36 still says 'shipped coding map' - prose about routing history outside this ticket's Required work.

jared closed this issue

2026-10-01 16:35:28 +00:00

jared referenced this issue

2026-10-01 18:17:51 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared referenced this issue from a commit

2026-10-01 18:24:32 +00:00

feat(os-sdlc): #883 delete the coding and poodr-implementation maps

jared referenced this issue from a commit

2026-10-01 18:24:32 +00:00

docs: #883 History row

jared referenced this issue