jared/cc-os

Watch

Fork 0

Add the poodr-guard-implementation map for green guard tests #876

New issue

Closed

opened 2026-10-01 15:26:43 +00:00 by jared · 2 comments

jared commented

2026-10-01 15:26:43 +00:00

Owner

Problem

A guard or characterization ticket adds a test for behavior that already exists and changes no production code. The ticket map maps/poodr-ticket-implementation.yaml requires diff-test expect: red on test-writer, so such a run always escalates unexpected_pass and is finished by hand (#859; cc-plugins #79, commit 84bac12; same shape #539, #593, #638). ADR-0258 decision 12 names the first non-default map: maps/poodr-guard-implementation.yaml. It does not exist.

Reproduce

n/a: design change, nothing to reproduce.

Approach

Add plugins/os-sdlc/maps/poodr-guard-implementation.yaml:

change-auditor -> seam-designer -> test-writer (gates: { gate: diff-test, expect: green }, test-lint) -> mutation-check (agent suite-check, instructions "Run os-sdlc-gate DISPATCH_ID exactly once and stop", gates: [mutation]) -> test-reviewer -> suite-check (gates: [required-work, suite]) -> contract-auditor -> merge-ready. No programmer, refactorer, or behavior-verifier node.

Headers and nodes required by ADR-0258/ADR-0259 (A3), in the form slice 1 defines:

fits: one sentence: the ticket adds or changes tests that guard behavior that already exists, with no production change.
entries: [seam-designer, test-writer].
ticket_shape: true (the guard ticket uses the ticket template).
change-auditor edge reroute: map-router is NOT added here; slice 3 adds it to every reroutable map.
needs-orchestrator waiting node with reroute: map-router, and the map-router node (agent: map-router, enrich: [approved_maps], gates: [reroute]), copied from the ticket map's slice-1 shape.
Every agent node keeps escalate to the waiting node.

Edges with no programmer: test-writer fail -> test-writer (bound 2); mutation-check fail -> test-writer (bound 2, "the mutation survived: make the test guard the code"); test-reviewer fail -> test-writer (bound 2); suite-check fail -> test-writer (bound 2); contract-auditor fail -> escalate (no production role exists in this map).

Instructions: test-writer is told the behavior exists, the test must be green, and the handoff must carry mutation: { path:, patch: }. test-reviewer is told the new test is green by design and the mutation-check result is its red proof.

Edge-spend counters (ADR-0259 A6). LoopLedger#spend! (command/loop_ledger.rb:10) keys spends by (from_node, verdict) per implementation, and the guard map reuses node names from the ticket map. Decision: this matters only when a ticket-map loop on the same (node, verdict) was spent before the reroute; the guard map then reaches its bound early and escalates to the waiting node. The failure direction is safe: no extra loop runs, and the run stops at the orchestrator. ADR-0258 decision 8 already counts dispatches across maps, so counting edge spends across maps is consistent. This ticket keeps the shared counters and adds no ledger code. If early exhaustion shows up in practice, capture a ticket to reset spends on reroute.

Required work:

Add the guard map — check: present name: poodr-guard-implementation in plugins/os-sdlc/maps/poodr-guard-implementation.yaml
Gate test-writer on a green diff-test — check: present expect: green in plugins/os-sdlc/maps/poodr-guard-implementation.yaml
Add the mutation-check node — check: present gates: [mutation] in plugins/os-sdlc/maps/poodr-guard-implementation.yaml
Leave out the programmer — check: absent agent: programmer in plugins/os-sdlc/maps/poodr-guard-implementation.yaml

Acceptance criteria

Given the plugin maps directory, when poodr-guard-implementation is loaded through Map::Catalog, then it loads and passes Map::Validator, including the entry-gates rule (every path from seam-designer and test-writer to merge-ready passes required-work and suite).
Given the loaded guard map, when its nodes are listed, then they are change-auditor, seam-designer, test-writer, mutation-check, test-reviewer, suite-check, contract-auditor, map-router, the waiting node, and the null nodes, and none has agent programmer or behavior-verifier.
Given a run on the guard map at test-writer, when the test-writer gate records pass (new test green), then the run advances to mutation-check.
Given a run on the guard map at mutation-check, when the mutation gate fails, then the run returns to test-writer.

Owner sketch

name: poodr-guard-implementation
fits: <one sentence>
entries: [seam-designer, test-writer]
ticket_shape: true
entry: change-auditor
nodes:
  mutation-check:
    agent: suite-check
    verdict: { source: gate, gates: [mutation] }

Origin

Trigger: user ruling on the map reroute design, 2026-10-01 (ADR-0258 decision 12; ADR-0259 A3, A6)
Improvised this session: none
Chain: guard tests escalate as unexpected_pass ← only one map exists and it requires red-first ← DESIGN (docs/adr/0258)
Root candidate: #859
Where: plugins/os-sdlc/maps/poodr-ticket-implementation.yaml
Improvised this session: none
Root candidate: #859
Session: 55a56279-83ee-47d5-a21e-ee67f9e28abd
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/55a56279-83ee-47d5-a21e-ee67f9e28abd.jsonl

Parent: #859
Blocked by: #868, #869, #870, #872, #873, #885, #875

## Problem A guard or characterization ticket adds a test for behavior that already exists and changes no production code. The ticket map `maps/poodr-ticket-implementation.yaml` requires `diff-test expect: red` on test-writer, so such a run always escalates `unexpected_pass` and is finished by hand (#859; cc-plugins #79, commit 84bac12; same shape #539, #593, #638). ADR-0258 decision 12 names the first non-default map: `maps/poodr-guard-implementation.yaml`. It does not exist. ## Reproduce n/a: design change, nothing to reproduce. ## Approach Add `plugins/os-sdlc/maps/poodr-guard-implementation.yaml`: change-auditor -> seam-designer -> test-writer (gates: `{ gate: diff-test, expect: green }`, `test-lint`) -> mutation-check (agent `suite-check`, instructions "Run `os-sdlc-gate DISPATCH_ID` exactly once and stop", gates: `[mutation]`) -> test-reviewer -> suite-check (gates: `[required-work, suite]`) -> contract-auditor -> merge-ready. No programmer, refactorer, or behavior-verifier node. Headers and nodes required by ADR-0258/ADR-0259 (A3), in the form slice 1 defines: 1. `fits:` one sentence: the ticket adds or changes tests that guard behavior that already exists, with no production change. 2. `entries:` `[seam-designer, test-writer]`. 3. `ticket_shape: true` (the guard ticket uses the ticket template). 4. `change-auditor` edge `reroute: map-router` is NOT added here; slice 3 adds it to every reroutable map. 5. `needs-orchestrator` waiting node with `reroute: map-router`, and the `map-router` node (`agent: map-router`, `enrich: [approved_maps]`, `gates: [reroute]`), copied from the ticket map's slice-1 shape. 6. Every agent node keeps `escalate` to the waiting node. Edges with no programmer: test-writer `fail` -> test-writer (bound 2); mutation-check `fail` -> test-writer (bound 2, "the mutation survived: make the test guard the code"); test-reviewer `fail` -> test-writer (bound 2); suite-check `fail` -> test-writer (bound 2); contract-auditor `fail` -> escalate (no production role exists in this map). Instructions: test-writer is told the behavior exists, the test must be green, and the handoff must carry `mutation: { path:, patch: }`. test-reviewer is told the new test is green by design and the mutation-check result is its red proof. Edge-spend counters (ADR-0259 A6). `LoopLedger#spend!` (command/loop_ledger.rb:10) keys spends by `(from_node, verdict)` per implementation, and the guard map reuses node names from the ticket map. Decision: this matters only when a ticket-map loop on the same `(node, verdict)` was spent before the reroute; the guard map then reaches its bound early and escalates to the waiting node. The failure direction is safe: no extra loop runs, and the run stops at the orchestrator. ADR-0258 decision 8 already counts dispatches across maps, so counting edge spends across maps is consistent. This ticket keeps the shared counters and adds no ledger code. If early exhaustion shows up in practice, capture a ticket to reset spends on reroute. Required work: 1. Add the guard map — check: present `name: poodr-guard-implementation` in `plugins/os-sdlc/maps/poodr-guard-implementation.yaml` 2. Gate test-writer on a green diff-test — check: present `expect: green` in `plugins/os-sdlc/maps/poodr-guard-implementation.yaml` 3. Add the mutation-check node — check: present `gates: [mutation]` in `plugins/os-sdlc/maps/poodr-guard-implementation.yaml` 4. Leave out the programmer — check: absent `agent: programmer` in `plugins/os-sdlc/maps/poodr-guard-implementation.yaml` ## Acceptance criteria 1. Given the plugin maps directory, when `poodr-guard-implementation` is loaded through `Map::Catalog`, then it loads and passes `Map::Validator`, including the entry-gates rule (every path from `seam-designer` and `test-writer` to `merge-ready` passes `required-work` and `suite`). 2. Given the loaded guard map, when its nodes are listed, then they are change-auditor, seam-designer, test-writer, mutation-check, test-reviewer, suite-check, contract-auditor, map-router, the waiting node, and the null nodes, and none has agent `programmer` or `behavior-verifier`. 3. Given a run on the guard map at test-writer, when the test-writer gate records `pass` (new test green), then the run advances to mutation-check. 4. Given a run on the guard map at mutation-check, when the mutation gate fails, then the run returns to test-writer. ## Owner sketch ```yaml name: poodr-guard-implementation fits: <one sentence> entries: [seam-designer, test-writer] ticket_shape: true entry: change-auditor nodes: mutation-check: agent: suite-check verdict: { source: gate, gates: [mutation] } ``` ## Origin - Trigger: user ruling on the map reroute design, 2026-10-01 (ADR-0258 decision 12; ADR-0259 A3, A6) - Improvised this session: none - Chain: guard tests escalate as unexpected_pass ← only one map exists and it requires red-first ← DESIGN (docs/adr/0258) - Root candidate: #859 - Where: plugins/os-sdlc/maps/poodr-ticket-implementation.yaml - Improvised this session: none - Root candidate: #859 - Session: 55a56279-83ee-47d5-a21e-ee67f9e28abd - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/55a56279-83ee-47d5-a21e-ee67f9e28abd.jsonl Parent: #859 Blocked by: #868, #869, #870, #872, #873, #885, #875

jared added the

plugin/os-sdlc

filed-by/user

labels

2026-10-01 15:26:43 +00:00

jared referenced this issue

2026-10-01 15:29:39 +00:00

Accept a reroute verdict from change-auditor and route it to map-router #878

jared referenced this issue

2026-10-01 15:29:41 +00:00

Accept drafted maps at the reroute gate with bounded validator feedback #881

jared added a new dependency

2026-10-01 15:29:48 +00:00

#868 Bind implementations to a map name through Map::Catalog

jared added a new dependency

2026-10-01 15:29:48 +00:00

#869 Add map-router agent and map-making skill for reroute selection

jared added a new dependency

2026-10-01 15:29:48 +00:00

#870 Add fits/entries map headers, entry-gates validator rule, and ticket_shape flag

jared added a new dependency

2026-10-01 15:29:48 +00:00

#872 Make escalation a waiting position at needs-orchestrator

jared added a new dependency

2026-10-01 15:29:48 +00:00

#873 Add the reroute gate and the reroute landing with the REROUTE block

jared added a new dependency

2026-10-01 15:29:48 +00:00

#885 Route the ticket map waiting node to an in-map map-router node

jared added a new dependency

2026-10-01 15:29:48 +00:00

#875 Add a mutation gate that proves a green guard test goes red on a broken patch

jared added a new dependency

2026-10-01 15:29:49 +00:00

#878 Accept a reroute verdict from change-auditor and route it to map-router

jared added a new dependency

2026-10-01 15:29:50 +00:00

#881 Accept drafted maps at the reroute gate with bounded validator feedback

jared added the

ready-for-agent

label

2026-10-01 15:29:57 +00:00

jared referenced this issue

2026-10-01 15:30:09 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared referenced this issue

2026-10-01 20:25:09 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared commented

2026-10-01 20:49:17 +00:00

Author

Owner

Work started: os-sdlc pipeline on branch ticket-876 (worktree .claude/worktrees/ticket-876).

jared commented

2026-10-01 20:56:37 +00:00

Author

Owner

Resolution

Done: Added plugins/os-sdlc/maps/poodr-guard-implementation.yaml: change-auditor, seam-designer, test-writer (diff-test expect green, test-lint), mutation-check (gates: [mutation]), test-reviewer, suite-check (required-work, suite), contract-auditor, waiting and map-router nodes; no programmer or behavior-verifier.

Evidence: Pipeline implementation 9 completed with no rejections (8 dispatches, 5 min 18 s); commit a10b547d merged to main; tests/adapter/map/catalog_guard_map_test.rb loads and validates the map through Map::Catalog; bin/test 9 suites passed on main.

Follow-ups: none

## Resolution **Done:** Added plugins/os-sdlc/maps/poodr-guard-implementation.yaml: change-auditor, seam-designer, test-writer (diff-test expect green, test-lint), mutation-check (gates: [mutation]), test-reviewer, suite-check (required-work, suite), contract-auditor, waiting and map-router nodes; no programmer or behavior-verifier. **Evidence:** Pipeline implementation 9 completed with no rejections (8 dispatches, 5 min 18 s); commit a10b547d merged to main; tests/adapter/map/catalog_guard_map_test.rb loads and validates the map through Map::Catalog; bin/test 9 suites passed on main. **Follow-ups:** none

jared closed this issue

2026-10-01 20:56:37 +00:00

jared referenced this issue

2026-10-01 21:23:06 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared referenced this issue from a commit

2026-10-02 17:43:17 +00:00

feat(os-sdlc): Audited POODR boundaries for #876; the guard map is configuration only, no Ruby production change, R1-R4 present, tests go through the public Map::Catalog#load seam. (#876)

jared referenced this issue from a commit

2026-10-02 17:43:17 +00:00

docs: #876 History row