jared/cc-os

Watch

Fork 0

Accept drafted maps at the reroute gate with bounded validator feedback #881

New issue

Closed

opened 2026-10-01 15:26:46 +00:00 by jared · 3 comments

jared commented

2026-10-01 15:26:46 +00:00

Owner

Problem

ADR-0258 decisions 4 and 9 let map-router draft a map when no approved map fits. A draft that fails Map::Loader or Map::Validator must reach map-router as feedback, bounded at 2 rounds (decision 4). The REROUTE block also does not show that the chosen map is a draft.

Reproduce

n/a: design change, nothing to reproduce.

Approach

Validator feedback for a drafted map surfaces at os-sdlc-implementation-map-update, per ADR-0260. Reroute::Draft#write already refuses a map that does not load and writes no reroute row. The reroute gate does not change: it still confirms that a pending reroute row exists (Reroute::Check#report).

Reroute::Block prints map: NAME (drafted) when the proposed map is drafted (Map#drafted?), else map: NAME (selected).
The map-router node fail edge becomes { to: map-router, bound: 2 } in plugins/os-sdlc/maps/poodr-ticket-implementation.yaml, plugins/os-sdlc/maps/poodr-guard-implementation.yaml, and plugins/os-sdlc/tests/fixtures/maps/reroute_waiting.yaml. The pass edge stays unchanged.
A test pins that map-update with a drafted map that fails the validator exits nonzero with the validator message and writes no reroute row. The behavior exists; the test protects it.

Required work:

Label drafted maps in the REROUTE block — check: present (drafted) in plugins/os-sdlc/lib/os_sdlc/presenter/reroute/block.rb
Send map-router failures back to map-router in the ticket map — check: present to: map-router, bound: 2 in plugins/os-sdlc/maps/poodr-ticket-implementation.yaml
Send map-router failures back to map-router in the guard map — check: present to: map-router, bound: 2 in plugins/os-sdlc/maps/poodr-guard-implementation.yaml
Send map-router failures back to map-router in the reroute_waiting fixture — check: present to: map-router, bound: 2 in plugins/os-sdlc/tests/fixtures/maps/reroute_waiting.yaml

Acceptance criteria

Given a reroute whose proposed map is drafted, when the REROUTE block prints, then it reads map: NAME (drafted); for an approved map it reads map: NAME (selected).
Given map-router calls os-sdlc-implementation-map-update with a drafted map that fails Map::Validator, then the CLI exits nonzero naming the defect and writes no row.
Given the map-router node in both approved maps and the reroute_waiting fixture, then its fail edge is { to: map-router, bound: 2 }.

Owner sketch

class OsSdlc::Reroute::Block
  def initialize(reroute, map)
  def to_s
end

Origin

Trigger: user ruling on the map reroute design, 2026-10-01 (ADR-0258 decisions 4, 9; ADR-0259 A3)
Improvised this session: none
Chain: an unmapped ticket shape is hand-finished ← the reroute gate accepts only approved maps ← DESIGN (docs/adr/0258)
Root candidate: #859
Where: plugins/os-sdlc/lib/os_sdlc/presenter/reroute/block.rb, plugins/os-sdlc/maps/poodr-ticket-implementation.yaml, plugins/os-sdlc/maps/poodr-guard-implementation.yaml, plugins/os-sdlc/tests/fixtures/maps/reroute_waiting.yaml
Session: 55a56279-83ee-47d5-a21e-ee67f9e28abd
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/55a56279-83ee-47d5-a21e-ee67f9e28abd.jsonl

Parent: #859
Blocked by: #880, #873, #876, #904

## Problem ADR-0258 decisions 4 and 9 let map-router draft a map when no approved map fits. A draft that fails `Map::Loader` or `Map::Validator` must reach map-router as feedback, bounded at 2 rounds (decision 4). The REROUTE block also does not show that the chosen map is a draft. ## Reproduce n/a: design change, nothing to reproduce. ## Approach Validator feedback for a drafted map surfaces at `os-sdlc-implementation-map-update`, per ADR-0260. `Reroute::Draft#write` already refuses a map that does not load and writes no reroute row. The reroute gate does not change: it still confirms that a pending reroute row exists (`Reroute::Check#report`). 1. `Reroute::Block` prints `map: NAME (drafted)` when the proposed map is drafted (`Map#drafted?`), else `map: NAME (selected)`. 2. The map-router node `fail` edge becomes `{ to: map-router, bound: 2 }` in `plugins/os-sdlc/maps/poodr-ticket-implementation.yaml`, `plugins/os-sdlc/maps/poodr-guard-implementation.yaml`, and `plugins/os-sdlc/tests/fixtures/maps/reroute_waiting.yaml`. The `pass` edge stays unchanged. 3. A test pins that map-update with a drafted map that fails the validator exits nonzero with the validator message and writes no reroute row. The behavior exists; the test protects it. Required work: 1. Label drafted maps in the REROUTE block — check: present `(drafted)` in `plugins/os-sdlc/lib/os_sdlc/presenter/reroute/block.rb` 2. Send map-router failures back to map-router in the ticket map — check: present `to: map-router, bound: 2` in `plugins/os-sdlc/maps/poodr-ticket-implementation.yaml` 3. Send map-router failures back to map-router in the guard map — check: present `to: map-router, bound: 2` in `plugins/os-sdlc/maps/poodr-guard-implementation.yaml` 4. Send map-router failures back to map-router in the reroute_waiting fixture — check: present `to: map-router, bound: 2` in `plugins/os-sdlc/tests/fixtures/maps/reroute_waiting.yaml` ## Acceptance criteria 1. Given a reroute whose proposed map is drafted, when the REROUTE block prints, then it reads `map: NAME (drafted)`; for an approved map it reads `map: NAME (selected)`. 2. Given map-router calls os-sdlc-implementation-map-update with a drafted map that fails Map::Validator, then the CLI exits nonzero naming the defect and writes no row. 3. Given the map-router node in both approved maps and the reroute_waiting fixture, then its `fail` edge is `{ to: map-router, bound: 2 }`. ## Owner sketch ```ruby class OsSdlc::Reroute::Block def initialize(reroute, map) def to_s end ``` ## Origin - Trigger: user ruling on the map reroute design, 2026-10-01 (ADR-0258 decisions 4, 9; ADR-0259 A3) - Improvised this session: none - Chain: an unmapped ticket shape is hand-finished ← the reroute gate accepts only approved maps ← DESIGN (docs/adr/0258) - Root candidate: #859 - Where: plugins/os-sdlc/lib/os_sdlc/presenter/reroute/block.rb, plugins/os-sdlc/maps/poodr-ticket-implementation.yaml, plugins/os-sdlc/maps/poodr-guard-implementation.yaml, plugins/os-sdlc/tests/fixtures/maps/reroute_waiting.yaml - Session: 55a56279-83ee-47d5-a21e-ee67f9e28abd - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/55a56279-83ee-47d5-a21e-ee67f9e28abd.jsonl Parent: #859 Blocked by: #880, #873, #876, #904

jared added the

plugin/os-sdlc

filed-by/user

labels

2026-10-01 15:26:46 +00:00

jared referenced this issue

2026-10-01 15:29:42 +00:00

Document map drafting and the promote-map step #882

jared added a new dependency

2026-10-01 15:29:50 +00:00

#880 Resolve drafted maps from maps/drafts/ through Map::Catalog

jared added a new dependency

2026-10-01 15:29:50 +00:00

#873 Add the reroute gate and the reroute landing with the REROUTE block

jared added a new dependency

2026-10-01 15:29:50 +00:00

#876 Add the poodr-guard-implementation map for green guard tests

jared added a new dependency

2026-10-01 15:29:50 +00:00

#882 Document map drafting and the promote-map step

jared added the

ready-for-agent

label

2026-10-01 15:30:01 +00:00

jared referenced this issue

2026-10-01 15:30:09 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared referenced this issue

2026-10-01 20:25:09 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared referenced this issue

2026-10-01 21:21:53 +00:00

Resolve drafted maps from maps/drafts/ through Map::Catalog #880

jared referenced this issue

2026-10-01 21:23:06 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared referenced this issue

2026-10-02 16:08:17 +00:00

Rule where drafted maps live (plugin cache is wiped by refresh-plugins) #898

jared commented

2026-10-02 16:59:51 +00:00

Author

Owner

Work started on branch ticket-881 (os-sdlc pipeline, map poodr-ticket-implementation).

jared commented

2026-10-02 17:11:16 +00:00

Author

Owner

Re-scoped 2026-10-02 after implementation 10 escalation (change-auditor dispatch 75): validator feedback surfaces at map-update (Draft#write already refuses, no row); gate unchanged per ADR-0260. Remaining work: drafted label, map-router fail bound 2, pinning test.

jared commented

2026-10-02 17:24:15 +00:00

Author

Owner

Resolution

Done: Re-scoped after implementation 10 escalation (stale premise: gate cannot read the map-router handoff, ADR-0260). Validator feedback for a drafted map surfaces at map-update (Draft#write refuses, writes no row) and is now pinned by test. Reroute::Block prints (drafted)/(selected) via Map#drafted?. map-router fail edge loops to map-router at bound 2 in both approved maps and the reroute_waiting fixture.

Evidence: Branch ticket-881: 9bbc53ea (implementation 12), History row f212e32a. Suite-check dispatch 106 green incl. required-work; behavior-verifier dispatch 105 pass; contract-auditor dispatch 107 pass. Implementation 10 abandoned with reason.

Follow-ups: none

## Resolution **Done:** Re-scoped after implementation 10 escalation (stale premise: gate cannot read the map-router handoff, ADR-0260). Validator feedback for a drafted map surfaces at map-update (Draft#write refuses, writes no row) and is now pinned by test. Reroute::Block prints (drafted)/(selected) via Map#drafted?. map-router fail edge loops to map-router at bound 2 in both approved maps and the reroute_waiting fixture. **Evidence:** Branch ticket-881: 9bbc53ea (implementation 12), History row f212e32a. Suite-check dispatch 106 green incl. required-work; behavior-verifier dispatch 105 pass; contract-auditor dispatch 107 pass. Implementation 10 abandoned with reason. **Follow-ups:** none

jared closed this issue

2026-10-02 17:24:16 +00:00

jared referenced this issue

2026-10-02 17:36:01 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared referenced this issue

2026-10-02 17:39:43 +00:00

A map change merged by another session stops an in-flight implementation with Map::ChangedError #915

jared referenced this issue from a commit

2026-10-02 17:43:17 +00:00

feat(os-sdlc): Audited POODR boundaries for #881; Reroute::Block asks Map#drafted? for its label, map-router fail edges loop to map-router bound 2, R1-R4 present, contracts protected. (#881)

jared referenced this issue from a commit