Rename Round* identifiers to implementation vocabulary in the os-sdlc runner #452

Open
opened 2026-08-20 23:21:20 +00:00 by jared · 1 comment
Owner

Origin: #438 slice 7 seam-design pass, decision D41-A / OQ5 (approved 2026-08-20). Deferred out of #446 so the doc-only slice stays reviewable.

The map-driven runner's domain vocabulary moved from "round" to "implementation", but ~7 production files keep round-named identifiers: RoundCommands, RoundTransition, RoundContext, Dispatch.*_for_round, and a hook helper. Rename them to implementation vocabulary in one mechanical sweep. Note tests/runner/cli_next_instruction_test.rb:36 (test_next_fails_loudly_on_an_abandoned_round_with_no_successor) still carries the round-vocabulary method name; the assertion body at line 42 was already migrated to /abandoned implementation/ ahead of this ticket, so only the method name needs the rename now. Prose uses of "round" in dated reference docs are legitimate and stay (D46).

Reference: docs/os-sdlc-rebuild/interface-sketches.md slice-7 section (D41, OQ5).

Origin: #438 slice 7 seam-design pass, decision D41-A / OQ5 (approved 2026-08-20). Deferred out of #446 so the doc-only slice stays reviewable. The map-driven runner's domain vocabulary moved from "round" to "implementation", but ~7 production files keep round-named identifiers: RoundCommands, RoundTransition, RoundContext, Dispatch.*_for_round, and a hook helper. Rename them to implementation vocabulary in one mechanical sweep. Note tests/runner/cli_next_instruction_test.rb:36 (test_next_fails_loudly_on_an_abandoned_round_with_no_successor) still carries the round-vocabulary method name; the assertion body at line 42 was already migrated to /abandoned implementation/ ahead of this ticket, so only the method name needs the rename now. Prose uses of "round" in dated reference docs are legitimate and stay (D46). Reference: docs/os-sdlc-rebuild/interface-sketches.md slice-7 section (D41, OQ5).
Author
Owner

Body corrected 2026-08-23 from code-probe verification (agent a5b569411cbd8fb82, claude-sonnet-5).

Change log:

  • Corrected the test citation: tests/runner/cli_next_instruction_test.rb:42's assertion was already migrated to /abandoned implementation/ before this ticket was filed. The stale round-vocabulary identifier is the test method name at line 36 (test_next_fails_loudly_on_an_abandoned_round_with_no_successor), not the line-42 assertion body.

Reason: the ticket's main sweep (RoundCommands, RoundTransition, RoundContext, Dispatch.*_for_round) is confirmed unchanged and still needed; only the specific test-line detail had drifted from a partial migration that happened after the ticket was drafted.

Body corrected 2026-08-23 from code-probe verification (agent a5b569411cbd8fb82, claude-sonnet-5). Change log: - Corrected the test citation: tests/runner/cli_next_instruction_test.rb:42's assertion was already migrated to /abandoned implementation/ before this ticket was filed. The stale round-vocabulary identifier is the test *method name* at line 36 (test_next_fails_loudly_on_an_abandoned_round_with_no_successor), not the line-42 assertion body. Reason: the ticket's main sweep (RoundCommands, RoundTransition, RoundContext, Dispatch.*_for_round) is confirmed unchanged and still needed; only the specific test-line detail had drifted from a partial migration that happened after the ticket was drafted.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jared/cc-os#452
No description provided.