Raise DuplicatedStatementSequence WINDOW_SIZE to 3 #389

New issue

Closed

opened 2026-08-14 20:38:51 +00:00 by jared · 2 comments

jared commented

2026-08-14 20:38:51 +00:00

Owner

Post-#380 audit: 19/20 residual offenses are arrange-step/test-setup boilerplate (construction pairs, fixture setup, assert-select idioms). Measured with a scratch cop copy: WINDOW_SIZE=3 drops 20 -> 1 offense. Trade-off: also stops catching the 2-statement config.rb duplication, handled separately in its own ticket. Change WINDOW_SIZE in plugins/os-sdlc/lib/os_sdlc/cops/duplicated_statement_sequence.rb, update tests, re-measure.

jared added the

ready-for-agent

plugin/os-sdlc

labels

2026-08-14 20:38:51 +00:00

jared referenced this issue

2026-08-14 20:39:00 +00:00

Calibrate mined Sdlc cops against their source test files #369

jared referenced this issue

2026-08-14 20:39:05 +00:00

Retune Sdlc/Dry/DuplicatedStatementSequence: exclude assertion windows #380

jared commented

2026-08-14 21:03:33 +00:00

Author

Owner

Retargeting per user decision: scoping DuplicatedStatementSequence to production code (Exclude test/eval paths) instead of raising WINDOW_SIZE to 3.

jared referenced this issue

2026-08-14 21:07:57 +00:00

Resolve residual Dry offense in cc-architect audit.rb collect_issues #391

jared commented

2026-08-14 21:08:03 +00:00

Author

Owner

Resolution

Done: Retargeted per user decision: kept WINDOW_SIZE=2, scoped Sdlc/Dry/DuplicatedStatementSequence to production code via Exclude globs for tests/, test/, and eval/ dirs in plugins/os-sdlc/.rubocop.yml

Evidence: Commits e3ee223 + a143310; repo-wide offenses 20 -> 1 (only audit.rb:207 remains; config.rb signal was preserved until fixed by #390 in a34bc1c); os-sdlc suite 876 runs green

Follow-ups: Residual audit.rb offense captured as #391

## Resolution **Done:** Retargeted per user decision: kept WINDOW_SIZE=2, scoped Sdlc/Dry/DuplicatedStatementSequence to production code via Exclude globs for tests/, test/, and eval/ dirs in plugins/os-sdlc/.rubocop.yml **Evidence:** Commits e3ee223 + a143310; repo-wide offenses 20 -> 1 (only audit.rb:207 remains; config.rb signal was preserved until fixed by #390 in a34bc1c); os-sdlc suite 876 runs green **Follow-ups:** Residual audit.rb offense captured as #391

jared closed this issue

2026-08-14 21:08:03 +00:00

jared referenced this issue from a commit

2026-08-14 21:11:59 +00:00

fix(os-sdlc): scope DuplicatedStatementSequence to production code (#389)

jared referenced this issue from a commit

2026-08-14 21:11:59 +00:00

fix(os-sdlc): exclude singular test/ dirs from Dry cop (#389)