os-sdlc: lint gate runs rubocop repo-wide, fails every ticket on pre-existing offenses #386
Labels
No labels
P0
P1
P2
P3
bug
create
delete
enhancement
filed-by/agent
filed-by/user
frozen
lint-rule
needs-info
needs-triage
next
plugin/cc-architect
plugin/os
plugin/os-adr
plugin/os-aidd-lint
plugin/os-backlog
plugin/os-context
plugin/os-doc-hygiene
plugin/os-sdlc
plugin/os-vault
project/cc-os
ready-for-agent
ready-for-human
recurring
review
update
waiting
wayfinder:grilling
wayfinder:map
wayfinder:map
wayfinder:research
wayfinder:task
wayfinder:task
wontfix
worklist/deviations
worklist/lint-rule
worklist/new-implement-build
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
jared/cc-os#386
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found during #354 (ADR-0116). The lint stage gate lints the whole repo (3,286 pre-existing offenses across 516 files, incl. a Lint/Syntax error in an unrelated component), so every ticket's lint gate fails regardless of its own diff and must be skipped as noise, eroding the gate's signal. Scope the lint gate to the ticket's changed files or the target's lint_paths.
Resolution
Done: Obsolete on arrival: #362 (
fa0985f) already replaced the repo-wide rubocop lint gate with the scoped 'os-sdlc lint {{ticket_id}}' gate (target code_path + tests + lint_paths via LintWorklistTarget) before this issue was filedEvidence: plugins/os-sdlc/maps/default.yaml lint row gate is 'os-sdlc lint {{ticket_id}}' on main; #354's run hit the old gate only because its worktree branched pre-#362
Follow-ups: none