jared/cc-os
Watch
1
0
Fork
You've already forked cc-os
 0
Code Issues 147 Pull requests Projects Releases Packages Wiki Activity

Deduplicate PositiveChecker/NegativeChecker #initialize in os-vault/eval/bin/check #382

New issue
Closed
opened 2026-08-14 20:12:13 +00:00 by jared · 2 comments
jared commented 2026-08-14 20:12:13 +00:00
Owner
Copy link

Parent #369. The one non-test real hit from the DuplicatedStatementSequence audit.

Build: plugins/os-vault/eval/bin/check -- NegativeChecker#initialize duplicates PositiveChecker#initialize verbatim. Extract the shared construction into a common base or shared initializer.

Acceptance:

  • the duplication is gone; Sdlc/Dry/DuplicatedStatementSequence no longer flags this file.
  • eval harness still runs unchanged.

Blocked-by: none (out of #370's test-only scope).

Parent #369. The one non-test real hit from the DuplicatedStatementSequence audit. Build: plugins/os-vault/eval/bin/check -- NegativeChecker#initialize duplicates PositiveChecker#initialize verbatim. Extract the shared construction into a common base or shared initializer. Acceptance: - the duplication is gone; Sdlc/Dry/DuplicatedStatementSequence no longer flags this file. - eval harness still runs unchanged. Blocked-by: none (out of #370's test-only scope).
jared commented 2026-08-14 20:30:03 +00:00
Author
Owner
Copy link

Starting: dedup os-vault eval check initializers

Starting: dedup os-vault eval check initializers
jared commented 2026-08-14 20:31:27 +00:00
Author
Owner
Copy link

Resolution

Done: Extracted Checker base class; PositiveChecker/NegativeChecker#initialize now share it via super

Evidence: Commit edeca6a; ruby -c OK; eval self-test 23/23 passed

Follow-ups: none

## Resolution **Done:** Extracted Checker base class; PositiveChecker/NegativeChecker#initialize now share it via super **Evidence:** Commit edeca6a; ruby -c OK; eval self-test 23/23 passed **Follow-ups:** none
jared closed this issue 2026-08-14 20:31:28 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
P0
Priority 0 — drop everything

  
P1
Priority 1 — next up

  
P2
Priority 2 — normal

  
P3
Priority 3 — someday

  
bug
Something is broken

  
create
Ticket creates something new

  
delete
Ticket removes something

  
enhancement
New feature or improvement

  
filed-by/agent

   
filed-by/user

   
frozen
Pre-reset backlog freeze 2026-08-16; do not work unless rediscovered by a live run

  
lint-rule
Ticket proposes/modifies a lint rule or cop

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
next
Human-curated next up — AI never applies or removes

  
plugin/cc-architect
Scope: the cc-architect plugin

  
plugin/os
Scope: the os plugin

  
plugin/os-adr
Scope: the os-adr plugin

  
plugin/os-aidd-lint
Scope: the os-aidd-lint plugin

  
plugin/os-backlog
Scope: the os-backlog plugin

  
plugin/os-context
Scope: the os-context plugin

  
plugin/os-doc-hygiene
Scope: the os-doc-hygiene plugin

  
plugin/os-sdlc
Scope: the os-sdlc plugin

  
plugin/os-vault
Scope: the os-vault plugin

  
project/cc-os
Parent-scope: cc-os repo-wide, not specific to one plugin

  
ready-for-agent
Triage complete; an agent can pick this up

  
ready-for-human
Human-owned; never picked up autonomously

  
recurring
Recurring flavor: occurrence outcomes commented, never closed by AI

  
review
Shipped semi work awaiting human sign-off

  
update
Ticket updates something existing

  
waiting
Blocked; blocker named in a comment

  
wayfinder:grilling

   
wayfinder:map

   
wayfinder:map
wayfinder map ticket

  
wayfinder:research

   
wayfinder:task

   
wayfinder:task
wayfinder map child: task

  
wontfix
Will not be actioned

  
worklist/deviations
Deviation incidents from skill/pipeline runs — evidence pile for correcting the owning artifact

  
worklist/lint-rule
Proposed os-sdlc or os-aidd-lint rule

  
worklist/new-implement-build
Updated implementation harness (ast-grep + stepper)

No labels
P0
P1
P2
P3
bug
create
delete
enhancement
filed-by/agent
filed-by/user
frozen
lint-rule
needs-info
needs-triage
next
plugin/cc-architect
plugin/os
plugin/os-adr
plugin/os-aidd-lint
plugin/os-backlog
plugin/os-context
plugin/os-doc-hygiene
plugin/os-sdlc
plugin/os-vault
project/cc-os
ready-for-agent
ready-for-human
recurring
review
update
waiting
wayfinder:grilling
wayfinder:map
wayfinder:map
wayfinder:research
wayfinder:task
wayfinder:task
wontfix
worklist/deviations
worklist/lint-rule
worklist/new-implement-build
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jared/cc-os#382
No description provided.