Add os-sdlc:test-lint-fixer agent and the early test-lint gate to /os-sdlc:implement

jared commented

2026-08-07 13:16:49 +00:00

Owner

Design: ADR-0107 (docs/adr/0107-dedicated-test-lint-fixer-agent-with-early-test-lint-gate-and-path-routed-late-gate.md); decisions charted on wayfinder map #310 (tickets #311, #312).

Acceptance criteria

A new agent file plugins/os-sdlc/agents/test-lint-fixer.md exists, mirroring lint-fixer.md's structure: per-file assignment (path + verbatim offense list, no ticket context), tools Read/Write/Edit/Glob/Grep/Bash, model sonnet, rubocop-scoped self-verification, disclosure list return format, never deletes its assignment file, never asks questions. Scope inversion: it edits ONLY files under the project's test_path and never any other file. Assertion-set invariant stated: may extract helpers, split test methods, rename locals, restructure non-assertion code; must never add, remove, weaken, or merge an assertion. lint-fixer.md is unchanged.
New transition-table rows in plugins/os-sdlc/lib/os_sdlc/transition_table/ insert an early test-lint gate between the first red-assert and shard-plan: (1) safe autocorrect (rubocop -a) scoped to only the test files the test-writer dispatch created/edited this run, (2) rubocop check scoped to the same files, (3) if residuals, per-file fanout dispatch of os-sdlc:test-lint-fixer via the existing worklist/assignment machinery, (4) red-assert re-runs if and only if a fixer edited a file. Clean rubocop → no dispatch, no re-run, gate adds no steps.
All gate/sequencing logic is in tested Ruby in the transition table, none in skills/implement/SKILL.md prose (ADR-0097).
Transition-table unit tests cover: clean path (no dispatch, no re-assert), dirty path (fanout + conditional red-assert re-run), and scoping (files outside the test-writer's set are not linted at this gate).
Full suite green; rubocop clean.

Design: ADR-0107 (docs/adr/0107-dedicated-test-lint-fixer-agent-with-early-test-lint-gate-and-path-routed-late-gate.md); decisions charted on wayfinder map #310 (tickets #311, #312). ## Acceptance criteria - A new agent file plugins/os-sdlc/agents/test-lint-fixer.md exists, mirroring lint-fixer.md's structure: per-file assignment (path + verbatim offense list, no ticket context), tools Read/Write/Edit/Glob/Grep/Bash, model sonnet, rubocop-scoped self-verification, disclosure list return format, never deletes its assignment file, never asks questions. Scope inversion: it edits ONLY files under the project's test_path and never any other file. Assertion-set invariant stated: may extract helpers, split test methods, rename locals, restructure non-assertion code; must never add, remove, weaken, or merge an assertion. lint-fixer.md is unchanged. - New transition-table rows in plugins/os-sdlc/lib/os_sdlc/transition_table/ insert an early test-lint gate between the first red-assert and shard-plan: (1) safe autocorrect (rubocop -a) scoped to only the test files the test-writer dispatch created/edited this run, (2) rubocop check scoped to the same files, (3) if residuals, per-file fanout dispatch of os-sdlc:test-lint-fixer via the existing worklist/assignment machinery, (4) red-assert re-runs if and only if a fixer edited a file. Clean rubocop → no dispatch, no re-run, gate adds no steps. - All gate/sequencing logic is in tested Ruby in the transition table, none in skills/implement/SKILL.md prose (ADR-0097). - Transition-table unit tests cover: clean path (no dispatch, no re-assert), dirty path (fanout + conditional red-assert re-run), and scoping (files outside the test-writer's set are not linted at this gate). - Full suite green; rubocop clean.

jared added the

ready-for-agent

enhancement

labels

2026-08-07 13:16:49 +00:00

jared referenced this issue

2026-08-07 13:16:58 +00:00

Route late-gate lint offenses by path: test_path files dispatch to test-lint-fixer #318

jared referenced this issue

2026-08-07 13:17:08 +00:00

Route test-file lint offenses to the test-writer, not the lint-fixer #308

jared referenced this issue

2026-08-07 13:17:14 +00:00

Record the ADR and spec the implementation tickets #314

jared referenced this issue

2026-08-07 13:17:32 +00:00

Wayfinder map: early test-lint gate + test-file lint routing in os-sdlc:implement #310

jared referenced this issue

2026-08-07 13:17:32 +00:00

Wayfinder map: early test-lint gate + test-file lint routing in os-sdlc:implement #310

jared referenced this issue

2026-08-07 14:36:24 +00:00

Persist select-target answer onto pre-existing sdlc artifacts #319

jared commented

2026-08-07 14:36:30 +00:00

Author

Owner

Implemented on branch sdlc/317 (worktree .sdlc/worktrees/sdlc-317) via /os-sdlc:implement. Suite green (777 runs), rubocop clean, reviewer APPROVE after 3 change rounds. Awaiting merge decision.

jared added the

plugin/os-sdlc

label

2026-08-13 18:11:50 +00:00

jared commented

2026-08-13 18:12:03 +00:00

Author

Owner

Branch sdlc/317 never merged; predates the #341/#342 map-driven engine rewrite (large diff vs current lib/os_sdlc/runner). ADR-0107 still Accepted and not superseded, so the design stands, but implementation needs re-scoping onto current architecture rather than merging the stale branch. Leaving open.

jared referenced this issue

2026-08-13 18:12:04 +00:00

Route late-gate lint offenses by path: test_path files dispatch to test-lint-fixer #318

jared commented

2026-08-13 18:33:41 +00:00

Author

Owner

Closing as superseded: branch sdlc/317 predates the map-driven runner rewrite (ADR-0097, #341/#342 waves) — 247-file stale diff, never merged. The test-lint gate concept from ADR-0107 needs re-scoping against the current stepper if revived.

jared closed this issue

2026-08-13 18:33:42 +00:00

jared referenced this issue

2026-08-13 18:33:43 +00:00

Route late-gate lint offenses by path: test_path files dispatch to test-lint-fixer #318

Rows
Columns

Add os-sdlc:test-lint-fixer agent and the early test-lint gate to /os-sdlc:implement #317

Acceptance criteria