jared/cc-os

Watch

Fork 0

os-adr: Repository owns the ADR file-name rule and Adr.slugify #934

New issue

Open

opened 2026-10-04 17:14:34 +00:00 by jared · 1 comment

jared commented

2026-10-04 17:14:34 +00:00

Owner

Problem

Adr.slugify still lives on the namespace root in the loader file plugins/os-adr/lib/adr.rb, while the file-name rule "#{id}-#{Adr.slugify(title)}.md" lives in Adr::Repository#path_for (plugins/os-adr/lib/adr/repository.rb:96). The duplicate copy in the record creator is gone: plugins/os-adr/lib/adr/record/creation.rb:54 already calls @repository.path_for. What remains is the slug rule sitting in the loader file instead of with its only owner.

Approach

Adr::Repository (plugins/os-adr/lib/adr/repository.rb) owns the slug rule.

Required work:

Move Adr.slugify out of plugins/os-adr/lib/adr.rb into Adr::Repository, updating every caller (grep plugins/os-adr) — check: absent slugify in plugins/os-adr/lib/adr.rb

Acceptance criteria

Given the refactored code, when ruby plugins/os-adr/tests/all.rb runs, then the suite passes with the same run count.
Given the refactored Repository, when bin/adr-new creates an ADR, then it writes the same file names as before.
Given plugins/os-adr/lib/adr.rb, when inspected, then it only boots the loader (no slugify definition).

Owner sketch

class Adr::Repository
  def file_name(id, title)
    "#{id}-#{slugify(title)}.md"
  end

  private

  def slugify(title)
    # slug implementation moved from Adr.slugify
  end
end

class Adr::Record::Creation
  def initialize(repository)
    @repository = repository
  end

  def file_name(id, title)
    @repository.file_name(id, title)
  end
end

Non-goals

Changing the slug algorithm or file-name format.

Origin

Trigger: crc-refactor run on plugins/os-adr, worktree crc-os-adr-2026-10-04
Improvised this session: none
Chain: structure-only refactor decided to defer slugify move to follow-up ← ADR-0271 (Proposed) and ruling R17 (option A: slugify belongs to Repository)
Root candidate: none (this is the root)
Where: plugins/os-adr/lib/adr/command/record/creation.rb and plugins/os-adr/lib/adr/adapter/repository.rb
Session: a20defa9-036a-415a-9dde-2ed833c727cb
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-refactor-docs/a20defa9-036a-415a-9dde-2ed833c727cb.jsonl

VERDICT: CREATE. Recorded decision R17 (option A) provides provenance. The file-name rule exists in two copies, so this is real duplication that a ruling chose to fix. The Origin chain ends in a ruling, not an IMPROVISATION.

Note

Rewritten 2026-10-16 for the A15 domain-first layout (9e416b0f); the creation.rb duplicate no longer exists.

## Problem `Adr.slugify` still lives on the namespace root in the loader file plugins/os-adr/lib/adr.rb, while the file-name rule `"#{id}-#{Adr.slugify(title)}.md"` lives in `Adr::Repository#path_for` (plugins/os-adr/lib/adr/repository.rb:96). The duplicate copy in the record creator is gone: plugins/os-adr/lib/adr/record/creation.rb:54 already calls `@repository.path_for`. What remains is the slug rule sitting in the loader file instead of with its only owner. ## Approach `Adr::Repository` (plugins/os-adr/lib/adr/repository.rb) owns the slug rule. Required work: 1. Move `Adr.slugify` out of plugins/os-adr/lib/adr.rb into `Adr::Repository`, updating every caller (grep plugins/os-adr) — check: absent `slugify` in `plugins/os-adr/lib/adr.rb` ## Acceptance criteria 1. Given the refactored code, when ruby plugins/os-adr/tests/all.rb runs, then the suite passes with the same run count. 2. Given the refactored Repository, when bin/adr-new creates an ADR, then it writes the same file names as before. 3. Given plugins/os-adr/lib/adr.rb, when inspected, then it only boots the loader (no slugify definition). ## Owner sketch ```ruby class Adr::Repository def file_name(id, title) "#{id}-#{slugify(title)}.md" end private def slugify(title) # slug implementation moved from Adr.slugify end end class Adr::Record::Creation def initialize(repository) @repository = repository end def file_name(id, title) @repository.file_name(id, title) end end ``` ## Non-goals Changing the slug algorithm or file-name format. ## Origin - Trigger: crc-refactor run on plugins/os-adr, worktree crc-os-adr-2026-10-04 - Improvised this session: none - Chain: structure-only refactor decided to defer slugify move to follow-up ← ADR-0271 (Proposed) and ruling R17 (option A: slugify belongs to Repository) - Root candidate: none (this is the root) - Where: plugins/os-adr/lib/adr/command/record/creation.rb and plugins/os-adr/lib/adr/adapter/repository.rb - Session: a20defa9-036a-415a-9dde-2ed833c727cb - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-refactor-docs/a20defa9-036a-415a-9dde-2ed833c727cb.jsonl VERDICT: CREATE. Recorded decision R17 (option A) provides provenance. The file-name rule exists in two copies, so this is real duplication that a ruling chose to fix. The Origin chain ends in a ruling, not an IMPROVISATION. ## Note Rewritten 2026-10-16 for the A15 domain-first layout (9e416b0f); the creation.rb duplicate no longer exists.

jared added the

plugin/os-adr

filed-by/agent

labels

2026-10-04 17:14:34 +00:00

jared referenced this issue

2026-10-04 17:15:00 +00:00

crc os-adr wave 4: Record concept into role directories; loader collapses six role directories #926

jared referenced this issue

2026-10-04 17:15:02 +00:00

crc os-adr wave 4: Repository, Index, Invocation, RootFlag into role directories; cli/ dissolves; AdrTestHelpers to AdrFixtures #927

jared referenced this issue

2026-10-04 17:15:03 +00:00

crc os-adr wave 4: Migration concept into role directories #928

jared referenced this issue

2026-10-04 17:15:05 +00:00

crc os-adr wave 5: split Detector: file reads leave the classifying model #929

jared referenced this issue

2026-10-04 17:15:06 +00:00

crc os-adr wave 5: split CliInvocationHelpers: assert_* methods leave #930

jared referenced this issue

2026-10-04 17:15:07 +00:00

crc os-adr wave 4: Classification to parser/migration/legacy_file.rb as Migration::LegacyFile #932

jared referenced this issue

2026-10-04 17:15:08 +00:00

crc os-adr wave 4: nest StatusResult, PostgresRecordAssertions to RecordCreationAssertions, split cli_test.rb by command #933

jared added the

category/investigation

label

2026-10-10 13:31:48 +00:00

jared commented

2026-10-16 16:22:40 +00:00

Author

Owner

Body rewritten 2026-10-16 with current A15 paths: the duplicate file-name rule in record/creation.rb is already gone (it calls Repository#path_for); only Adr.slugify in plugins/os-adr/lib/adr.rb remains to move into Repository.

jared added

category/structure

and removed

category/investigation

labels

2026-10-18 19:19:27 +00:00