jared/cc-os

Watch

Fork 0

crc os-adr wave 4: Classification to parser/migration/legacy_file.rb as Migration::LegacyFile #932

New issue

Closed

opened 2026-10-04 16:55:06 +00:00 by jared · 3 comments

jared commented

2026-10-04 16:55:06 +00:00

Owner

Problem

Wave 5 extraction #929 created Classification.
The wave 2 re-run found its role is parser (text in, Units out, no state kept).
Its name names a step (A8).

Reproduce

n/a: structure-only refactor, no behavior change

Approach

Move plugins/os-adr/lib/adr/model/migration/classification.rb to plugins/os-adr/lib/adr/parser/migration/legacy_file.rb
Rename constant Adr::Migration::Classification to Adr::Migration::LegacyFile
Update callers: plugins/os-adr/lib/adr/query/migration/inventory.rb (constant name only)
test_path is none, so no test moves
R19 ruling applies
R9 ruling applies (parser naming convention)

Rejected:

Keep Classification in model/ (R19 option B: a step name in the model directory for a text-in, objects-out parser)

Acceptance criteria

The row applied, or logged in docs/crc/os-adr/deviations.md, or reported blocked
ruby plugins/os-adr/tests/all.rb 0 failures
ruby -e 'require "./plugins/os-adr/lib/adr"; Adr.loader.eager_load' silent
inward lint: none

Owner sketch

n/a

Non-goals

No behavior change
No new tests
No deletion of code that has callers

Origin

Session: a20defa9-036a-415a-9dde-2ed833c727cb
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-refactor-docs/a20defa9-036a-415a-9dde-2ed833c727cb.jsonl
Where: crc-refactor run on plugins/os-adr, worktree crc-os-adr-2026-10-04, ledger docs/crc/os-adr/ledger.tsv

## Problem Wave 5 extraction #929 created Classification. The wave 2 re-run found its role is parser (text in, Units out, no state kept). Its name names a step (A8). ## Reproduce n/a: structure-only refactor, no behavior change ## Approach 1. Move plugins/os-adr/lib/adr/model/migration/classification.rb to plugins/os-adr/lib/adr/parser/migration/legacy_file.rb 2. Rename constant Adr::Migration::Classification to Adr::Migration::LegacyFile 3. Update callers: plugins/os-adr/lib/adr/query/migration/inventory.rb (constant name only) 4. test_path is none, so no test moves 5. R19 ruling applies 6. R9 ruling applies (parser naming convention) Rejected: - Keep Classification in model/ (R19 option B: a step name in the model directory for a text-in, objects-out parser) ## Acceptance criteria - The row applied, or logged in docs/crc/os-adr/deviations.md, or reported blocked - `ruby plugins/os-adr/tests/all.rb` 0 failures - `ruby -e 'require "./plugins/os-adr/lib/adr"; Adr.loader.eager_load'` silent - inward lint: none ## Owner sketch n/a ## Non-goals - No behavior change - No new tests - No deletion of code that has callers ## Origin Session: a20defa9-036a-415a-9dde-2ed833c727cb Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-refactor-docs/a20defa9-036a-415a-9dde-2ed833c727cb.jsonl Where: crc-refactor run on plugins/os-adr, worktree crc-os-adr-2026-10-04, ledger docs/crc/os-adr/ledger.tsv

jared added the

plugin/os-adr

filed-by/user

labels

2026-10-04 16:55:06 +00:00

jared commented

2026-10-04 16:55:53 +00:00

Author

Owner

47b5620e is superseded; see next line

jared commented

2026-10-04 16:55:59 +00:00

Author

Owner

e32381f1; rows applied 1/1; rows deviated 0; rows blocked 0 (an earlier comment naming 47b5620e is superseded by this SHA after an amend)

e32381f1; rows applied 1/1; rows deviated 0; rows blocked 0 (an earlier comment naming 47b5620e is superseded by this SHA after an amend)

jared referenced this issue

2026-10-04 17:15:05 +00:00

crc os-adr wave 5: split Detector: file reads leave the classifying model #929

jared commented

2026-10-04 17:15:07 +00:00

Author

Owner

Resolution

Done: Migration::Classification moved to parser/migration/legacy_file.rb as Migration::LegacyFile (R19)

Evidence: e32381f1 on branch crc-os-adr-2026-10-04 (not merged; user review pending); suite: 51 runs, 168 assertions, 0 failures, 0 errors, 0 skips; eager load silent; inward lint: none (os-adr has none)

Follow-ups: none for this ticket; run-level follow-ups filed as #934 and #935; dropped items listed in docs/crc/os-adr/HANDOFF.md Review

## Resolution **Done:** Migration::Classification moved to parser/migration/legacy_file.rb as Migration::LegacyFile (R19) **Evidence:** e32381f1 on branch crc-os-adr-2026-10-04 (not merged; user review pending); suite: 51 runs, 168 assertions, 0 failures, 0 errors, 0 skips; eager load silent; inward lint: none (os-adr has none) **Follow-ups:** none for this ticket; run-level follow-ups filed as #934 and #935; dropped items listed in docs/crc/os-adr/HANDOFF.md Review

jared closed this issue

2026-10-04 17:15:07 +00:00

jared referenced this issue from a commit

2026-10-05 13:50:50 +00:00

refactor(os-adr): Migration::Classification to parser/migration/legacy_file.rb as Migration::LegacyFile (#932)

jared referenced this issue from a commit

2026-10-05 13:50:50 +00:00

docs(os-adr): crc-refactor ledger commit column for #932; ticket table