Wire test-required-work into the test-writer node and amend the briefs and ADR-0244 #866

New issue

Open

opened 2026-10-01 11:10:02 +00:00 by jared · 0 comments

jared commented

2026-10-01 11:10:02 +00:00

Owner

Problem

After #865 adds the test-required-work gate step, no pipeline node runs it, and the test-writer, test-reviewer, and change-auditor briefs still tell test-writer not to edit existing tests. #863 ruled Option A: test-writer changes the existing tests a ticket names, and a gate step checks the result in the red round. ADR-0244 must record that routing.

Reproduce

n/a: wiring and prose change, nothing to reproduce.

Approach

Add - test-required-work to the test-writer node gates after retired-tests in the ticket map. Change plugins/os-sdlc/agents/test-writer.md line 40 from "add a test only for a test-writer WORK: item with no AC proof." to "edit the existing test a test-writer WORK: item names; add a test only for an item with no AC proof or named file." Edit the test-reviewer and change-auditor briefs to match.

## Retired tests already supports path#method. This ticket covers migrating shared test helpers and fakes, which Retired tests cannot do.

Required work:

Wire the gate into the test-writer node — check: present test-required-work in plugins/os-sdlc/maps/poodr-ticket-implementation.yaml
Replace the test-writer brief sentence — check: absent add a test only for a test-writer in plugins/os-sdlc/agents/test-writer.md
Edit the test-reviewer and change-auditor briefs to match the new test-writer rule.

Orchestrator work: write an ADR that amends ADR-0244. Run /os-adr:find first. If find says a ruling is needed, stop and escalate to the user.

Acceptance criteria

Given the ticket map, when the test-writer node is read, then its gates list test-required-work after retired-tests.
Given the test-writer brief, when it is read, then it tells test-writer to edit the existing test that a WORK: item names.
Given the test-reviewer and change-auditor briefs, when they are read, then they accept an edit to a named existing test as proof of a WORK: item.

Owner sketch

# no new class: map gate list and agent brief edits only

Origin

Trigger: user ruling on #863, Option A, 2026-10-01
Improvised this session: none
Chain: test-path Required work escalates ← programmer-repair never edits tests ← DESIGN (docs/adr/0244, Consequences)
Root candidate: #863
Where: plugins/os-sdlc/maps/poodr-ticket-implementation.yaml
Session: 55a56279-83ee-47d5-a21e-ee67f9e28abd
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/55a56279-83ee-47d5-a21e-ee67f9e28abd.jsonl

Parent: #863
Blocked by: #865

## Problem After #865 adds the `test-required-work` gate step, no pipeline node runs it, and the test-writer, test-reviewer, and change-auditor briefs still tell test-writer not to edit existing tests. #863 ruled Option A: test-writer changes the existing tests a ticket names, and a gate step checks the result in the red round. ADR-0244 must record that routing. ## Reproduce n/a: wiring and prose change, nothing to reproduce. ## Approach Add `- test-required-work` to the test-writer node gates after `retired-tests` in the ticket map. Change `plugins/os-sdlc/agents/test-writer.md` line 40 from "add a test only for a test-writer WORK: item with no AC proof." to "edit the existing test a test-writer WORK: item names; add a test only for an item with no AC proof or named file." Edit the test-reviewer and change-auditor briefs to match. `## Retired tests` already supports `path#method`. This ticket covers migrating shared test helpers and fakes, which Retired tests cannot do. Required work: 1. Wire the gate into the test-writer node — check: present `test-required-work` in `plugins/os-sdlc/maps/poodr-ticket-implementation.yaml` 2. Replace the test-writer brief sentence — check: absent `add a test only for a test-writer` in `plugins/os-sdlc/agents/test-writer.md` 3. Edit the test-reviewer and change-auditor briefs to match the new test-writer rule. Orchestrator work: write an ADR that amends ADR-0244. Run /os-adr:find first. If find says a ruling is needed, stop and escalate to the user. ## Acceptance criteria 1. Given the ticket map, when the test-writer node is read, then its gates list `test-required-work` after `retired-tests`. 2. Given the test-writer brief, when it is read, then it tells test-writer to edit the existing test that a WORK: item names. 3. Given the test-reviewer and change-auditor briefs, when they are read, then they accept an edit to a named existing test as proof of a WORK: item. ## Owner sketch ```ruby # no new class: map gate list and agent brief edits only ``` ## Origin - Trigger: user ruling on #863, Option A, 2026-10-01 - Improvised this session: none - Chain: test-path Required work escalates ← programmer-repair never edits tests ← DESIGN (docs/adr/0244, Consequences) - Root candidate: #863 - Where: plugins/os-sdlc/maps/poodr-ticket-implementation.yaml - Session: 55a56279-83ee-47d5-a21e-ee67f9e28abd - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/55a56279-83ee-47d5-a21e-ee67f9e28abd.jsonl Parent: #863 Blocked by: #865

jared added the

plugin/os-sdlc

filed-by/user

ready-for-agent

labels

2026-10-01 11:10:02 +00:00

jared added a new dependency

2026-10-01 11:10:30 +00:00

#865 Add a test-required-work gate step for test-path Required-work checks

jared added a new dependency

2026-10-01 11:10:31 +00:00

#846 implementation-open places the worktree through worktree start; payload tells the skill to enter, exit, and finish