No os-sdlc role migrates existing tests named in Required work #863

New issue

Open

opened 2026-09-30 21:23:24 +00:00 by jared · 1 comment

jared commented

2026-09-30 21:23:24 +00:00

Owner

Problem

The os-sdlc ticket map gives new tests to the test-writer and production changes to the programmer. The programmer never edits tests. The test-writer adds one new test for each acceptance criterion. No role changes an existing test that pins a seam that the ticket replaces. ## Retired tests only deletes whole files. Thus a ticket that replaces a seam leaves the old tests failing, and the programmer spends each repair on failures that it must not fix.

Observed

Two runs on 2026-09-30 escalated for this cause:

#858, implementation 17: bound_exhausted:programmer-repair/fail after dispatches 135-138. The ticket did not name the stale tea-runner tests (issue_source_test.rb, issue_source_forgejo_test.rb, issue_source_github_test.rb, tracker/tea_*_test.rb). Hand-finished.
#856, implementation 18: bound_exhausted:programmer-repair/fail after dispatches 145-148. The ticket named about 14 test files to migrate in Required work items 8-12. The test-writer left them unchanged and added new tests. Each repair used 3-4 tool calls. Suite: 285 runs, 15 failures, 9 errors; about 20 were the named stale tests. Hand-finished.
A ticket that names the migration does not prevent the failure, because the work list has no owner for it.

Reproduce

n/a: observed in two pipeline runs; a ticket whose Required work names an existing test file to migrate reproduces it.

Approach

Give existing-test migration an owner. Option 1: the test-writer round includes Required work items that name existing test files, and the test-reviewer checks them. Option 2: a dedicated node migrates the named tests before the programmer runs.

Acceptance criteria

A ticket whose Required work names an existing test file to migrate completes its implementation without a hand-finish.

VERDICT: CREATE — two runs (#858, #856) escalated for the same cause; no open ticket assigns existing-test migration to a role (#727 Retired-tests check, #709 post-green test defects, #644 writer/reviewer loop are different).

Origin

Session: e5cfbe57-4cd0-4d7e-aabd-f64294775172
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/e5cfbe57-4cd0-4d7e-aabd-f64294775172.jsonl
Where: plugins/os-sdlc maps/poodr-ticket-implementation.yaml (work-list Align step, test-writer brief)

## Problem The os-sdlc ticket map gives new tests to the test-writer and production changes to the programmer. The programmer never edits tests. The test-writer adds one new test for each acceptance criterion. No role changes an existing test that pins a seam that the ticket replaces. `## Retired tests` only deletes whole files. Thus a ticket that replaces a seam leaves the old tests failing, and the programmer spends each repair on failures that it must not fix. ## Observed Two runs on 2026-09-30 escalated for this cause: - #858, implementation 17: `bound_exhausted:programmer-repair/fail` after dispatches 135-138. The ticket did not name the stale tea-runner tests (`issue_source_test.rb`, `issue_source_forgejo_test.rb`, `issue_source_github_test.rb`, `tracker/tea_*_test.rb`). Hand-finished. - #856, implementation 18: `bound_exhausted:programmer-repair/fail` after dispatches 145-148. The ticket named about 14 test files to migrate in Required work items 8-12. The test-writer left them unchanged and added new tests. Each repair used 3-4 tool calls. Suite: 285 runs, 15 failures, 9 errors; about 20 were the named stale tests. Hand-finished. A ticket that names the migration does not prevent the failure, because the work list has no owner for it. ## Reproduce n/a: observed in two pipeline runs; a ticket whose Required work names an existing test file to migrate reproduces it. ## Approach Give existing-test migration an owner. Option 1: the test-writer round includes Required work items that name existing test files, and the test-reviewer checks them. Option 2: a dedicated node migrates the named tests before the programmer runs. ## Acceptance criteria 1. A ticket whose Required work names an existing test file to migrate completes its implementation without a hand-finish. VERDICT: CREATE — two runs (#858, #856) escalated for the same cause; no open ticket assigns existing-test migration to a role (#727 Retired-tests check, #709 post-green test defects, #644 writer/reviewer loop are different). ## Origin Session: e5cfbe57-4cd0-4d7e-aabd-f64294775172 Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/e5cfbe57-4cd0-4d7e-aabd-f64294775172.jsonl Where: plugins/os-sdlc maps/poodr-ticket-implementation.yaml (work-list Align step, test-writer brief)

jared added the

plugin/os-sdlc

filed-by/agent

labels

2026-09-30 21:23:24 +00:00

jared referenced this issue

2026-09-30 21:31:20 +00:00

Replace tea with forgejo-api in os-backlog #856

jared referenced this issue

2026-10-01 11:09:46 +00:00

Add a test-required-work gate step for test-path Required-work checks #865

jared referenced this issue

2026-10-01 11:10:02 +00:00

Wire test-required-work into the test-writer node and amend the briefs and ADR-0244 #866

jared referenced this issue

2026-10-01 11:10:38 +00:00

implementation-open places the worktree through worktree start; payload tells the skill to enter, exit, and finish #846

jared commented

2026-10-01 11:10:38 +00:00

Author

Owner

User ruled Option A on 2026-10-01. Children: #865, #866. Premise correction: ## Retired tests already supports path#method; this work covers shared helpers and fakes.

User ruled Option A on 2026-10-01. Children: #865, #866. Premise correction: `## Retired tests` already supports `path#method`; this work covers shared helpers and fakes.

jared added the

category/owner-ruling

label

2026-10-10 13:31:54 +00:00