jared/cc-os

Watch

Fork 0

Decide the home for RequiredWork shared by os-backlog and os-sdlc (cc-os gem or CLI seam) #699

New issue

Closed

opened 2026-09-24 17:44:41 +00:00 by jared · 2 comments

jared commented

2026-09-24 17:44:41 +00:00

Owner

Problem

plugins/os-backlog/lib/backlog/required_work.rb:4 and plugins/os-sdlc/lib/os_sdlc/pipeline/ticket_shape/required_work.rb:6 are byte-identical (flay identical, mass 164). The plugins have no Ruby-level coupling; os-sdlc already shells out to the os-backlog CLI in pipeline/body_fetch.rb to fetch ticket bodies. Cross-plugin duplication is recurring, and the user is weighing a shared cc-os gem.

Approach

This is an architecture decision, not a refactor. Options: (a) the os-backlog CLI returns required_work_listed alongside the body and os-sdlc drops its copy; (b) a shared cc-os gem holds RequiredWork and other cross-plugin code. Record the choice with /os-adr:create before any code moves.

Required work:

Survey other cross-plugin duplicates and CLI shell-outs between plugins
Write the ADR recording the chosen seam
File the implementation ticket

Acceptance criteria

ADR recorded naming the chosen seam
follow-up implementation ticket filed

Reproduce

n/a: decision ticket

Origin

Session: adee71b2-6515-41c7-b5ad-73f41b824603
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/adee71b2-6515-41c7-b5ad-73f41b824603.jsonl
Where: plugins/os-sdlc/lib/os_sdlc/pipeline/body_fetch.rb
Skeptic: user-approved this session (dedup batch 4, follows #677/#678)

## Problem `plugins/os-backlog/lib/backlog/required_work.rb:4` and `plugins/os-sdlc/lib/os_sdlc/pipeline/ticket_shape/required_work.rb:6` are byte-identical (flay identical, mass 164). The plugins have no Ruby-level coupling; os-sdlc already shells out to the os-backlog CLI in `pipeline/body_fetch.rb` to fetch ticket bodies. Cross-plugin duplication is recurring, and the user is weighing a shared `cc-os` gem. ## Approach This is an architecture decision, not a refactor. Options: (a) the os-backlog CLI returns `required_work_listed` alongside the body and os-sdlc drops its copy; (b) a shared cc-os gem holds RequiredWork and other cross-plugin code. Record the choice with /os-adr:create before any code moves. Required work: 1. Survey other cross-plugin duplicates and CLI shell-outs between plugins 2. Write the ADR recording the chosen seam 3. File the implementation ticket ## Acceptance criteria - [ ] ADR recorded naming the chosen seam - [ ] follow-up implementation ticket filed ## Reproduce n/a: decision ticket ## Origin Session: adee71b2-6515-41c7-b5ad-73f41b824603 Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/adee71b2-6515-41c7-b5ad-73f41b824603.jsonl Where: plugins/os-sdlc/lib/os_sdlc/pipeline/body_fetch.rb Skeptic: user-approved this session (dedup batch 4, follows #677/#678)

jared added the

labels

2026-09-24 17:44:41 +00:00

jared referenced this issue

2026-09-24 20:21:13 +00:00

capture body-style rules say checklists are - [ ] but the template and Required-work parsers require numbered lines #664

jared referenced this issue

2026-09-24 20:21:14 +00:00

os-backlog: heading parser treats # lines inside code fences as headings #650

jared referenced this issue

2026-09-24 20:34:24 +00:00

capture body-style rules say checklists are - [ ] but the template and Required-work parsers require numbered lines #664

jared referenced this issue

2026-09-24 20:34:26 +00:00

os-backlog: heading parser treats # lines inside code fences as headings #650

jared referenced this issue

2026-09-25 15:03:16 +00:00

ADR: supersede ADR-0218 item 1 — os and os-backlog libraries take collaborators and paths as parameters, only bin/ reads process globals #716

jared referenced this issue

2026-09-25 15:04:07 +00:00

os: FinishCommand takes git: and after_merge: collaborators; Invocation from bin/worktree; remove env: and thread-local #717

jared commented

2026-09-25 15:04:41 +00:00

Author

Owner

Add to the cross-plugin duplication survey: #717 introduces plugins/os/lib/worktree/git.rb (Worktree::Git), an os copy of os-sdlc's Adapter::Git::Repo (plugins/os-sdlc/lib/os_sdlc/adapter/git/repo.rb), plus a FakeGit test double mirroring os-sdlc's tests/test_helper.rb FakeGit. Duplicated by ADR-0025 item 4 (no cross-plugin source coupling).

jared referenced this issue

2026-09-25 15:24:02 +00:00

os-backlog: bin/os-backlog resolves CC_OS_HOME once into state_dir; library takes paths as parameters; remove CliEnvContext #718

jared referenced this issue

2026-09-25 15:25:59 +00:00

os-backlog: bin/os-backlog resolves CC_OS_HOME once into state_dir; library takes paths as parameters; remove CliEnvContext #718

jared referenced this issue

2026-09-25 16:23:02 +00:00

os: FinishCommand takes git: and after_merge: collaborators; Invocation from bin/worktree; remove env: and thread-local #717

jared commented

2026-09-28 15:58:18 +00:00

Author

Owner

Resolution

Done: Decided to keep both RequiredWork copies separate rather than sharing code between os-backlog and os-sdlc.

Evidence: ADR-0239 at docs/adr/0239-requiredwork-stays-duplicated-in-os-backlog-and-os-sdlc.md, commit 53531f49; both files verified identical modulo module nesting

Follow-ups: none

## Resolution **Done:** Decided to keep both RequiredWork copies separate rather than sharing code between os-backlog and os-sdlc. **Evidence:** ADR-0239 at docs/adr/0239-requiredwork-stays-duplicated-in-os-backlog-and-os-sdlc.md, commit 53531f49; both files verified identical modulo module nesting **Follow-ups:** none

jared closed this issue

2026-09-28 15:58:18 +00:00

jared referenced this issue from a commit

2026-09-28 19:36:44 +00:00

docs(adr): ADR-0239 RequiredWork stays duplicated across os-backlog and os-sdlc (#699)