os-backlog: heading parser treats # lines inside code fences as headings #650

New issue

Closed

opened 2026-09-23 18:21:40 +00:00 by jared · 1 comment

jared commented

2026-09-23 18:21:40 +00:00

Owner

heading parsers do not skip fenced code, so `#` lines inside a block become false sections

Problem

Neither plugins/os-backlog/lib/backlog/issue_body/lines.rb (find_heading_matches) nor plugins/os-sdlc/lib/os_sdlc/pipeline/ticket_shape/section.rb (bodies_for) tracks fence state. A #-prefixed line inside a fenced code block (seen in #629 and #626 bodies) is read as a section heading, creating false or duplicate sections. #563 FenceMask shipped for os-aidd-lint only (plugins/os-aidd-lint/lib/aidd_lint/fence_mask.rb); the backlog and os-sdlc parsers were not covered.

Cases

Given a body with a fenced block containing a # comment line, when either parser scans for headings, then that line is not counted as a heading.
Given the same body with the fenced line removed, when either parser scans for headings, then it reports the same sections as case 1.

Approach

Add fence-state skipping to each parser directly. Cross-plugin sharing of FenceMask is a #699-class decision; a small local fence tracker in each parser is acceptable here.

Required work:

Add fence-state skipping to Lines#find_heading_matches in plugins/os-backlog/lib/backlog/issue_body/lines.rb
Add the same fence-state skipping to TicketShape::Section#bodies_for in plugins/os-sdlc/lib/os_sdlc/pipeline/ticket_shape/section.rb
Extend plugins/os-sdlc/tests/model/ticket_shape_parity_test.rb and add an os-backlog IssueBody test with a fenced # not a heading case

Acceptance criteria

Given a body with a fenced block containing # comment, when both parsers read it, then they report the same sections as for the body without that line.

Non-goals

Sharing one FenceMask implementation across plugins is out of scope; that is #699's decision.

Origin

Trigger: #643 merge verification, 2026-09-23
Chain: parser defect ← DESIGN (ADR-0190, ADR-0209)
Where: plugins/os-backlog/lib/backlog/issue_body/lines.rb, plugins/os-sdlc/lib/os_sdlc/pipeline/ticket_shape/section.rb
Session: 073fd763-259f-4218-95e6-e8449caae354

# heading parsers do not skip fenced code, so `#` lines inside a block become false sections ## Problem Neither plugins/os-backlog/lib/backlog/issue_body/lines.rb (`find_heading_matches`) nor plugins/os-sdlc/lib/os_sdlc/pipeline/ticket_shape/section.rb (`bodies_for`) tracks fence state. A `#`-prefixed line inside a fenced code block (seen in #629 and #626 bodies) is read as a section heading, creating false or duplicate sections. #563 FenceMask shipped for os-aidd-lint only (plugins/os-aidd-lint/lib/aidd_lint/fence_mask.rb); the backlog and os-sdlc parsers were not covered. ## Cases 1. Given a body with a fenced block containing a `# comment` line, when either parser scans for headings, then that line is not counted as a heading. 2. Given the same body with the fenced line removed, when either parser scans for headings, then it reports the same sections as case 1. ## Approach Add fence-state skipping to each parser directly. Cross-plugin sharing of FenceMask is a #699-class decision; a small local fence tracker in each parser is acceptable here. Required work: 1. Add fence-state skipping to `Lines#find_heading_matches` in plugins/os-backlog/lib/backlog/issue_body/lines.rb 2. Add the same fence-state skipping to `TicketShape::Section#bodies_for` in plugins/os-sdlc/lib/os_sdlc/pipeline/ticket_shape/section.rb 3. Extend plugins/os-sdlc/tests/model/ticket_shape_parity_test.rb and add an os-backlog IssueBody test with a fenced `# not a heading` case ## Acceptance criteria 1. Given a body with a fenced block containing `# comment`, when both parsers read it, then they report the same sections as for the body without that line. ## Non-goals Sharing one FenceMask implementation across plugins is out of scope; that is #699's decision. ## Origin - Trigger: #643 merge verification, 2026-09-23 - Chain: parser defect ← DESIGN (ADR-0190, ADR-0209) - Where: plugins/os-backlog/lib/backlog/issue_body/lines.rb, plugins/os-sdlc/lib/os_sdlc/pipeline/ticket_shape/section.rb - Session: 073fd763-259f-4218-95e6-e8449caae354

jared added the

plugin/os-backlog

filed-by/agent

labels

2026-09-23 18:21:40 +00:00

jared added the

ready-for-agent

label

2026-09-24 20:21:14 +00:00

jared commented

2026-09-24 20:34:26 +00:00

Author

Owner

Resolution

Done: both heading parsers skip lines inside code fences via a FenceStack per plugin; parity test and IssueBody test cover a fenced heading line

Evidence: commit cfdfcc30; os-backlog 245 runs 0 failures, os-sdlc 1427 runs 0 failures

Follow-ups: #699 decides whether one shared FenceMask replaces the two local FenceStack copies (open)

## Resolution **Done:** both heading parsers skip lines inside code fences via a FenceStack per plugin; parity test and IssueBody test cover a fenced heading line **Evidence:** commit cfdfcc30; os-backlog 245 runs 0 failures, os-sdlc 1427 runs 0 failures **Follow-ups:** #699 decides whether one shared FenceMask replaces the two local FenceStack copies (open)

jared closed this issue

2026-09-24 20:34:26 +00:00

jared referenced this issue from a commit

2026-09-26 13:57:00 +00:00

fix(os-backlog,os-sdlc): heading parsers skip lines inside code fences (#650)

jared referenced this issue from a commit

2026-09-26 13:57:00 +00:00

docs: History rows for the 2026-09-24 quick-win batch (#649 #682 #596 #664 #650 #549)

jared referenced this issue from a commit

2026-10-09 18:43:29 +00:00

feat(takedown-eval): seven training cases from merged diffs (#615 #650 #735 #736 #772 #803 #822)

jared referenced this issue from a commit