TEST ISSUE for debug #685

New issue

Closed

opened 2026-09-24 17:11:11 +00:00 by jared · 1 comment

jared commented

2026-09-24 17:11:11 +00:00

Owner

Problem

coding.yaml:25 gives the reviewer node enrich: [ticket_brief, gate_results]. The gate_results fact carries each gate step's full output text (brief_facts.rb gate_results, output passed through sized). The reviewer charter says at agents/reviewer.md:13: "The deterministic gates already prove mechanical code quality: style, lint, structure. Do not re-check it." None of the six judgment checks reference gate text. Measured over the project pipeline DB (2026-09-17 to 2026-09-24): gate_results median 3,812 chars per dispatch, max 240,397. The hook cap is 10,000 UTF-16 units (ADR-0206), so this fact alone pushes reviewer briefs into the fallback path.

Reproduce

n/a: design audit finding, not a runtime defect.

Approach

Add a gate_verdicts fact resolver in brief_facts.rb that returns { step => verdict } from latest_step_summaries with no output field. Change coding.yaml:25 to enrich: [ticket_brief, gate_verdicts]. Update the reviewer charter Input line if it names gate output. Template: the red_tests trim in #670.

Required work:

Red test: BriefFacts#fact("gate_verdicts") returns step-to-verdict only.
Resolver + FACT_RESOLVERS entry.
Map edit coding.yaml:25.

Evidence

Audit row from #676: map coding.yaml | node reviewer | fact gate_results | TRIM | reviewer.md:13 "Do not re-check it."

Origin

Trigger: #676 enrich-fact audit, run in session 9434289b
Improvised this session: none

## Problem coding.yaml:25 gives the reviewer node `enrich: [ticket_brief, gate_results]`. The gate_results fact carries each gate step's full output text (brief_facts.rb `gate_results`, output passed through `sized`). The reviewer charter says at agents/reviewer.md:13: "The deterministic gates already prove mechanical code quality: style, lint, structure. Do not re-check it." None of the six judgment checks reference gate text. Measured over the project pipeline DB (2026-09-17 to 2026-09-24): gate_results median 3,812 chars per dispatch, max 240,397. The hook cap is 10,000 UTF-16 units (ADR-0206), so this fact alone pushes reviewer briefs into the fallback path. ## Reproduce n/a: design audit finding, not a runtime defect. ## Approach Add a `gate_verdicts` fact resolver in brief_facts.rb that returns `{ step => verdict }` from latest_step_summaries with no output field. Change coding.yaml:25 to `enrich: [ticket_brief, gate_verdicts]`. Update the reviewer charter Input line if it names gate output. Template: the red_tests trim in #670. Required work: - [ ] Red test: BriefFacts#fact("gate_verdicts") returns step-to-verdict only. - [ ] Resolver + FACT_RESOLVERS entry. - [ ] Map edit coding.yaml:25. ## Evidence Audit row from #676: map coding.yaml | node reviewer | fact gate_results | TRIM | reviewer.md:13 "Do not re-check it." ## Origin - Trigger: #676 enrich-fact audit, run in session 9434289b - Improvised this session: none

jared added the

plugin/os-sdlc

filed-by/agent

labels

2026-09-24 17:11:11 +00:00

jared commented

2026-09-24 20:10:19 +00:00

Author

Owner

Resolution

Done: stray test artifact, not a defect

Evidence: title is TEST ISSUE for debug and body duplicates #679, which shipped in 06b9c675

Follow-ups: none

## Resolution **Done:** stray test artifact, not a defect **Evidence:** title is TEST ISSUE for debug and body duplicates #679, which shipped in 06b9c675 **Follow-ups:** none

jared closed this issue

2026-09-24 20:10:19 +00:00