reviewer receives full gate output it is told not to re-check; trim gate_results to gate verdicts #679

New issue

Closed

opened 2026-09-24 17:11:05 +00:00 by jared · 1 comment

jared commented

2026-09-24 17:11:05 +00:00

Owner

Problem

coding.yaml:25 gives the reviewer node enrich: [ticket_brief, gate_results]. The gate_results fact carries each gate step's full output text (brief_facts.rb gate_results, output passed through sized). The reviewer charter says at agents/reviewer.md:13: "The deterministic gates already prove mechanical code quality: style, lint, structure. Do not re-check it." None of the six judgment checks reference gate text. Measured over the project pipeline DB (2026-09-17 to 2026-09-24): gate_results median 3,812 chars per dispatch, max 240,397. The hook cap is 10,000 UTF-16 units (ADR-0206), so this fact alone pushes reviewer briefs into the fallback path.

Reproduce

n/a: design audit finding, not a runtime defect.

Approach

Add a gate_verdicts fact resolver in brief_facts.rb that returns { step => verdict } from latest_step_summaries with no output field. Change coding.yaml:25 to enrich: [ticket_brief, gate_verdicts]. Update the reviewer charter Input line if it names gate output. Template: the red_tests trim in #670.

Required work:

Red test: BriefFacts#fact("gate_verdicts") returns step-to-verdict only.
Resolver + FACT_RESOLVERS entry.
Map edit coding.yaml:25.

Evidence

Audit row from #676: map coding.yaml | node reviewer | fact gate_results | TRIM | reviewer.md:13 "Do not re-check it."

Origin

Trigger: #676 enrich-fact audit, run in session 9434289b
Improvised this session: none
Chain: oversized or duplicated brief facts <- enrich lists chosen per node without a per-role byte audit <- DESIGN (map enrich model)
Root candidate: this ticket
Where: the map/charter/composer paths named in the draft
Parent: #676
Session: 9434289b-c48f-4a8a-8add-0d82068e2c3f
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/9434289b-c48f-4a8a-8add-0d82068e2c3f.jsonl

Skeptic verdict: CREATE (os-backlog:ticket-skeptic, session 9434289b, citations verified).

## Problem coding.yaml:25 gives the reviewer node `enrich: [ticket_brief, gate_results]`. The gate_results fact carries each gate step's full output text (brief_facts.rb `gate_results`, output passed through `sized`). The reviewer charter says at agents/reviewer.md:13: "The deterministic gates already prove mechanical code quality: style, lint, structure. Do not re-check it." None of the six judgment checks reference gate text. Measured over the project pipeline DB (2026-09-17 to 2026-09-24): gate_results median 3,812 chars per dispatch, max 240,397. The hook cap is 10,000 UTF-16 units (ADR-0206), so this fact alone pushes reviewer briefs into the fallback path. ## Reproduce n/a: design audit finding, not a runtime defect. ## Approach Add a `gate_verdicts` fact resolver in brief_facts.rb that returns `{ step => verdict }` from latest_step_summaries with no output field. Change coding.yaml:25 to `enrich: [ticket_brief, gate_verdicts]`. Update the reviewer charter Input line if it names gate output. Template: the red_tests trim in #670. Required work: - [ ] Red test: BriefFacts#fact("gate_verdicts") returns step-to-verdict only. - [ ] Resolver + FACT_RESOLVERS entry. - [ ] Map edit coding.yaml:25. ## Evidence Audit row from #676: map coding.yaml | node reviewer | fact gate_results | TRIM | reviewer.md:13 "Do not re-check it." ## Origin - Trigger: #676 enrich-fact audit, run in session 9434289b - Improvised this session: none - Chain: oversized or duplicated brief facts <- enrich lists chosen per node without a per-role byte audit <- DESIGN (map enrich model) - Root candidate: this ticket - Where: the map/charter/composer paths named in the draft - Parent: #676 - Session: 9434289b-c48f-4a8a-8add-0d82068e2c3f - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/9434289b-c48f-4a8a-8add-0d82068e2c3f.jsonl Skeptic verdict: CREATE (os-backlog:ticket-skeptic, session 9434289b, citations verified).

jared added the

plugin/os-sdlc

filed-by/agent

labels

2026-09-24 17:11:05 +00:00

jared commented

2026-09-24 20:10:00 +00:00

Author

Owner

Resolution

Done: reviewer enrich trimmed to gate verdicts

Evidence: shipped in commit 06b9c675 (#686): coding.yaml reviewer enrich is now [ticket_brief, gate_verdicts]

Follow-ups: none

## Resolution **Done:** reviewer enrich trimmed to gate verdicts **Evidence:** shipped in commit 06b9c675 (#686): coding.yaml reviewer enrich is now [ticket_brief, gate_verdicts] **Follow-ups:** none

jared closed this issue

2026-09-24 20:10:00 +00:00

jared referenced this issue

2026-09-24 20:10:19 +00:00

TEST ISSUE for debug #685