Remove the OS_SDLC_TARGET env fallback from os-sdlc #577

New issue

Open

opened 2026-09-14 16:58:22 +00:00 by jared · 0 comments

jared commented

2026-09-14 16:58:22 +00:00

Owner

Context

The user wants no env-var requirements in os-sdlc. The target is always passed as --target NAME on the command line. ADR-0182 deleted the write guard and with it the env read that #571 added. The ADR-0088 env fallback still exists in the CLI layer, and the error text names the env var. That text is how agents keep re-adding the env read.

Observed

Remaining occurrences after ADR-0182:

plugins/os-sdlc/lib/os_sdlc/target_flag.rb:7
plugins/os-sdlc/lib/os_sdlc/lint_worklist_target.rb:17
plugins/os-sdlc/lib/os_sdlc/lint_worklist_report.rb:56,59
plugins/os-sdlc/lib/os_sdlc/project_targets.rb:69,80   (error text names the env var)
plugins/os-sdlc/lib/os_sdlc/cli.rb:32                  (comment)
plugins/os-sdlc/skills/fix-lints/SKILL.md:13
plugins/os-sdlc/skills/setup-project/SKILL.md:44
plugins/os-sdlc/tests/test_helper.rb:160-164
plugins/os-sdlc/tests/runner/gate_commands_test.rb:46,151-155

grep -rn OS_SDLC_TARGET plugins/os-sdlc --include='*.rb' --include='*.md'

Reproduce

n/a: design cleanup, no failing behavior.

Expected

Every read of OS_SDLC_TARGET is deleted. The TargetSelectionError text names only --target NAME. The two skills stop mentioning the env var. The tests that set or clear the env var are removed. An ADR supersedes the env-fallback clause of ADR-0088.

Tasks

Delete the env read in target_flag.rb, lint_worklist_target.rb, lint_worklist_report.rb
Rewrite the error text in project_targets.rb to name only --target NAME
Remove the cli.rb comment and the two SKILL.md mentions
Remove the env setup and teardown in test_helper.rb and gate_commands_test.rb
Record an ADR that supersedes the ADR-0088 env-fallback clause

Origin

Trigger: grep for OS_SDLC_TARGET after the #575 guard deletion, 2026-09-14
Improvised this session: none
Chain: agents re-add the env read ← error text and four fallback sites name it ← env fallback decided in ADR-0088 (DESIGN)
Root candidate: this ticket
Where: plugins/os-sdlc/lib/os_sdlc/project_targets.rb, target_flag.rb
Session: e67968b8-85aa-4299-a323-a8c2212f7140
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/e67968b8-85aa-4299-a323-a8c2212f7140.jsonl

## Context The user wants no env-var requirements in os-sdlc. The target is always passed as `--target NAME` on the command line. ADR-0182 deleted the write guard and with it the env read that #571 added. The ADR-0088 env fallback still exists in the CLI layer, and the error text names the env var. That text is how agents keep re-adding the env read. ## Observed Remaining occurrences after ADR-0182: ``` plugins/os-sdlc/lib/os_sdlc/target_flag.rb:7 plugins/os-sdlc/lib/os_sdlc/lint_worklist_target.rb:17 plugins/os-sdlc/lib/os_sdlc/lint_worklist_report.rb:56,59 plugins/os-sdlc/lib/os_sdlc/project_targets.rb:69,80 (error text names the env var) plugins/os-sdlc/lib/os_sdlc/cli.rb:32 (comment) plugins/os-sdlc/skills/fix-lints/SKILL.md:13 plugins/os-sdlc/skills/setup-project/SKILL.md:44 plugins/os-sdlc/tests/test_helper.rb:160-164 plugins/os-sdlc/tests/runner/gate_commands_test.rb:46,151-155 ``` ``` grep -rn OS_SDLC_TARGET plugins/os-sdlc --include='*.rb' --include='*.md' ``` ## Reproduce n/a: design cleanup, no failing behavior. ## Expected Every read of `OS_SDLC_TARGET` is deleted. The `TargetSelectionError` text names only `--target NAME`. The two skills stop mentioning the env var. The tests that set or clear the env var are removed. An ADR supersedes the env-fallback clause of ADR-0088. ## Tasks - [ ] Delete the env read in target_flag.rb, lint_worklist_target.rb, lint_worklist_report.rb - [ ] Rewrite the error text in project_targets.rb to name only `--target NAME` - [ ] Remove the cli.rb comment and the two SKILL.md mentions - [ ] Remove the env setup and teardown in test_helper.rb and gate_commands_test.rb - [ ] Record an ADR that supersedes the ADR-0088 env-fallback clause ## Origin - Trigger: grep for `OS_SDLC_TARGET` after the #575 guard deletion, 2026-09-14 - Improvised this session: none - Chain: agents re-add the env read ← error text and four fallback sites name it ← env fallback decided in ADR-0088 (DESIGN) - Root candidate: this ticket - Where: plugins/os-sdlc/lib/os_sdlc/project_targets.rb, target_flag.rb - Session: e67968b8-85aa-4299-a323-a8c2212f7140 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/e67968b8-85aa-4299-a323-a8c2212f7140.jsonl

jared added the

plugin/os-sdlc

filed-by/user

labels

2026-09-14 16:58:22 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

jared/cc-os#577

No description provided.

Rows
Columns