Align green_assert_failure_sidecar.rb test-path matching to the segment-anchored convention #469

New issue

Closed

opened 2026-08-21 18:21:55 +00:00 by jared · 2 comments

jared commented

2026-08-21 18:21:55 +00:00

Owner

Context

While extending WriteGuard for #466, plain String#include? test-path matching was shown to false-match paths like Dir.mktmpdir("os-sdlc-test") temp prefixes. WriteGuard now uses a segment-anchored regex ((^|/)<test_path>(/|$)) in plugins/os-sdlc/lib/os_sdlc/write_guard.rb; plugins/os-sdlc/lib/os_sdlc/green_assert_failure_sidecar.rb still uses plain include?, so the same misclassification is live there.

Skeptic verdict: CREATE — real observed bug-class confirmed live in a sibling file, this ticket is the root.

Origin

Trigger: TDD red phase of #466 — write_guard_scope_test.rb table rows misclassified a tmpdir-prefixed production path as test-path under include? matching.
Improvised this session: none (WriteGuard fixed properly; sidecar untouched).
Chain: sidecar may misclassify paths ← String#include? substring matching ← DESIGN (green_assert_failure_sidecar.rb matching approach, no ADR).
Root candidate: this ticket.

## Context While extending WriteGuard for #466, plain String#include? test-path matching was shown to false-match paths like Dir.mktmpdir("os-sdlc-test") temp prefixes. WriteGuard now uses a segment-anchored regex ((^|/)<test_path>(/|$)) in plugins/os-sdlc/lib/os_sdlc/write_guard.rb; plugins/os-sdlc/lib/os_sdlc/green_assert_failure_sidecar.rb still uses plain include?, so the same misclassification is live there. Skeptic verdict: CREATE — real observed bug-class confirmed live in a sibling file, this ticket is the root. ## Origin - Trigger: TDD red phase of #466 — write_guard_scope_test.rb table rows misclassified a tmpdir-prefixed production path as test-path under include? matching. - Improvised this session: none (WriteGuard fixed properly; sidecar untouched). - Chain: sidecar may misclassify paths ← String#include? substring matching ← DESIGN (green_assert_failure_sidecar.rb matching approach, no ADR). - Root candidate: this ticket.

jared added the

plugin/os-sdlc

label

2026-08-21 18:21:55 +00:00

jared referenced this issue

2026-08-21 18:22:04 +00:00

POODR map T8: Write-guard scopes (test-only / production-only / read-only) + table-driven tests #466

jared referenced this issue

2026-08-21 19:18:46 +00:00

POODR implementation map — build wayfinder #458

jared referenced this issue

2026-08-21 20:15:16 +00:00

POODR implementation map — build wayfinder #458

jared commented

2026-08-21 20:15:27 +00:00

Author

Owner

Work starting via os-sdlc pipeline on branch worktree-worktree-469.

jared referenced this issue

2026-08-21 20:24:58 +00:00

Add regression test for GreenAssertFailureSidecar segment-anchored test-path matching #475

jared commented

2026-08-21 20:25:06 +00:00

Author

Owner

Resolution

Done: Aligned GreenAssertFailureSidecar#under_test_path? to WriteGuard's segment-anchored test-path regex, replacing String#include? substring matching; also removed an unreachable failing_path nil guard flagged in review.

Evidence: os-sdlc map drive reached merge-ready (implementation 2, session 918582d6): programmer + reviewer correction loop, reviewer round-2 verdict pass; full suite green (1007 runs, 2556 assertions, 0 failures), rubocop clean; change on branch worktree-worktree-469, file plugins/os-sdlc/lib/os_sdlc/green_assert_failure_sidecar.rb:50 matches write_guard.rb:125 convention.

Follow-ups: #475 captured (skeptic verdict CREATE): add regression test pinning the segment-anchored boundary; no other follow-ups.

## Resolution **Done:** Aligned GreenAssertFailureSidecar#under_test_path? to WriteGuard's segment-anchored test-path regex, replacing String#include? substring matching; also removed an unreachable failing_path nil guard flagged in review. **Evidence:** os-sdlc map drive reached merge-ready (implementation 2, session 918582d6): programmer + reviewer correction loop, reviewer round-2 verdict pass; full suite green (1007 runs, 2556 assertions, 0 failures), rubocop clean; change on branch worktree-worktree-469, file plugins/os-sdlc/lib/os_sdlc/green_assert_failure_sidecar.rb:50 matches write_guard.rb:125 convention. **Follow-ups:** #475 captured (skeptic verdict CREATE): add regression test pinning the segment-anchored boundary; no other follow-ups.

jared closed this issue

2026-08-21 20:25:06 +00:00

jared referenced this issue from a commit

2026-08-22 13:45:09 +00:00

fix(os-sdlc): #469 segment-anchored test-path match in GreenAssertFailureSidecar (#475)

jared referenced this issue

2026-08-27 02:41:56 +00:00

Add regression test for GreenAssertFailureSidecar segment-anchored test-path matching #475