jared/cc-os

Watch

Fork 0

os-sdlc: decompose OsSdlc::CLI to clear inherited structural lint debt #424

New issue

Closed

opened 2026-08-17 18:08:17 +00:00 by jared · 2 comments

jared commented

2026-08-17 18:08:17 +00:00

Owner

Acceptance: rubocop --config plugins/os-sdlc/.rubocop.yml plugins/os-sdlc/lib/os_sdlc/cli.rb clean with no new cop exclusions; suite stays green (ruby plugins/os-sdlc/tests/all.rb).

Origin: AI follow-up from #423 (symptom exposed by the move; root is the ADR-0025-era monolithic bin design). Ticket-skeptic verdict: CREATE (2026-08-17).

#423 moved bin/os-sdlc's dispatch into lib/os_sdlc/cli.rb verbatim (Thor conversion, ADR-0123). The extension-less bin was never rubocop-inspected; in lib/ it shows Metrics/ClassLength [827/100] plus 15 Sdlc/Structural/ParameterThreadedThroughPrivateMethods offenses. Clearing them is a real decomposition (gate-runner, verdict, intake, lint, preflight, report-rendering collaborators holding state), disclosed and deferred out of #423's mechanical-conversion scope (commit c7f875f). Acceptance: rubocop --config plugins/os-sdlc/.rubocop.yml plugins/os-sdlc/lib/os_sdlc/cli.rb clean with no new cop exclusions; suite stays green (ruby plugins/os-sdlc/tests/all.rb). Origin: AI follow-up from #423 (symptom exposed by the move; root is the ADR-0025-era monolithic bin design). Ticket-skeptic verdict: CREATE (2026-08-17).

jared added the

plugin/os-sdlc

label

2026-08-17 18:08:17 +00:00

jared referenced this issue

2026-08-17 18:09:09 +00:00

Migrate remaining case/when bins to Thor (follow-on to #422) #423

jared commented

2026-08-17 18:16:57 +00:00

Author

Owner

Starting work on branch worktree-ticket-424-cli-decomposition via os-sdlc implement pipeline.

jared commented

2026-08-17 19:36:25 +00:00

Author

Owner

Resolution

Done: Decomposed plugins/os-sdlc/lib/os_sdlc/cli.rb (1138 -> 119 lines) into ~20 collaborator command objects holding threaded params as instance state. rubocop --config plugins/os-sdlc/.rubocop.yml clean on cli.rb and every touched file, zero new cop exclusions. Reviewer APPROVE after 4 rounds.

Evidence: Merge commit 6e4de96 on main (branch worktree-ticket-424-cli-decomposition, commit f058a5a). Suite: ruby plugins/os-sdlc/tests/all.rb -> 974 runs, 2405 assertions, 0 failures. Verdict: .sdlc reviewer APPROVE round 4.

Follow-ups: 1) #416 still forces lint-gate skips: gate lints whole target and escalated 3x on pre-existing offenses. 2) Runner AutocorrectStep re-applies safe autocorrect to untouched files (cops/module_owns_instance_state.rb) after every round - consider scoping the prepass to files changed by the round. 3) Pre-existing lint debt remains outside #424 scope: rubocop_delta_report.rb Layout/LineLength and ~20 offenses in older test files.

## Resolution **Done:** Decomposed plugins/os-sdlc/lib/os_sdlc/cli.rb (1138 -> 119 lines) into ~20 collaborator command objects holding threaded params as instance state. rubocop --config plugins/os-sdlc/.rubocop.yml clean on cli.rb and every touched file, zero new cop exclusions. Reviewer APPROVE after 4 rounds. **Evidence:** Merge commit 6e4de96 on main (branch worktree-ticket-424-cli-decomposition, commit f058a5a). Suite: ruby plugins/os-sdlc/tests/all.rb -> 974 runs, 2405 assertions, 0 failures. Verdict: .sdlc reviewer APPROVE round 4. **Follow-ups:** 1) #416 still forces lint-gate skips: gate lints whole target and escalated 3x on pre-existing offenses. 2) Runner AutocorrectStep re-applies safe autocorrect to untouched files (cops/module_owns_instance_state.rb) after every round - consider scoping the prepass to files changed by the round. 3) Pre-existing lint debt remains outside #424 scope: rubocop_delta_report.rb Layout/LineLength and ~20 offenses in older test files.

jared closed this issue

2026-08-17 19:36:25 +00:00

jared referenced this issue from a commit

2026-08-18 13:07:24 +00:00

refactor(os-sdlc): decompose OsSdlc::CLI into collaborator command objects (#424)

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

jared/cc-os#424

No description provided.

Rows
Columns