os-sdlc hook: normalize namespaced subagent_type at hook ingestion

jared commented

2026-08-16 11:53:59 +00:00

Owner

Context

Child of #400. The PostToolUse hook reads subagent_type unmodified (plugins/os-sdlc/hooks/post_tool_use.rb:24-26) and compares it against bare agent names from maps/default.yaml at two downstream sites: TransitionTable#known_agent? (lib/os_sdlc/runner/transition_table.rb:62-64) and TicketFlow#matching_pending_dispatch (lib/os_sdlc/runner/ticket_flow.rb:10-17). Namespaced dispatch names like os-sdlc:programmer therefore never match, so the hook no-ops and stages must be advanced by manually piping bare-name events. Evidence brief: .sdlc/tickets/400/evidence-brief.md.

Tasks

Normalize the agent name once at the hook ingestion boundary (post_tool_use.rb), stripping a plugin namespace prefix, so downstream matching stays on bare names.
Tests in tests/runner/post_tool_use_hook_test.rb and tests/runner/post_tool_use_non_pipeline_async_dispatch_test.rb cover namespaced and bare dispatch names, including the ADR-0121 non-pipeline async no-op path.

Acceptance criteria

A dispatch with subagent_type os-sdlc:<stage> advances the pipeline identically to bare <stage>.
Non-pipeline namespaced agents (e.g. other plugins' agents) still no-op silently.
Suite green; changed files rubocop-clean.

Out of scope: GateEvaluator target_name env threading (#410); shakedown (#400).

## Context Child of #400. The PostToolUse hook reads `subagent_type` unmodified (plugins/os-sdlc/hooks/post_tool_use.rb:24-26) and compares it against bare agent names from maps/default.yaml at two downstream sites: TransitionTable#known_agent? (lib/os_sdlc/runner/transition_table.rb:62-64) and TicketFlow#matching_pending_dispatch (lib/os_sdlc/runner/ticket_flow.rb:10-17). Namespaced dispatch names like `os-sdlc:programmer` therefore never match, so the hook no-ops and stages must be advanced by manually piping bare-name events. Evidence brief: .sdlc/tickets/400/evidence-brief.md. ## Tasks - [ ] Normalize the agent name once at the hook ingestion boundary (post_tool_use.rb), stripping a plugin namespace prefix, so downstream matching stays on bare names. - [ ] Tests in tests/runner/post_tool_use_hook_test.rb and tests/runner/post_tool_use_non_pipeline_async_dispatch_test.rb cover namespaced and bare dispatch names, including the ADR-0121 non-pipeline async no-op path. ## Acceptance criteria - [ ] A dispatch with subagent_type `os-sdlc:<stage>` advances the pipeline identically to bare `<stage>`. - [ ] Non-pipeline namespaced agents (e.g. other plugins' agents) still no-op silently. - [ ] Suite green; changed files rubocop-clean. Out of scope: GateEvaluator target_name env threading (#410); shakedown (#400).

jared added the

ready-for-agent

plugin/os-sdlc

labels

2026-08-16 11:53:59 +00:00

jared referenced this issue

2026-08-16 11:54:10 +00:00

os-sdlc hook 2/3: arm hook + shakedown #400

jared commented

2026-08-16 11:57:20 +00:00

Author

Owner

Work starting on branch worktree-issue-412 (os-sdlc implement pipeline).

jared referenced this issue

2026-08-16 12:02:05 +00:00

Thread target into TeaTracker#resolve_slug (multi-target intake broken) [capture] #413

jared referenced this issue

2026-08-16 12:02:11 +00:00

Switch BodyFetch off tea --output yaml (broken on tea 0.13.0) [capture] #414

jared referenced this issue

2026-08-16 12:02:13 +00:00

Resolve .cc-os/config from owning repo root inside worktrees (os-sdlc) [capture] #415

jared referenced this issue

2026-08-16 12:37:07 +00:00

os-sdlc lint gate: lint changed files, not the whole target [capture] #416

jared referenced this issue

2026-08-16 12:37:15 +00:00

Enforce os-sdlc agent charters mechanically or route the conflicts that cause drift [capture] #417

jared commented

2026-08-16 12:37:25 +00:00

Author

Owner

Resolution

Done: Hook now normalizes subagent_type at the ingestion boundary: normalize_agent strips the literal os-sdlc: prefix in plugins/os-sdlc/hooks/post_tool_use.rb, so namespaced pipeline dispatches advance identically to bare names while foreign-plugin namespaced agents still no-op silently (incl. the ADR-0121 async guard path). Test fixtures corrected to shipped bare-name maps; discriminating AC2 tests added.

Evidence: os-sdlc pipeline run to done on branch worktree-issue-412 (report .sdlc/tickets/412/briefs/013-review-to-done.md); reviewer APPROVE with mutation-check (strip-any fails, shipped fix passes); suite 950 runs 0 failures; changed files rubocop-clean; lint skip covered only 22 pre-existing offenses in untouched files, user-approved.

Follow-ups: Captured with skeptic verdicts: #413 (resolve_slug drops target, multi-target intake broken), #414 (tea 0.13.0 broke --output yaml BodyFetch), #415 (worktrees miss .cc-os/config), #416 (lint gate scopes whole target, not changed files), #417 (agent charter drift enforcement). No others.

## Resolution **Done:** Hook now normalizes subagent_type at the ingestion boundary: normalize_agent strips the literal os-sdlc: prefix in plugins/os-sdlc/hooks/post_tool_use.rb, so namespaced pipeline dispatches advance identically to bare names while foreign-plugin namespaced agents still no-op silently (incl. the ADR-0121 async guard path). Test fixtures corrected to shipped bare-name maps; discriminating AC2 tests added. **Evidence:** os-sdlc pipeline run to done on branch worktree-issue-412 (report .sdlc/tickets/412/briefs/013-review-to-done.md); reviewer APPROVE with mutation-check (strip-any fails, shipped fix passes); suite 950 runs 0 failures; changed files rubocop-clean; lint skip covered only 22 pre-existing offenses in untouched files, user-approved. **Follow-ups:** Captured with skeptic verdicts: #413 (resolve_slug drops target, multi-target intake broken), #414 (tea 0.13.0 broke --output yaml BodyFetch), #415 (worktrees miss .cc-os/config), #416 (lint gate scopes whole target, not changed files), #417 (agent charter drift enforcement). No others.

jared closed this issue

2026-08-16 12:37:26 +00:00

jared referenced this issue from a commit

2026-08-16 12:43:17 +00:00

fix(os-sdlc): normalize namespaced subagent_type at hook ingestion (#412)

Rows
Columns

os-sdlc hook: normalize namespaced subagent_type at hook ingestion #412

Context

Tasks

Acceptance criteria

Resolution