jared/cc-os

Watch

Fork 0

Audit Sdlc/Dry/DuplicatedStatementSequence against source test files #376

New issue

Closed

opened 2026-08-14 20:02:23 +00:00 by jared · 2 comments

jared commented

2026-08-14 20:02:23 +00:00

Owner

Parent

#369

What to build

A verdict on the 152 test-file offenses from Sdlc/Dry/DuplicatedStatementSequence, a cop mined from the very test files it now flags: sampled findings classified as real test-quality defects versus cop miscalibration, with a recommended threshold/config change if miscalibrated, posted as a comment on #369.

Acceptance criteria

Representative sample of the 152 offenses reviewed and classified (defect vs. miscalibration)
Verdict comment posted on #369 with the classification breakdown
If miscalibrated: a concrete recommended threshold/config change is stated (not implemented)

Blocked by

None — can start immediately.

## Parent #369 ## What to build A verdict on the 152 test-file offenses from Sdlc/Dry/DuplicatedStatementSequence, a cop mined from the very test files it now flags: sampled findings classified as real test-quality defects versus cop miscalibration, with a recommended threshold/config change if miscalibrated, posted as a comment on #369. ## Acceptance criteria - [ ] Representative sample of the 152 offenses reviewed and classified (defect vs. miscalibration) - [ ] Verdict comment posted on #369 with the classification breakdown - [ ] If miscalibrated: a concrete recommended threshold/config change is stated (not implemented) ## Blocked by - None — can start immediately.

jared added the

ready-for-agent

plugin/os-sdlc

labels

2026-08-14 20:02:23 +00:00

jared referenced this issue

2026-08-14 20:02:32 +00:00

Calibration decision for mined Sdlc cops (gates #370) #378

jared commented

2026-08-14 20:08:13 +00:00

Author

Owner

Started: auditing DuplicatedStatementSequence findings.

jared commented

2026-08-14 20:10:59 +00:00

Author

Owner

Resolution

Done: Audited Sdlc/Dry/DuplicatedStatementSequence: 164 current offenses, ~30 sampled; ~80% miscalibration (idiomatic minitest AAA pairs), ~15% real helper-worthy duplication, ~5% borderline

Evidence: Verdict comment posted on #369; cop's WINDOW_SIZE=2 over-generalizes — recommended raising to 3-4 and/or excluding assert_/refute_ statement windows

Follow-ups: Consolidated decision (incl. cop retune and the one real non-test hit in plugins/os-vault/eval/bin/check) is #378's scope; no separate tickets

## Resolution **Done:** Audited Sdlc/Dry/DuplicatedStatementSequence: 164 current offenses, ~30 sampled; ~80% miscalibration (idiomatic minitest AAA pairs), ~15% real helper-worthy duplication, ~5% borderline **Evidence:** Verdict comment posted on #369; cop's WINDOW_SIZE=2 over-generalizes — recommended raising to 3-4 and/or excluding assert_/refute_ statement windows **Follow-ups:** Consolidated decision (incl. cop retune and the one real non-test hit in plugins/os-vault/eval/bin/check) is #378's scope; no separate tickets

jared closed this issue

2026-08-14 20:11:00 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

jared/cc-os#376

No description provided.

Rows
Columns