os-sdlc: reviewer output not persisted; verdict.md contract mismatch #363

New issue

Closed

opened 2026-08-14 15:20:28 +00:00 by jared · 3 comments

jared commented

2026-08-14 15:20:28 +00:00

Owner

The reviewer agent never writes .sdlc/tickets//verdict.md, so the verdict gate reads 'missing' and review feedback is lost to the routed brief. Also two verdict grammars coexist: Runner::Verdict wants bare APPROVE first line; artifact-era ReviewerVerdict wants APPROVE. Found during ticket #351 (reviewer findings had to be relayed by hand; APPROVE parsed as invalid).

The reviewer agent never writes .sdlc/tickets/<id>/verdict.md, so the verdict gate reads 'missing' and review feedback is lost to the routed brief. Also two verdict grammars coexist: Runner::Verdict wants bare APPROVE first line; artifact-era ReviewerVerdict wants **APPROVE**. Found during ticket #351 (reviewer findings had to be relayed by hand; **APPROVE** parsed as invalid).

jared added the

plugin/os-sdlc

label

2026-08-14 15:20:28 +00:00

jared referenced this issue

2026-08-14 15:21:53 +00:00

os-sdlc: seam-decision artifact contract + gate check #351

jared commented

2026-08-14 15:57:57 +00:00

Author

Owner

Decision: reviewer writes .sdlc/tickets//verdict.md directly, first line bare APPROVE/REQUEST-CHANGES; artifact record_reviewer_verdict path retired as reviewer output. reviewer.md prompt updated; #361 pipeline run will exercise it. Map route review->test-writer split to a separate ticket.

Decision: reviewer writes .sdlc/tickets/<id>/verdict.md directly, first line bare APPROVE/REQUEST-CHANGES; artifact record_reviewer_verdict path retired as reviewer output. reviewer.md prompt updated; #361 pipeline run will exercise it. Map route review->test-writer split to a separate ticket.

jared added the

frozen

label

2026-08-16 14:24:56 +00:00

jared commented

2026-08-16 14:25:54 +00:00

Author

Owner

Frozen in the 2026-08-16 backlog reset — see #419 for the expiry procedure. Do not work unless a live run rediscovers this issue.

jared added the

category/investigation

label

2026-10-10 13:32:14 +00:00

jared commented

2026-10-12 13:40:22 +00:00

Author

Owner

Resolution

Done: Sweep 2026-10-10 (ruled 2026-10-12): problem absent or no longer applies. Current reviewer card: verdict is pass/fail/error in the stop message; 'The stop message is the only handoff; the router reads it, not a file.' Contradicts the ticket's verdict.md claim.

Evidence: docs/takedown/363-20261010-111318 : Current reviewer card: verdict is pass/fail/error in the stop message; 'The stop message is the only handoff; the router reads it, not a file.' Contradicts the ticket's verdict.md claim.

Follow-ups: none

## Resolution **Done:** Sweep 2026-10-10 (ruled 2026-10-12): problem absent or no longer applies. Current reviewer card: verdict is pass/fail/error in the stop message; 'The stop message is the only handoff; the router reads it, not a file.' Contradicts the ticket's verdict.md claim. **Evidence:** docs/takedown/363-20261010-111318 : Current reviewer card: verdict is pass/fail/error in the stop message; 'The stop message is the only handoff; the router reads it, not a file.' Contradicts the ticket's verdict.md claim. **Follow-ups:** none

jared closed this issue

2026-10-12 13:40:22 +00:00