Wire test-lint-fixer routing into fix-lints (ADR-0107) #338

New issue

Open

opened 2026-08-10 21:41:26 +00:00 by jared · 1 comment

jared commented

2026-08-10 21:41:26 +00:00

Owner

Context

Running /os-sdlc:fix-lints --target os-backlog, the batch phase deadlocked on plugins/os-backlog/tests/checkout_test.rb: os-sdlc:lint-fixer correctly refuses to edit test files (its charter bans it, by design — the guard against assertion-weakening). ADR-0107 already decided this: a dedicated os-sdlc:test-lint-fixer agent, chartered to restructure test files freely without touching assertions, routed to by path (test_path → test-lint-fixer, else lint-fixer) at every batch/iterative dispatch point. But test-lint-fixer doesn't exist in the current os-sdlc plugin build, and fix-lints' skill files (SKILL.md, references/batch-phase.md, references/iterative-phase.md) never mention test_path routing at all — ADR-0107 describes it wired into os-sdlc:implement's gates, not into the standalone fix-lints skill.

Fix: either build test-lint-fixer per ADR-0107 and wire path-based routing into fix-lints' batch/iterative dispatch steps, or extend fix-lints' docs to explicitly route test-file offenses elsewhere (e.g. back to the user) instead of silently deadlocking.

## Context Running /os-sdlc:fix-lints --target os-backlog, the batch phase deadlocked on plugins/os-backlog/tests/checkout_test.rb: os-sdlc:lint-fixer correctly refuses to edit test files (its charter bans it, by design — the guard against assertion-weakening). ADR-0107 already decided this: a dedicated os-sdlc:test-lint-fixer agent, chartered to restructure test files freely without touching assertions, routed to by path (test_path → test-lint-fixer, else lint-fixer) at every batch/iterative dispatch point. But test-lint-fixer doesn't exist in the current os-sdlc plugin build, and fix-lints' skill files (SKILL.md, references/batch-phase.md, references/iterative-phase.md) never mention test_path routing at all — ADR-0107 describes it wired into os-sdlc:implement's gates, not into the standalone fix-lints skill. Fix: either build test-lint-fixer per ADR-0107 and wire path-based routing into fix-lints' batch/iterative dispatch steps, or extend fix-lints' docs to explicitly route test-file offenses elsewhere (e.g. back to the user) instead of silently deadlocking.

jared added the

plugin/os-sdlc

worklist/new-implement-build

labels

2026-08-13 18:10:10 +00:00

jared added the

frozen

label

2026-08-16 14:24:59 +00:00

jared commented

2026-08-16 14:25:57 +00:00

Author