os-sdlc: extract_target! only strips first --target occurrence

jared commented

2026-08-02 12:12:47 +00:00

Owner

extract_target! in plugins/os-sdlc/bin/os-sdlc only strips the first --target occurrence from ARGV; a duplicated flag leaks the second copy into subcommand parsing. Minor quirk found during the #229 --target plumbing review, confirmed by Codex second-opinion review. Low priority.

jared added the

P3

label

2026-08-02 12:12:47 +00:00

jared commented

2026-08-02 14:09:23 +00:00

Author

Owner

This was generated by AI during triage.

Agent Brief

Category: bug
Summary: extract_target! should strip every --target occurrence from ARGV, not just the first

Current behavior:
The os-sdlc CLI's extract_target! removes only the first --target <value> (or --target=<value>) pair from the argument list. If the flag is passed twice, the second copy leaks through into subcommand argument parsing, where it is unrecognized.

Desired behavior:
All --target occurrences are stripped before dispatch. Which value wins (first or last) should match whatever the current single-occurrence semantics imply — pick one, assert it in a test, and keep it consistent with how the resolved target is threaded to subcommands (per the --target plumbing shipped for #229's pipeline blocker).

Key interfaces:

extract_target! in the os-sdlc CLI entrypoint — its contract becomes "ARGV contains no --target tokens after this call"

Acceptance criteria:

A CLI regression test passing --target X --target Y shows no --target leaking into subcommand args
The test asserts which value wins, and both --target v and --target=v spellings are covered
Existing --target threading regression tests stay green

Out of scope:

Rejecting duplicate flags with an error (silently resolving is fine at P3)
Any other flag's parsing

> *This was generated by AI during triage.* ## Agent Brief **Category:** bug **Summary:** `extract_target!` should strip every `--target` occurrence from ARGV, not just the first **Current behavior:** The `os-sdlc` CLI's `extract_target!` removes only the first `--target <value>` (or `--target=<value>`) pair from the argument list. If the flag is passed twice, the second copy leaks through into subcommand argument parsing, where it is unrecognized. **Desired behavior:** All `--target` occurrences are stripped before dispatch. Which value wins (first or last) should match whatever the current single-occurrence semantics imply — pick one, assert it in a test, and keep it consistent with how the resolved target is threaded to subcommands (per the `--target` plumbing shipped for #229's pipeline blocker). **Key interfaces:** - `extract_target!` in the `os-sdlc` CLI entrypoint — its contract becomes "ARGV contains no `--target` tokens after this call" **Acceptance criteria:** - [ ] A CLI regression test passing `--target X --target Y` shows no `--target` leaking into subcommand args - [ ] The test asserts which value wins, and both `--target v` and `--target=v` spellings are covered - [ ] Existing `--target` threading regression tests stay green **Out of scope:** - Rejecting duplicate flags with an error (silently resolving is fine at P3) - Any other flag's parsing

jared added the

bug

ready-for-agent

labels

2026-08-02 14:09:33 +00:00

jared commented

2026-08-02 14:50:02 +00:00

Author

Owner

Starting work in worktree fix-231-extract-target.

jared referenced this issue

2026-08-02 16:38:56 +00:00

os-sdlc: test suite writes a stray '(string)' file into the plugin root #237

jared commented

2026-08-02 16:38:57 +00:00

Author

Owner

Fix implemented in worktree fix-231-extract-target, commit 920487a: extract_target! now strips every --target occurrence (first value wins), 4 CLI regression tests cover both spellings + mixed + first-wins; existing threading tests green. A full /os-sdlc:fix-lints run followed (worklist + residual clear, suite 577 runs green). Awaiting merge sign-off.

Fix implemented in worktree fix-231-extract-target, commit 920487a: extract_target! now strips every --target occurrence (first value wins), 4 CLI regression tests cover both spellings + mixed + first-wins; existing threading tests green. A full /os-sdlc:fix-lints run followed (worklist + residual clear, suite 577 runs green). Awaiting merge sign-off.

jared added the

review

label

2026-08-02 16:38:57 +00:00

jared commented

2026-08-02 19:54:37 +00:00

Author

Owner

Merged to main in 762591f..dac4e13 (merge commit dac4e13). Verified: full suite green in worktree before merge (577 runs, 1527 assertions, 0 failures), main..branch empty after merge, plugin cache refreshed. Closing.

Merged to main in 762591f..dac4e13 (merge commit dac4e13). Verified: full suite green in worktree before merge (577 runs, 1527 assertions, 0 failures), main..branch empty after merge, plugin cache refreshed. Closing.

jared closed this issue

2026-08-02 19:54:37 +00:00

jared referenced this issue from a commit

2026-08-03 13:52:17 +00:00

Strip every --target occurrence in os-sdlc extract_target! (#231)

jared referenced this issue from a commit

2026-08-03 13:52:17 +00:00

Merge worktree-fix-231-extract-target: strip all --target occurrences (#231)

jared referenced this issue from a commit

2026-08-03 13:52:17 +00:00

Record #231 extract-target fix in os-sdlc status leaf