jared/cc-os
Watch
1
0
Fork
You've already forked cc-os
 0
Code Issues 378 Pull requests Projects Releases Packages Wiki Activity

Audit every Sdlc cop against the zero-false-positive standard #1325

New issue
Closed
opened 2026-10-25 16:44:44 +00:00 by jared · 3 comments
jared commented 2026-10-25 16:44:44 +00:00
Owner
Copy link

Problem

Jared's standard for a cop: "We want the solution to always be correct so we know the correction is warranted and we can reduce flags to zero. Otherwise we would always have unresolved violations. We need to know exactly what shape triggers that fix and that the fix is always correct for that shape, as well as exactly when the shape could trigger a false positive and why it is false so we can carve those out and avoid flagging them."
No one has checked the existing Sdlc/* cops against this standard. Example: the CollaboratorConstructionInInitialize lesson tells the agent to report composition-root false positives to the human. That is a known false positive that the cop does not carve out.

Reproduce

n/a: audit.

Approach

For every Sdlc/* cop, record four facts: the shape, the fix, whether the fix is always correct, and the known false positives with the reason each is false.
Carve-outs live in the cop matcher, by shape. No config Exclude lists. No test-path exclusions.
Output: one ticket per cop that fails the standard. Use /os-backlog:capture for each ticket.
The cop list: every RuboCop cop class defined under plugins/os-sdlc/lib/os_sdlc/cops/*.rb whose cop name starts with Sdlc/ (on 2026-10-25, about 45 cops in Sdlc/Structural, Sdlc/Dry, Sdlc/Minitest, Sdlc/Sequel). Do not count the base classes RecordingCop, ClassSiteCop, and CopSource. Recording cops (for example Sdlc/Structural/RescueSite) prescribe no fix; record that, and judge only their record.
The 2 cops that #1321 and #1322 add already have this record in their smell analyses (docs/plans/class-length-family/). Link those records; do not repeat them.
For each cop, read its source, its tests, and its lesson in plugins/os-sdlc/lint-lessons/ if one exists. A lesson that tells the agent to report a false positive to a human, or to file a false-positive ticket, names a known false positive.

Required work:

  1. Write the audit record file — check: present ## Records in docs/plans/class-length-family/sdlc-cop-audit.md
  2. File one ticket per failing cop with /os-backlog:capture, and put its number in the cop's record.

Acceptance criteria

  1. Given the list of Sdlc/* cops in plugins/os-sdlc, when the audit ends, then each cop has a record with shape, fix, fix-always-correct, and known false positives.
  2. Given a cop that fails the standard, when the audit ends, then one ticket exists for that cop.
  3. Given a cop that meets the standard, when the audit ends, then the record says so and no ticket exists.

Owner sketch

Investigation. No Ruby object changes. File written: docs/plans/class-length-family/sdlc-cop-audit.md, with a _Last updated:_ line and a ## Records table, one row per cop: cop name, source file, shape, fix, fix always correct (yes / no and why), known false positives with the reason each is false, verdict (meets / fails), ticket number.
Tools: read the cop sources; sample a cop's hits with rubocop --only <cop> --config plugins/os-sdlc/.rubocop.yml plugins (plugins/os-sdlc/bin/lint-sweep runs only the cops in .rubocop-sweep.yml); /os-backlog:capture for each ticket.

Origin

  • Trigger: Design of the ClassLength family in this session.
  • Improvised this session: none
  • Chain: Unknown false-positive rate ← no audit against the standard ← IMPROVISATION (lessons ask the agent to report false positives to the human)
  • Root candidate: none found; searched false positive, zero false, audit, cop, Sdlc/, carve, ClassLength, lint-lessons, #1091, #917, #1102, #1044, #1213
    VERDICT: CREATE
  • Where: plugins/os-sdlc/lib/os_sdlc/cops
  • Session: f4187368-5e7e-459d-80c6-ddf7620389cd
  • Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/f4187368-5e7e-459d-80c6-ddf7620389cd.jsonl
## Problem Jared's standard for a cop: "We want the solution to always be correct so we know the correction is warranted and we can reduce flags to zero. Otherwise we would always have unresolved violations. We need to know exactly what shape triggers that fix and that the fix is always correct for that shape, as well as exactly when the shape could trigger a false positive and why it is false so we can carve those out and avoid flagging them." No one has checked the existing Sdlc/* cops against this standard. Example: the CollaboratorConstructionInInitialize lesson tells the agent to report composition-root false positives to the human. That is a known false positive that the cop does not carve out. ## Reproduce n/a: audit. ## Approach For every Sdlc/* cop, record four facts: the shape, the fix, whether the fix is always correct, and the known false positives with the reason each is false. Carve-outs live in the cop matcher, by shape. No config Exclude lists. No test-path exclusions. Output: one ticket per cop that fails the standard. Use /os-backlog:capture for each ticket. The cop list: every RuboCop cop class defined under plugins/os-sdlc/lib/os_sdlc/cops/*.rb whose cop name starts with `Sdlc/` (on 2026-10-25, about 45 cops in Sdlc/Structural, Sdlc/Dry, Sdlc/Minitest, Sdlc/Sequel). Do not count the base classes RecordingCop, ClassSiteCop, and CopSource. Recording cops (for example Sdlc/Structural/RescueSite) prescribe no fix; record that, and judge only their record. The 2 cops that #1321 and #1322 add already have this record in their smell analyses (docs/plans/class-length-family/). Link those records; do not repeat them. For each cop, read its source, its tests, and its lesson in plugins/os-sdlc/lint-lessons/ if one exists. A lesson that tells the agent to report a false positive to a human, or to file a false-positive ticket, names a known false positive. Required work: 1. Write the audit record file — check: present `## Records` in `docs/plans/class-length-family/sdlc-cop-audit.md` 2. File one ticket per failing cop with /os-backlog:capture, and put its number in the cop's record. ## Acceptance criteria 1. Given the list of Sdlc/* cops in plugins/os-sdlc, when the audit ends, then each cop has a record with shape, fix, fix-always-correct, and known false positives. 2. Given a cop that fails the standard, when the audit ends, then one ticket exists for that cop. 3. Given a cop that meets the standard, when the audit ends, then the record says so and no ticket exists. ## Owner sketch Investigation. No Ruby object changes. File written: docs/plans/class-length-family/sdlc-cop-audit.md, with a `_Last updated:_` line and a `## Records` table, one row per cop: cop name, source file, shape, fix, fix always correct (yes / no and why), known false positives with the reason each is false, verdict (meets / fails), ticket number. Tools: read the cop sources; sample a cop's hits with `rubocop --only <cop> --config plugins/os-sdlc/.rubocop.yml plugins` (plugins/os-sdlc/bin/lint-sweep runs only the cops in .rubocop-sweep.yml); /os-backlog:capture for each ticket. ## Origin - Trigger: Design of the ClassLength family in this session. - Improvised this session: none - Chain: Unknown false-positive rate ← no audit against the standard ← IMPROVISATION (lessons ask the agent to report false positives to the human) - Root candidate: none found; searched false positive, zero false, audit, cop, Sdlc/, carve, ClassLength, lint-lessons, #1091, #917, #1102, #1044, #1213 VERDICT: CREATE - Where: plugins/os-sdlc/lib/os_sdlc/cops - Session: f4187368-5e7e-459d-80c6-ddf7620389cd - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/f4187368-5e7e-459d-80c6-ddf7620389cd.jsonl
jared commented 2026-10-25 20:37:06 +00:00
Author
Owner
Copy link

Input for this audit (found 2026-10-25 during #1321): Sdlc/Structural/UnusedPrivateMethod reads one file only, so it flags a private method on a parent class that subclasses call. New hit: Backlog::CLI::Commands#tracker_command (plugins/os-backlog/lib/backlog/cli/commands.rb, called from IssueCommands and ProjectCommands). Same mechanism already on main in that file: issue_service, cli_options, require_issue_number!. Counts as a false positive under the zero-false-positive standard.

Input for this audit (found 2026-10-25 during #1321): Sdlc/Structural/UnusedPrivateMethod reads one file only, so it flags a private method on a parent class that subclasses call. New hit: Backlog::CLI::Commands#tracker_command (plugins/os-backlog/lib/backlog/cli/commands.rb, called from IssueCommands and ProjectCommands). Same mechanism already on main in that file: issue_service, cli_options, require_issue_number!. Counts as a false positive under the zero-false-positive standard.
jared commented 2026-10-25 21:08:06 +00:00
Author
Owner
Copy link

Work started on branch ticket-1325 (AFK run approved 2026-10-25).

Work started on branch ticket-1325 (AFK run approved 2026-10-25).
jared commented 2026-10-25 21:26:25 +00:00
Author
Owner
Copy link

Resolution

Done: Audited all 46 Sdlc cops against the zero-false-positive standard in docs/plans/class-length-family/sdlc-cop-audit.md (shape, fix, fix-always-correct, false positives, verdict, ticket). 2 meet, 44 fail; each failing cop has a ticket or an occurrence.

Evidence: Commit 7d251603 on ticket-1325. New tickets #1345-#1385 (41, filed-by/agent, each skeptic VERDICT: CREATE). Occurrences on #1008 (RawFileContentAssertion), #1091 (UnusedPrivateMethod), #1102 (BooleanControlParameter). 44 of 44 failing rows carry a ticket cell.

Follow-ups: Captured as the 41 per-cop tickets #1345-#1385. #1367 (RequireInMethod autocorrect deletes one-line methods) is P1. Dropped: cross-link #226 from #1354 and #917 from #1362; each new ticket's Origin block already names the related ticket. Note: the new tickets lack the Acceptance criteria and Owner sketch sections that implementation-open needs, so each needs /os-backlog:ticket-decompose before it is worked.

## Resolution **Done:** Audited all 46 Sdlc cops against the zero-false-positive standard in docs/plans/class-length-family/sdlc-cop-audit.md (shape, fix, fix-always-correct, false positives, verdict, ticket). 2 meet, 44 fail; each failing cop has a ticket or an occurrence. **Evidence:** Commit 7d251603 on ticket-1325. New tickets #1345-#1385 (41, filed-by/agent, each skeptic VERDICT: CREATE). Occurrences on #1008 (RawFileContentAssertion), #1091 (UnusedPrivateMethod), #1102 (BooleanControlParameter). 44 of 44 failing rows carry a ticket cell. **Follow-ups:** Captured as the 41 per-cop tickets #1345-#1385. #1367 (RequireInMethod autocorrect deletes one-line methods) is P1. Dropped: cross-link #226 from #1354 and #917 from #1362; each new ticket's Origin block already names the related ticket. Note: the new tickets lack the Acceptance criteria and Owner sketch sections that implementation-open needs, so each needs /os-backlog:ticket-decompose before it is worked.
jared closed this issue 2026-10-25 21:26:25 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
ticket-1337
No results found.
Labels
Clear labels   
P0
Priority 0 — drop everything

  
P1
Priority 1 — next up

  
P2
Priority 2 — normal

  
P3
Priority 3 — someday

  
bug
Something is broken

  
category/code-change
Ticket category

  
category/cross-repo
Ticket category

  
category/eval-run
Ticket category

  
category/investigation
Ticket category

  
category/no-test-target
Ticket category

  
category/owner-ruling
Ticket category

  
category/prose-artifact
Ticket category

  
category/recurring-chore
Ticket category

  
category/structure

   
category/umbrella
Ticket category

  
crc-refactor
CRC refactor run work record; exempt from the ticket-skeptic

  
create
Ticket creates something new

  
delete
Ticket removes something

  
enhancement
New feature or improvement

  
filed-by/agent

   
filed-by/user

   
frozen
Pre-reset backlog freeze 2026-08-16; do not work unless rediscovered by a live run

  
lint-rule
Ticket proposes/modifies a lint rule or cop

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
next
Human-curated next up — AI never applies or removes

  
plugin/cc-architect
Scope: the cc-architect plugin

  
plugin/os
Scope: the os plugin

  
plugin/os-adr
Scope: the os-adr plugin

  
plugin/os-aidd-lint
Scope: the os-aidd-lint plugin

  
plugin/os-backlog
Scope: the os-backlog plugin

  
plugin/os-context
Scope: the os-context plugin

  
plugin/os-doc-hygiene
Scope: the os-doc-hygiene plugin

  
plugin/os-sdlc
Scope: the os-sdlc plugin

  
plugin/os-vault
Scope: the os-vault plugin

  
project/cc-os
Parent-scope: cc-os repo-wide, not specific to one plugin

  
ready-for-agent
Triage complete; an agent can pick this up

  
ready-for-human
Human-owned; never picked up autonomously

  
recurring
Recurring flavor: occurrence outcomes commented, never closed by AI

  
review
Shipped semi work awaiting human sign-off

  
rule-proposal
A rule change that survived the gate; Jared reads these when he chooses

  
update
Ticket updates something existing

  
waiting
Blocked; blocker named in a comment

  
wayfinder:grilling

   
wayfinder:map

   
wayfinder:map
wayfinder map ticket

  
wayfinder:research

   
wayfinder:task

   
wayfinder:task
wayfinder map child: task

  
wontfix
Will not be actioned

  
worklist/deviations
Deviation incidents from skill/pipeline runs — evidence pile for correcting the owning artifact

  
worklist/lint-rule
Proposed os-sdlc or os-aidd-lint rule

  
worklist/new-implement-build
Updated implementation harness (ast-grep + stepper)

No labels
P0
P1
P2
P3
bug
category/code-change
category/cross-repo
category/eval-run
category/investigation
category/no-test-target
category/owner-ruling
category/prose-artifact
category/recurring-chore
category/structure
category/umbrella
crc-refactor
create
delete
enhancement
filed-by/agent
filed-by/user
frozen
lint-rule
needs-info
needs-triage
next
plugin/cc-architect
plugin/os
plugin/os-adr
plugin/os-aidd-lint
plugin/os-backlog
plugin/os-context
plugin/os-doc-hygiene
plugin/os-sdlc
plugin/os-vault
project/cc-os
ready-for-agent
ready-for-human
recurring
review
rule-proposal
update
waiting
wayfinder:grilling
wayfinder:map
wayfinder:map
wayfinder:research
wayfinder:task
wayfinder:task
wontfix
worklist/deviations
worklist/lint-rule
worklist/new-implement-build
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jared/cc-os#1325
No description provided.