Sdlc/RequireInMethod crashes on require CONSTANT (NoMethodError in Call#library) #1044

New issue

Open

opened 2026-10-16 19:24:39 +00:00 by jared · 1 comment

jared commented

2026-10-16 19:24:39 +00:00

Owner

Problem

Sdlc/RequireInMethod raises while inspecting a file that calls require with a constant argument. The cop assumes a string argument; a ConstNode has no value. The error hides real offenses.

Observed

Running cd plugins/os-sdlc && bundle exec rubocop --only Sdlc/RequireInMethod eval/ticket-takedown/lib/takedown/adapter/backlog_tracker.rb prints "An error occurred while Sdlc/RequireInMethod cop was inspecting ...". With -d: lib/os_sdlc/cops/require_in_method/call.rb:31:in 'Call#library': undefined method 'value' for an instance of RuboCop::AST::ConstNode (NoMethodError). Trigger: require LIB unless defined?(Backlog::Issues) inside load_backlog. Same crash at commit 3079f785. rubocop 1.90.0, ruby 4.0.2.

Reproduce

cd plugins/os-sdlc && bundle exec rubocop --only Sdlc/RequireInMethod eval/ticket-takedown/lib/takedown/adapter/backlog_tracker.rb

Acceptance criteria

A cop test with require CONST inside a method runs without error; the cop reports an offense with a clear message or skips non-string arguments (owner decides); rubocop on backlog_tracker.rb reports no cop error.

Skeptic: VERDICT: CREATE — reproducible, and the pre-change file crashes the same way, so it is a defect in the cop.

Origin

Trigger: bundle exec rubocop --only Sdlc/RequireInMethod eval/ticket-takedown/lib/takedown/adapter/backlog_tracker.rb in plugins/os-sdlc, during the crc-refactor tuning run on plugins/os-backlog (branch crc-os-backlog-2026-10-16).
Improvised this session: none
Chain: NoMethodError in the cop ← Call#library assumes a string argument (plugins/os-sdlc/lib/os_sdlc/cops/require_in_method/call.rb:31) ← DESIGN
Root candidate: none beyond this ticket
Where: plugins/os-sdlc/lib/os_sdlc/cops/require_in_method/call.rb
Session: a5e278ab-89aa-4ed6-adb4-b70820788f0c
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-backlog-2026-10-16/a5e278ab-89aa-4ed6-adb4-b70820788f0c.jsonl

## Problem `Sdlc/RequireInMethod` raises while inspecting a file that calls `require` with a constant argument. The cop assumes a string argument; a ConstNode has no `value`. The error hides real offenses. ## Observed Running `cd plugins/os-sdlc && bundle exec rubocop --only Sdlc/RequireInMethod eval/ticket-takedown/lib/takedown/adapter/backlog_tracker.rb` prints "An error occurred while Sdlc/RequireInMethod cop was inspecting ...". With -d: `lib/os_sdlc/cops/require_in_method/call.rb:31:in 'Call#library': undefined method 'value' for an instance of RuboCop::AST::ConstNode (NoMethodError)`. Trigger: `require LIB unless defined?(Backlog::Issues)` inside `load_backlog`. Same crash at commit 3079f785. rubocop 1.90.0, ruby 4.0.2. ## Reproduce ``` cd plugins/os-sdlc && bundle exec rubocop --only Sdlc/RequireInMethod eval/ticket-takedown/lib/takedown/adapter/backlog_tracker.rb ``` ## Acceptance criteria 1. A cop test with `require CONST` inside a method runs without error; the cop reports an offense with a clear message or skips non-string arguments (owner decides); rubocop on backlog_tracker.rb reports no cop error. Skeptic: VERDICT: CREATE — reproducible, and the pre-change file crashes the same way, so it is a defect in the cop. ## Origin - Trigger: `bundle exec rubocop --only Sdlc/RequireInMethod eval/ticket-takedown/lib/takedown/adapter/backlog_tracker.rb` in plugins/os-sdlc, during the crc-refactor tuning run on plugins/os-backlog (branch crc-os-backlog-2026-10-16). - Improvised this session: none - Chain: NoMethodError in the cop ← `Call#library` assumes a string argument (plugins/os-sdlc/lib/os_sdlc/cops/require_in_method/call.rb:31) ← DESIGN - Root candidate: none beyond this ticket - Where: plugins/os-sdlc/lib/os_sdlc/cops/require_in_method/call.rb - Session: a5e278ab-89aa-4ed6-adb4-b70820788f0c - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-backlog-2026-10-16/a5e278ab-89aa-4ed6-adb4-b70820788f0c.jsonl

jared added the

plugin/os-sdlc

filed-by/agent

category/code-change

labels

2026-10-16 19:24:39 +00:00

jared referenced this issue

2026-10-16 19:26:05 +00:00

CRC wave 5: split Backlog::CliSupport #1027

jared commented

2026-10-18 18:58:43 +00:00

Author

Owner

Mechanism: a custom Sdlc cop assumes a node shape and raises, hiding other offenses in the file. Related, not folded: #1102 (BooleanControlParameter and ParameterThreadedThroughPrivateMethods crash on destructured parameters).

jared referenced this issue

2026-10-25 16:44:44 +00:00

Audit every Sdlc cop against the zero-false-positive standard #1325