Resolve setup-in-workflow advisory on fix-lints Sweeps gem-install clause #124

Open
opened 2026-07-24 18:43:34 +00:00 by jared · 2 comments
Owner

Surfaced during the lint-worklist checkpoint simplification (worktree-lint-sdlc-code). os-aidd-lint's setup-in-workflow cop flags the intentional 'gem install flay debride' recovery clause in plugins/os-sdlc/skills/fix-lints/SKILL.md's Sweeps section (advisory, non-blocking). The clause was deliberately moved out of a deleted Prerequisites section because its only non-obvious content is 'no Gemfile by design — never add one'. Decide: teach the cop to accept deliberately-placed recovery clauses outside Setup/Prerequisites (recognize more section names or an inline waiver), or accept the advisory as permanent noise. Cop: plugins/os-aidd-lint/lib/aidd_lint/cops/setup_in_workflow.rb

Surfaced during the lint-worklist checkpoint simplification (worktree-lint-sdlc-code). os-aidd-lint's setup-in-workflow cop flags the intentional 'gem install flay debride' recovery clause in plugins/os-sdlc/skills/fix-lints/SKILL.md's Sweeps section (advisory, non-blocking). The clause was deliberately moved out of a deleted Prerequisites section because its only non-obvious content is 'no Gemfile by design — never add one'. Decide: teach the cop to accept deliberately-placed recovery clauses outside Setup/Prerequisites (recognize more section names or an inline waiver), or accept the advisory as permanent noise. Cop: plugins/os-aidd-lint/lib/aidd_lint/cops/setup_in_workflow.rb
Author
Owner

This was generated by AI during triage.

Verified against plugins/os-aidd-lint/lib/aidd_lint/cops/setup_in_workflow.rb: ALLOWED_HEADING still only matches prereq|setup|install|troubleshoot; there's no inline-waiver escape hatch. Not resolved.

Options: (A) widen ALLOWED_HEADING to also recognize a "Sweeps" (or generic "recovery"/"advisory") section name, (B) add an inline waiver comment/marker the cop respects anywhere, (C) accept as permanent noise.

Recommendation: (B). Widening the heading regex (A) papers over one instance but the cop's whole point is catching setup residue in arbitrary section names — the next deliberately-placed recovery clause will just need another heading added. An inline waiver keeps the heuristic general while giving authors a documented escape for the rare deliberate case.

> *This was generated by AI during triage.* Verified against `plugins/os-aidd-lint/lib/aidd_lint/cops/setup_in_workflow.rb`: `ALLOWED_HEADING` still only matches `prereq|setup|install|troubleshoot`; there's no inline-waiver escape hatch. Not resolved. Options: (A) widen `ALLOWED_HEADING` to also recognize a "Sweeps" (or generic "recovery"/"advisory") section name, (B) add an inline waiver comment/marker the cop respects anywhere, (C) accept as permanent noise. Recommendation: (B). Widening the heading regex (A) papers over one instance but the cop's whole point is catching setup residue in *arbitrary* section names — the next deliberately-placed recovery clause will just need another heading added. An inline waiver keeps the heuristic general while giving authors a documented escape for the rare deliberate case.
Author
Owner

Frozen in the 2026-08-16 backlog reset — see #419 for the expiry procedure. Do not work unless a live run rediscovers this issue.

Frozen in the 2026-08-16 backlog reset — see #419 for the expiry procedure. Do not work unless a live run rediscovers this issue.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jared/cc-os#124
No description provided.