Runner commit subject is the last handoff's summary, which is the contract-auditor's audit note #1115

New issue

Closed

opened 2026-10-18 17:08:07 +00:00 by jared · 1 comment

jared commented

2026-10-18 17:08:07 +00:00

Owner

Problem

The behavior-verifier brief carries no test_changes. The verifier cannot see tests that already exist in the working tree. It marks work as outstanding when that work is done.

Observed

Implementation 65 of #1105, target os-backlog.
The programmer went green in dispatch 582.
The behavior-verifier brief in dispatch 583 carried no test_changes.
The verifier marked the AC2 nonzero-exit case and the AC4 ten-name pins as outstanding. Both tests were already in the working tree and green.
The Runner sent the run to test-writer in dispatch 584. Its diff-test returned unexpected_pass.
The run escalated to needs-orchestrator (escalation 38). The orchestrator hand-finished the work.

Reproduce

n/a: the evidence is implementation 65 of #1105 (dispatches 582-584, escalation 38).

Approach

Enrich test_changes (and red_tests, if the verifier needs them) at the behavior-verifier node, or have Brief::Facts supply them to that node.

Required work:

Supply test_changes to the behavior-verifier node — check: present test_changes in plugins/os-sdlc/maps/poodr-ticket-implementation.yaml
Add a test that the verifier brief for a green increment contains the round's test diff.

Acceptance criteria

Given a green increment with placed tests, when the behavior-verifier brief is built, then it contains the round's test diff in test_changes.
Given tests already in the working tree and green, when the verifier runs, then it does not mark them outstanding.

Owner sketch

class Brief::Facts
  def test_changes
end

Origin

Trigger: implementation 65 of #1105, dispatches 582-584
Improvised this session: orchestrator hand-finished the run
Chain: unexpected_pass escalation 38 ← verifier marked done tests outstanding ← brief 583 omitted test_changes ← DESIGN (plugins/os-sdlc/maps/poodr-ticket-implementation.yaml)
Root candidate: none
Where: plugins/os-sdlc/maps/poodr-ticket-implementation.yaml, Brief::Facts
Session: 26783407-6911-48d5-a818-55fbfbc70108
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/26783407-6911-48d5-a818-55fbfbc70108.jsonl

## Problem The behavior-verifier brief carries no `test_changes`. The verifier cannot see tests that already exist in the working tree. It marks work as outstanding when that work is done. ## Observed Implementation 65 of #1105, target os-backlog. The programmer went green in dispatch 582. The behavior-verifier brief in dispatch 583 carried no `test_changes`. The verifier marked the AC2 nonzero-exit case and the AC4 ten-name pins as outstanding. Both tests were already in the working tree and green. The Runner sent the run to test-writer in dispatch 584. Its diff-test returned `unexpected_pass`. The run escalated to needs-orchestrator (escalation 38). The orchestrator hand-finished the work. ## Reproduce n/a: the evidence is implementation 65 of #1105 (dispatches 582-584, escalation 38). ## Approach Enrich `test_changes` (and `red_tests`, if the verifier needs them) at the behavior-verifier node, or have `Brief::Facts` supply them to that node. Required work: 1. Supply `test_changes` to the behavior-verifier node — check: present `test_changes` in `plugins/os-sdlc/maps/poodr-ticket-implementation.yaml` 2. Add a test that the verifier brief for a green increment contains the round's test diff. ## Acceptance criteria 1. Given a green increment with placed tests, when the behavior-verifier brief is built, then it contains the round's test diff in `test_changes`. 2. Given tests already in the working tree and green, when the verifier runs, then it does not mark them outstanding. ## Owner sketch ```ruby class Brief::Facts def test_changes end ``` ## Origin - Trigger: implementation 65 of #1105, dispatches 582-584 - Improvised this session: orchestrator hand-finished the run - Chain: unexpected_pass escalation 38 ← verifier marked done tests outstanding ← brief 583 omitted test_changes ← DESIGN (plugins/os-sdlc/maps/poodr-ticket-implementation.yaml) - Root candidate: none - Where: plugins/os-sdlc/maps/poodr-ticket-implementation.yaml, Brief::Facts - Session: 26783407-6911-48d5-a818-55fbfbc70108 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/26783407-6911-48d5-a818-55fbfbc70108.jsonl

jared added the

plugin/os-sdlc

filed-by/user

category/code-change

labels

2026-10-18 17:08:07 +00:00

jared referenced this issue

2026-10-18 18:58:39 +00:00

Runner commit message on implementation_complete is the contract-auditor summary #987

jared commented

2026-10-18 18:59:16 +00:00

Author