No approved map fits a behavior-preserving refactor #952

New issue

Closed

opened 2026-10-05 13:05:47 +00:00 by jared · 2 comments

jared commented

2026-10-05 13:05:47 +00:00

Owner

VERDICT: CREATE

Problem

No approved map fits a behavior-preserving refactor. poodr-ticket-implementation requires every new test red. poodr-guard-implementation has no programmer node. Implementation 30 spent four test-writer and test-reviewer rounds (bound_exhausted:test-reviewer/fail) on correct green preservation pins.

Reproduce

n/a: needs a live run of a refactor ticket; implementation 30 shows it.

Approach

Required work:

Add an approved map for behavior-preserving refactors whose test nodes accept green preservation pins, then run the refactorer — check: present preservation in plugins/os-sdlc/maps/*.yaml

Acceptance criteria

Given a refactor ticket with green preservation pins, when map-router selects a map, then it selects a map whose test nodes accept green pins.
Given that map, when the pins pass before any production change, then no node fails the run for green tests.

Owner sketch

class Map::Catalog
  def default
end

Origin

Trigger: os-sdlc implementation 30 of ticket #948.
Improvised this session: none
Chain: bound_exhausted:test-reviewer/fail ← both approved maps assume red tests or lack a programmer node ← DESIGN (plugins/os-sdlc/maps/poodr-ticket-implementation.yaml line 91, poodr-guard-implementation.yaml)
Where: plugins/os-sdlc/maps/
Session: ab599e53-dbf5-4953-b8bf-c598a9c5c16e
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-adr-2026-10-04/ab599e53-dbf5-4953-b8bf-c598a9c5c16e.jsonl

VERDICT: CREATE ## Problem No approved map fits a behavior-preserving refactor. `poodr-ticket-implementation` requires every new test red. `poodr-guard-implementation` has no programmer node. Implementation 30 spent four test-writer and test-reviewer rounds (bound_exhausted:test-reviewer/fail) on correct green preservation pins. ## Reproduce n/a: needs a live run of a refactor ticket; implementation 30 shows it. ## Approach Required work: 1. Add an approved map for behavior-preserving refactors whose test nodes accept green preservation pins, then run the refactorer — check: present `preservation` in `plugins/os-sdlc/maps/*.yaml` ## Acceptance criteria 1. Given a refactor ticket with green preservation pins, when map-router selects a map, then it selects a map whose test nodes accept green pins. 2. Given that map, when the pins pass before any production change, then no node fails the run for green tests. ## Owner sketch ```ruby class Map::Catalog def default end ``` ## Origin - Trigger: os-sdlc implementation 30 of ticket #948. - Improvised this session: none - Chain: bound_exhausted:test-reviewer/fail ← both approved maps assume red tests or lack a programmer node ← DESIGN (plugins/os-sdlc/maps/poodr-ticket-implementation.yaml line 91, poodr-guard-implementation.yaml) - Where: plugins/os-sdlc/maps/ - Session: ab599e53-dbf5-4953-b8bf-c598a9c5c16e - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-os-adr-2026-10-04/ab599e53-dbf5-4953-b8bf-c598a9c5c16e.jsonl

jared added the

plugin/os-sdlc

filed-by/agent

labels

2026-10-05 13:05:47 +00:00

jared referenced this issue

2026-10-05 13:09:51 +00:00

os-adr: three copies of path and file-name knowledge (A12) #948

jared added the

category/code-change

label

2026-10-10 13:31:45 +00:00

jared commented

2026-10-16 16:22:27 +00:00

Author

Owner

Not CRC work. It asks for a new approved os-sdlc map for behavior-preserving refactors (green preservation pins, refactorer node). That is a pipeline/maps design change in plugins/os-sdlc/maps/, independent of the crc-refactor skill and its ledger run. Detached from the CRC close-out (docs/crc/PLAN.md); it stays open on its own. It carries no crc label and no blocks/dependency link, so no relation needed removal.

jared referenced this issue

2026-10-18 18:58:41 +00:00

implement skill names no map for a behavior-preserving refactor; ticket-implementation map escalates on unexpected_pass #663

jared commented

2026-10-18 18:59:22 +00:00

Author

Owner