Let a reopened implementation see a committed hand-fixed test at the diff-test gate #894

New issue

Open

opened 2026-10-01 21:15:36 +00:00 by jared · 0 comments

jared commented

2026-10-01 21:15:36 +00:00

Owner

Problem

A reopened implementation cannot use a hand-fixed test that the orchestrator committed. The test-writer diff-test gate plans its run from the working-tree diff only. After a test defect, the escalation rule says: hand-fix the test, set the production diff aside, and reopen. When the orchestrator commits the hand-fixed test, the gate finds no changed test and reports unexpected_pass, although the test fails without the production change.

Observed

On #878, implementation 12 reopened after implementation 11 hit a test-helper defect. The test file was committed in 5125c6b5. The test-writer (dispatch 79) ran the gate twice with diff-test exit 0 in 0 ms (no planned tests). It then renamed a constant in the committed file to put the file back in the working-tree diff. The third gate run was red for the intended reason.

Reproduce

n/a: needs a reopened implementation with a committed test; the dispatch 79 gate steps in os-sdlc-implementation-report 12 show it.

Origin

Trigger: #878 implementation 12, dispatch 79 (2026-10-01)
Improvised this session: the test-writer renamed constant SUMMARY to WORK_DONE to make the file appear in the diff
Chain: reopened run reports unexpected_pass ← diff-test plans from the working-tree diff only ← DESIGN (plugins/os-sdlc/lib/os_sdlc/query/gate/commands.rb plan)
Root candidate: none
Where: plugins/os-sdlc/lib/os_sdlc/query/gate/commands.rb
Session: 8cb89545-668f-4061-9d99-470dab1af38f
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/8cb89545-668f-4061-9d99-470dab1af38f.jsonl

Parent: #859

VERDICT: CREATE — the standing hand-fix-and-reopen procedure leads to an empty diff-test plan; the chain ends in DESIGN (ticket-skeptic, claude-sonnet-5-5).

## Problem A reopened implementation cannot use a hand-fixed test that the orchestrator committed. The test-writer `diff-test` gate plans its run from the working-tree diff only. After a test defect, the escalation rule says: hand-fix the test, set the production diff aside, and reopen. When the orchestrator commits the hand-fixed test, the gate finds no changed test and reports `unexpected_pass`, although the test fails without the production change. ## Observed On #878, implementation 12 reopened after implementation 11 hit a test-helper defect. The test file was committed in 5125c6b5. The test-writer (dispatch 79) ran the gate twice with `diff-test` exit 0 in 0 ms (no planned tests). It then renamed a constant in the committed file to put the file back in the working-tree diff. The third gate run was red for the intended reason. ## Reproduce n/a: needs a reopened implementation with a committed test; the dispatch 79 gate steps in `os-sdlc-implementation-report 12` show it. ## Origin - Trigger: #878 implementation 12, dispatch 79 (2026-10-01) - Improvised this session: the test-writer renamed constant `SUMMARY` to `WORK_DONE` to make the file appear in the diff - Chain: reopened run reports unexpected_pass ← diff-test plans from the working-tree diff only ← DESIGN (plugins/os-sdlc/lib/os_sdlc/query/gate/commands.rb `plan`) - Root candidate: none - Where: plugins/os-sdlc/lib/os_sdlc/query/gate/commands.rb - Session: 8cb89545-668f-4061-9d99-470dab1af38f - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/8cb89545-668f-4061-9d99-470dab1af38f.jsonl Parent: #859 VERDICT: CREATE — the standing hand-fix-and-reopen procedure leads to an empty diff-test plan; the chain ends in DESIGN (ticket-skeptic, claude-sonnet-5-5).

jared added the

plugin/os-sdlc

filed-by/agent

labels

2026-10-01 21:15:36 +00:00

jared referenced this issue

2026-10-01 21:15:37 +00:00

Accept a reroute verdict from change-auditor and route it to map-router #878

jared referenced this issue

2026-10-01 21:23:06 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared added the