Lens proposal: move Reroute::Draft to command/reroute/draft.rb #891

New issue

Closed

opened 2026-10-01 20:19:09 +00:00 by jared · 1 comment

jared commented

2026-10-01 20:19:09 +00:00

Owner

Problem

Reroute::Draft drives a workflow (write) but lives in reroute/, not a role directory.

Observed

LENS: A1 broken at plugins/os-sdlc/lib/os_sdlc/reroute/draft.rb:5 - Reroute::Draft drives a workflow (write) but lives in reroute/, not a role directory; JUSTIFIED: yes (ticket #873 R5 pinned the path); PROPOSAL: NONE

Challenge verdict (opus): code defect found. Draft#write validates then writes in a transaction, so A1 puts it in command/. Siblings query/reroute/check.rb, presenter/reroute/block.rb, and model/reroute/* obey A1. lib/os_sdlc.rb:25 collapses role directories, so the constant OsSdlc::Reroute::Draft and its caller controller/implementation/guidance.rb:24 do not change. Only #873's R5 check text names the path.

Reproduce

n/a: lens finding, no failing command.

Approach

Move the file and remove the empty directory.

Required work:

Move Reroute::Draft to command/reroute/draft.rb — check: present class Draft in plugins/os-sdlc/lib/os_sdlc/command/reroute/draft.rb
Remove the old file — check: absent class Draft in plugins/os-sdlc/lib/os_sdlc/reroute/draft.rb

Origin

Trigger: lens review of #873
Improvised this session: none
Chain: A1 broken ← file placed in reroute/ ← DESIGN (ticket #873 R5 pinned the path)
Root candidate: none
Where: plugins/os-sdlc/lib/os_sdlc/reroute/draft.rb
Session: n/a (filed by a subagent of the #873 session)
Transcript: n/a

Found during #873. Run ticket: #873.

VERDICT: CREATE

## Problem `Reroute::Draft` drives a workflow (`write`) but lives in `reroute/`, not a role directory. ## Observed LENS: A1 broken at plugins/os-sdlc/lib/os_sdlc/reroute/draft.rb:5 - Reroute::Draft drives a workflow (write) but lives in reroute/, not a role directory; JUSTIFIED: yes (ticket #873 R5 pinned the path); PROPOSAL: NONE Challenge verdict (opus): code defect found. `Draft#write` validates then writes in a transaction, so A1 puts it in `command/`. Siblings `query/reroute/check.rb`, `presenter/reroute/block.rb`, and `model/reroute/*` obey A1. `lib/os_sdlc.rb:25` collapses role directories, so the constant `OsSdlc::Reroute::Draft` and its caller `controller/implementation/guidance.rb:24` do not change. Only #873's R5 check text names the path. ## Reproduce n/a: lens finding, no failing command. ## Approach Move the file and remove the empty directory. Required work: 1. Move `Reroute::Draft` to `command/reroute/draft.rb` — check: present `class Draft` in `plugins/os-sdlc/lib/os_sdlc/command/reroute/draft.rb` 2. Remove the old file — check: absent `class Draft` in `plugins/os-sdlc/lib/os_sdlc/reroute/draft.rb` ## Origin - Trigger: lens review of #873 - Improvised this session: none - Chain: A1 broken ← file placed in reroute/ ← DESIGN (ticket #873 R5 pinned the path) - Root candidate: none - Where: plugins/os-sdlc/lib/os_sdlc/reroute/draft.rb - Session: n/a (filed by a subagent of the #873 session) - Transcript: n/a Found during #873. Run ticket: #873. VERDICT: CREATE

jared added the

ready-for-human

plugin/os-sdlc

filed-by/agent

labels

2026-10-01 20:19:09 +00:00

jared referenced this issue

2026-10-01 20:19:13 +00:00

Add the reroute gate and the reroute landing with the REROUTE block #873

jared referenced this issue

2026-10-01 20:25:09 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared added the

category/no-test-target

label

2026-10-10 13:50:41 +00:00

jared commented

2026-10-18 18:59:01 +00:00

Author

Owner

Resolution

Done: Obsolete: Reroute::Draft moved to a different placement through the CRC pass; the proposed command/reroute/draft.rb is superseded.

Evidence: plugins/os-sdlc/lib/os_sdlc/implementation/reroute/draft.rb exists; lib/os_sdlc/command/reroute does not exist.

Follow-ups: none

## Resolution **Done:** Obsolete: Reroute::Draft moved to a different placement through the CRC pass; the proposed command/reroute/draft.rb is superseded. **Evidence:** plugins/os-sdlc/lib/os_sdlc/implementation/reroute/draft.rb exists; lib/os_sdlc/command/reroute does not exist. **Follow-ups:** none

jared closed this issue

2026-10-18 18:59:01 +00:00