jared/cc-os

Watch

Fork 0

Add reroutes table and Implementation#current_map with report rows #871

New issue

Closed

opened 2026-10-01 14:26:16 +00:00 by jared · 2 comments

jared commented

2026-10-01 14:26:16 +00:00

Owner

Problem

ADR-0258 decision 5 keeps the default map frozen and records each map change as a reroutes row. No reroutes table exists, and every consumer reads implementation.map (the default): Routing (command/implementation/routing.rb:10), TransitWalk (transit_walk.rb:7), Landing (landing.rb:49), NextStep#map (pipeline/next_step.rb:70), StartSubagent#map (command/start_subagent.rb:32), CompletionIntake#map (command/completion_intake.rb:64), ObjectionsDigest (query/brief/objections_digest.rb:29), and Implementation#current_node/#dispatch_cap (model/implementation.rb:64-65). The implementation report (os-sdlc-implementation-report) shows no map history.

Reproduce

n/a: design change, nothing to reproduce.

Approach

Add the reroutes table in Db.create_ledger_tables (adapter/db.rb), modeled on objections, and bump SCHEMA_VERSION (ADR-0129/0155):

create_table(:reroutes) do
  primary_key :id
  foreign_key :implementation_id, :implementations, null: false
  foreign_key :dispatch_id, :dispatches, null: true   # the requesting dispatch; nil = orchestrator
  String :map, null: false
  String :node, null: false
  String :situation, text: true, null: false
  String :misfit, text: true, null: false
  TrueClass :draft, null: false, default: false
  DateTime :created_at, null: false
end

Add the Sequel model OsSdlc::Reroute < Sequel::Model and Implementation one_to_many :reroutes, order: [Sequel.desc(:created_at), Sequel.desc(:id)] (ADR-0259 decision 6; the id breaks same-second ties). Implementation#current_map loads reroutes.first&.map through Map::Catalog.default when a row exists, else returns map. map stays the default and is never mutated (ADR-0169). Do not memoize current_map across a new row (the associations[:map] memo in targeting.rb:6 must not serve it). Switch every consumer listed in Problem to current_map. dispatch_cap reads current_map.dispatch_cap; DispatchBudget already counts all dispatches of the implementation (ADR-0152, decision 8).

Implementation::Summary#to_h adds reroutes:, oldest first, each { map:, node:, by:, situation:, misfit:, draft: } where by is "orchestrator" when dispatch_id is nil, else "<agent_type> (dispatch N)".

This ticket writes no reroute rows in production code; the reroute gate ticket does. The draft column exists now; slice 4 resolves drafts.

Required work:

Create the reroutes table — check: present create_table_with_timestamps(db, :reroutes) in plugins/os-sdlc/lib/os_sdlc/adapter/db.rb
Add the reroutes association and current_map — check: present def current_map in plugins/os-sdlc/lib/os_sdlc/model/**/*.rb
Add the Reroute model — check: present class Reroute < Sequel::Model in plugins/os-sdlc/lib/os_sdlc/**/*.rb
Route through the current map — check: present current_map in plugins/os-sdlc/lib/os_sdlc/command/implementation/routing.rb
Report reroute rows — check: present reroutes: in plugins/os-sdlc/lib/os_sdlc/presenter/implementation/summary.rb

Acceptance criteria

Given an implementation with no reroutes, when its current map is read, then it is the default map.
Given an implementation with two reroutes rows, when its current map is read, then it is the map of the newest row, and the default map name in the row is unchanged.
Given a rerouted implementation positioned at a node that exists only in the new map, when the next step is computed, then the dispatch payload names that node's agent from the new map.
Given a rerouted implementation whose new map has a different dispatch_cap, when routing checks the budget, then it uses the new map's cap and counts dispatches made under both maps.
Given two reroutes rows with the same created_at, when the current map is read, then it is the map of the row with the higher id.
Given an implementation with one orchestrator reroute and one by dispatch 7 (change-auditor), when os-sdlc-implementation-report runs, then the output lists both rows oldest first with by: orchestrator and by: change-auditor (dispatch 7).

Owner sketch

class OsSdlc::Reroute < Sequel::Model
  many_to_one :implementation
  many_to_one :dispatch
end

class OsSdlc::Implementation
  one_to_many :reroutes
  def current_map
end

Non-goals

Edge-spend bounds stay keyed by (from_node, verdict) (model/edge_spend.rb). A new map with the same node names shares those counters; this ticket does not change that.

Origin

Trigger: user ruling on the map reroute design, 2026-10-01 (ADR-0258; A2 in ADR-0259)
Improvised this session: none
Chain: a run cannot change maps ← Implementation#map is the only map source ← DESIGN (docs/adr/0169, docs/adr/0258 decision 5)
Root candidate: #859
Where: plugins/os-sdlc/lib/os_sdlc/model/implementation.rb
Session: 55a56279-83ee-47d5-a21e-ee67f9e28abd
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/55a56279-83ee-47d5-a21e-ee67f9e28abd.jsonl

Parent: #859
Blocked by: #868

## Problem ADR-0258 decision 5 keeps the default map frozen and records each map change as a `reroutes` row. No `reroutes` table exists, and every consumer reads `implementation.map` (the default): `Routing` (command/implementation/routing.rb:10), `TransitWalk` (transit_walk.rb:7), `Landing` (landing.rb:49), `NextStep#map` (pipeline/next_step.rb:70), `StartSubagent#map` (command/start_subagent.rb:32), `CompletionIntake#map` (command/completion_intake.rb:64), `ObjectionsDigest` (query/brief/objections_digest.rb:29), and `Implementation#current_node`/`#dispatch_cap` (model/implementation.rb:64-65). The implementation report (`os-sdlc-implementation-report`) shows no map history. ## Reproduce n/a: design change, nothing to reproduce. ## Approach Add the `reroutes` table in `Db.create_ledger_tables` (adapter/db.rb), modeled on `objections`, and bump `SCHEMA_VERSION` (ADR-0129/0155): ```ruby create_table(:reroutes) do primary_key :id foreign_key :implementation_id, :implementations, null: false foreign_key :dispatch_id, :dispatches, null: true # the requesting dispatch; nil = orchestrator String :map, null: false String :node, null: false String :situation, text: true, null: false String :misfit, text: true, null: false TrueClass :draft, null: false, default: false DateTime :created_at, null: false end ``` Add the Sequel model `OsSdlc::Reroute < Sequel::Model` and `Implementation one_to_many :reroutes, order: [Sequel.desc(:created_at), Sequel.desc(:id)]` (ADR-0259 decision 6; the id breaks same-second ties). `Implementation#current_map` loads `reroutes.first&.map` through `Map::Catalog.default` when a row exists, else returns `map`. `map` stays the default and is never mutated (ADR-0169). Do not memoize `current_map` across a new row (the `associations[:map]` memo in targeting.rb:6 must not serve it). Switch every consumer listed in Problem to `current_map`. `dispatch_cap` reads `current_map.dispatch_cap`; `DispatchBudget` already counts all dispatches of the implementation (ADR-0152, decision 8). `Implementation::Summary#to_h` adds `reroutes:`, oldest first, each `{ map:, node:, by:, situation:, misfit:, draft: }` where `by` is `"orchestrator"` when `dispatch_id` is nil, else `"<agent_type> (dispatch N)"`. This ticket writes no reroute rows in production code; the reroute gate ticket does. The `draft` column exists now; slice 4 resolves drafts. Required work: 1. Create the reroutes table — check: present `create_table_with_timestamps(db, :reroutes)` in `plugins/os-sdlc/lib/os_sdlc/adapter/db.rb` 2. Add the reroutes association and `current_map` — check: present `def current_map` in `plugins/os-sdlc/lib/os_sdlc/model/**/*.rb` 3. Add the Reroute model — check: present `class Reroute < Sequel::Model` in `plugins/os-sdlc/lib/os_sdlc/**/*.rb` 4. Route through the current map — check: present `current_map` in `plugins/os-sdlc/lib/os_sdlc/command/implementation/routing.rb` 5. Report reroute rows — check: present `reroutes:` in `plugins/os-sdlc/lib/os_sdlc/presenter/implementation/summary.rb` ## Acceptance criteria 1. Given an implementation with no reroutes, when its current map is read, then it is the default map. 2. Given an implementation with two reroutes rows, when its current map is read, then it is the map of the newest row, and the default map name in the row is unchanged. 3. Given a rerouted implementation positioned at a node that exists only in the new map, when the next step is computed, then the dispatch payload names that node's agent from the new map. 4. Given a rerouted implementation whose new map has a different `dispatch_cap`, when routing checks the budget, then it uses the new map's cap and counts dispatches made under both maps. 5. Given two reroutes rows with the same `created_at`, when the current map is read, then it is the map of the row with the higher id. 6. Given an implementation with one orchestrator reroute and one by dispatch 7 (change-auditor), when `os-sdlc-implementation-report` runs, then the output lists both rows oldest first with `by: orchestrator` and `by: change-auditor (dispatch 7)`. ## Owner sketch ```ruby class OsSdlc::Reroute < Sequel::Model many_to_one :implementation many_to_one :dispatch end class OsSdlc::Implementation one_to_many :reroutes def current_map end ``` ## Non-goals Edge-spend bounds stay keyed by `(from_node, verdict)` (model/edge_spend.rb). A new map with the same node names shares those counters; this ticket does not change that. ## Origin - Trigger: user ruling on the map reroute design, 2026-10-01 (ADR-0258; A2 in ADR-0259) - Improvised this session: none - Chain: a run cannot change maps ← `Implementation#map` is the only map source ← DESIGN (docs/adr/0169, docs/adr/0258 decision 5) - Root candidate: #859 - Where: plugins/os-sdlc/lib/os_sdlc/model/implementation.rb - Session: 55a56279-83ee-47d5-a21e-ee67f9e28abd - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/55a56279-83ee-47d5-a21e-ee67f9e28abd.jsonl Parent: #859 Blocked by: #868

jared added the

plugin/os-sdlc

filed-by/user

labels

2026-10-01 14:26:16 +00:00

~~jared referenced this issue 2026-10-01 14:26:17 +00:00~~

Make escalation a waiting position at needs-orchestrator #872

jared referenced this issue

2026-10-01 14:26:17 +00:00

Add the reroute gate and the reroute landing with the REROUTE block #873

jared added the

ready-for-agent

label

2026-10-01 14:26:44 +00:00

jared added a new dependency

2026-10-01 14:27:26 +00:00

#868 Bind implementations to a map name through Map::Catalog

jared added a new dependency

2026-10-01 14:27:27 +00:00

#872 Make escalation a waiting position at needs-orchestrator

jared added a new dependency

2026-10-01 14:27:27 +00:00

#873 Add the reroute gate and the reroute landing with the REROUTE block

jared referenced this issue

2026-10-01 14:27:34 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared referenced this issue

2026-10-01 15:26:46 +00:00

Resolve drafted maps from maps/drafts/ through Map::Catalog #880

jared removed a dependency

2026-10-01 15:29:26 +00:00

#872 Make escalation a waiting position at needs-orchestrator

jared referenced this issue

2026-10-01 15:29:41 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared added a new dependency

2026-10-01 15:29:49 +00:00

#880 Resolve drafted maps from maps/drafts/ through Map::Catalog

jared commented

2026-10-01 16:35:41 +00:00

Author

Owner

Work started on branch ticket-871 (os-sdlc pipeline, map poodr-ticket-implementation).

jared commented

2026-10-01 16:51:50 +00:00

Author

Owner

Resolution

Done: reroutes table + Reroute model; Implementation#current_map owns the map choice and every listed consumer reads it; the implementation report/summary shows reroute rows; SCHEMA_VERSION bumped. Deviation: the Runner commit left plugins/os-sdlc/lib/os_sdlc/model/dispatch.rb (Dispatch has many reroutes) in dirty_paths because no agent listed it; committed by hand as f28dff08 (the suite had run with it).

Evidence: main 91f8a7e6 (Runner commit, implementation 3 implementation_complete, 13 dispatches, 1 retry), f28dff08, History row; required-work gate passed in suite-check; bin/test on main: 9 suites passed.

Follow-ups: none

## Resolution **Done:** reroutes table + Reroute model; Implementation#current_map owns the map choice and every listed consumer reads it; the implementation report/summary shows reroute rows; SCHEMA_VERSION bumped. Deviation: the Runner commit left plugins/os-sdlc/lib/os_sdlc/model/dispatch.rb (Dispatch has many reroutes) in dirty_paths because no agent listed it; committed by hand as f28dff08 (the suite had run with it). **Evidence:** main 91f8a7e6 (Runner commit, implementation 3 implementation_complete, 13 dispatches, 1 retry), f28dff08, History row; required-work gate passed in suite-check; bin/test on main: 9 suites passed. **Follow-ups:** none

jared closed this issue

2026-10-01 16:51:50 +00:00

jared referenced this issue

2026-10-01 18:17:51 +00:00

no pipeline path for guard/characterization tests (unexpected_pass escalation) #859

jared referenced this issue from a commit

2026-10-01 18:24:32 +00:00

feat(os-sdlc): Audited POODR boundaries for 871; Implementation#current_map owns the map choice, all listed consumers read it, all five WORK items present. (#871)

jared referenced this issue from a commit

2026-10-01 18:24:32 +00:00

feat(os-sdlc): #871 Dispatch has many reroutes

jared referenced this issue from a commit