os-sdlc: delete dead namespace config #831

New issue

Closed

opened 2026-09-29 16:15:49 +00:00 by jared · 1 comment

jared commented

2026-09-29 16:15:49 +00:00

Owner

Problem

Three namespace settings do nothing.
No top-level evidence/ directory exists, so the "evidence" entry in the collapse list (lib/os_sdlc.rb:26) is a no-op behind its File.directory? guard.
The code never looks up "evidence" => 1 in ROLE_LAYER (lint/inward_dependencies.rb).
The only reader of INFLECTIONS (lint/inward_dependencies.rb:15) is SourceFile#const_name, and nothing calls it.
User ruling on the #781 follow-up (c), 2026-09-29.
Order: after #829.

Reproduce

n/a: dead-code removal, nothing to reproduce.

Approach

Paths are relative to plugins/os-sdlc/lib/os_sdlc/.

Required work:

Delete "evidence" from the collapse list in lib/os_sdlc.rb:26. — check: grep -n evidence plugins/os-sdlc/lib/os_sdlc.rb
Delete "evidence" => 1 from ROLE_LAYER in lint/inward_dependencies.rb.
Delete INFLECTIONS (lint/inward_dependencies.rb:15), SourceFile#const_name, and its camelize helper (line ~121).

Do not touch const_name or camelize under lib/os_sdlc/cops/. Those belong to RuboCop and are unrelated.

Acceptance criteria

Given the source tree, when searched, then lint/inward_dependencies.rb has no INFLECTIONS, const_name, or camelize, and no "evidence" entry in ROLE_LAYER.
Given lib/os_sdlc.rb, when read, then the collapse list has no "evidence" entry.
Given the change, when the suite runs, then it passes.
Given lib/os_sdlc/cops/, when diffed, then it is unchanged.

Owner sketch

module OsSdlc
  module Lint
    class InwardDependencies
      ROLE_LAYER = {}.freeze
    end
  end
end

Origin

Trigger: #781 follow-up (c), user ruling.
Improvised this session: none
Chain: dead namespace config ← leftover from earlier layout ← DESIGN (ADR-0236, controller/ layout)
Root candidate: none
Where: lib/os_sdlc.rb, lint/inward_dependencies.rb
Session: 61834fd0-8fa2-40d2-8215-fb2f0622220d
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-pass-os-sdlc/61834fd0-8fa2-40d2-8215-fb2f0622220d.jsonl

## Problem Three namespace settings do nothing. No top-level evidence/ directory exists, so the `"evidence"` entry in the collapse list (lib/os_sdlc.rb:26) is a no-op behind its `File.directory?` guard. The code never looks up `"evidence" => 1` in `ROLE_LAYER` (lint/inward_dependencies.rb). The only reader of `INFLECTIONS` (lint/inward_dependencies.rb:15) is `SourceFile#const_name`, and nothing calls it. User ruling on the #781 follow-up (c), 2026-09-29. Order: after #829. ## Reproduce n/a: dead-code removal, nothing to reproduce. ## Approach Paths are relative to plugins/os-sdlc/lib/os_sdlc/. Required work: 1. Delete `"evidence"` from the collapse list in lib/os_sdlc.rb:26. — check: `grep -n evidence plugins/os-sdlc/lib/os_sdlc.rb` 2. Delete `"evidence" => 1` from `ROLE_LAYER` in lint/inward_dependencies.rb. 3. Delete `INFLECTIONS` (lint/inward_dependencies.rb:15), `SourceFile#const_name`, and its `camelize` helper (line ~121). Do not touch `const_name` or `camelize` under lib/os_sdlc/cops/. Those belong to RuboCop and are unrelated. ## Acceptance criteria 1. Given the source tree, when searched, then lint/inward_dependencies.rb has no `INFLECTIONS`, `const_name`, or `camelize`, and no `"evidence"` entry in `ROLE_LAYER`. 2. Given lib/os_sdlc.rb, when read, then the collapse list has no `"evidence"` entry. 3. Given the change, when the suite runs, then it passes. 4. Given lib/os_sdlc/cops/, when diffed, then it is unchanged. ## Owner sketch ```ruby module OsSdlc module Lint class InwardDependencies ROLE_LAYER = {}.freeze end end end ``` ## Origin - Trigger: #781 follow-up (c), user ruling. - Improvised this session: none - Chain: dead namespace config ← leftover from earlier layout ← DESIGN (ADR-0236, controller/ layout) - Root candidate: none - Where: lib/os_sdlc.rb, lint/inward_dependencies.rb - Session: 61834fd0-8fa2-40d2-8215-fb2f0622220d - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-pass-os-sdlc/61834fd0-8fa2-40d2-8215-fb2f0622220d.jsonl

jared added the

plugin/os-sdlc

filed-by/user

labels

2026-09-29 16:15:49 +00:00

jared commented

2026-09-29 16:29:49 +00:00

Author

Owner

Resolution

Done: Deleted evidence from the Zeitwerk collapse list and ROLE_LAYER, InwardDependencies::INFLECTIONS, SourceFile#const_name and #camelize.

Evidence: Commit 1120098d on main; ADR-0246; no callers found by grep; suite 1328 runs 0 failures.

Follow-ups: none

## Resolution **Done:** Deleted evidence from the Zeitwerk collapse list and ROLE_LAYER, InwardDependencies::INFLECTIONS, SourceFile#const_name and #camelize. **Evidence:** Commit 1120098d on main; ADR-0246; no callers found by grep; suite 1328 runs 0 failures. **Follow-ups:** none

jared closed this issue

2026-09-29 16:29:49 +00:00

jared referenced this issue from a commit

2026-09-29 16:46:31 +00:00

refactor(os-sdlc): #831 delete dead namespace config

jared referenced this issue from a commit

2026-09-29 16:46:31 +00:00

docs: ADR-0246, history row and handoff for #829 #830 #831

jared referenced this issue

2026-09-30 16:47:16 +00:00

Replace shell Required-work checks with typed present/absent checks that Ruby evaluates #843