Delete five dead os-sdlc units found by the CRC pass #782

New issue

Closed

opened 2026-09-27 23:05:34 +00:00 by jared · 2 comments

jared commented

2026-09-27 23:05:34 +00:00

Owner

Problem

Five classes have no caller in lib/, bin/, hooks/, agents/, or skills/: PushNotifier, NullNotifier, GreenAssertFailureSidecar, ReportRenderer, Daemon::Connection.
These are dead units left from earlier refactors.

Reproduce

n/a: deletion of unreachable code.

Approach

Delete each class file and its test file; run suite green. Rulings adopted: no owner; deletions only.

Required work:

PushNotifier deleted from lib/os_sdlc/adapters/notifiers.rb and test removed
NullNotifier deleted from lib/os_sdlc/adapters/notifiers.rb and test removed
GreenAssertFailureSidecar deleted from lib/os_sdlc/presenter/assert_result.rb and test removed
ReportRenderer deleted from lib/os_sdlc/presenter/report_renderer.rb and test removed
Daemon::Connection deleted from lib/os_sdlc/daemon/connection.rb and test removed
Suite green — check: cd plugins/os-sdlc && ruby tests/all.rb

Acceptance criteria

Given the five constants, when grepped across plugins/os-sdlc, then zero hits.
Given the suite, when run, then it passes with zero failures.
Given the diff, when checked, then only the five files and their tests are removed.

Owner sketch

# no owner; deletions only

Non-goals

No behavior change. No new tests. Dead-code deletion only.

Origin

Trigger: CRC session 13 dead-code sweep, docs/crc/os-sdlc
Improvised this session: none
Chain: dead units ← RunnerCLI dissolution and earlier extractions (#767, #768) ← DESIGN (ADR-0231, ADR-0232)
Root candidate: this ticket
Where: plugins/os-sdlc/lib/os_sdlc/ (five files)
Session: e64808e4-7c0b-4664-9d13-177acbbc143c
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-pass-os-sdlc/e64808e4-7c0b-4664-9d13-177acbbc143c.jsonl

## Problem Five classes have no caller in lib/, bin/, hooks/, agents/, or skills/: PushNotifier, NullNotifier, GreenAssertFailureSidecar, ReportRenderer, Daemon::Connection. These are dead units left from earlier refactors. ## Reproduce n/a: deletion of unreachable code. ## Approach Delete each class file and its test file; run suite green. Rulings adopted: no owner; deletions only. Required work: 1. PushNotifier deleted from lib/os_sdlc/adapters/notifiers.rb and test removed 2. NullNotifier deleted from lib/os_sdlc/adapters/notifiers.rb and test removed 3. GreenAssertFailureSidecar deleted from lib/os_sdlc/presenter/assert_result.rb and test removed 4. ReportRenderer deleted from lib/os_sdlc/presenter/report_renderer.rb and test removed 5. Daemon::Connection deleted from lib/os_sdlc/daemon/connection.rb and test removed 6. Suite green — check: cd plugins/os-sdlc && ruby tests/all.rb ## Acceptance criteria 1. Given the five constants, when grepped across plugins/os-sdlc, then zero hits. 2. Given the suite, when run, then it passes with zero failures. 3. Given the diff, when checked, then only the five files and their tests are removed. ## Owner sketch ```ruby # no owner; deletions only ``` ## Non-goals No behavior change. No new tests. Dead-code deletion only. ## Origin - Trigger: CRC session 13 dead-code sweep, docs/crc/os-sdlc - Improvised this session: none - Chain: dead units ← RunnerCLI dissolution and earlier extractions (#767, #768) ← DESIGN (ADR-0231, ADR-0232) - Root candidate: this ticket - Where: plugins/os-sdlc/lib/os_sdlc/ (five files) - Session: e64808e4-7c0b-4664-9d13-177acbbc143c - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-crc-pass-os-sdlc/e64808e4-7c0b-4664-9d13-177acbbc143c.jsonl

jared added the

plugin/os-sdlc

filed-by/user

labels

2026-09-27 23:05:34 +00:00

jared commented

2026-09-27 23:07:34 +00:00

Author

Owner

Deleted: PushNotifier, NullNotifier, GreenAssertFailureSidecar, ReportRenderer, Daemon::Connection (five units + nine files). Suite: 1300 runs, 2851 assertions, 0 failures, 0 errors, 10 skips. Commit 53397919.

jared commented

2026-09-28 01:18:12 +00:00

Author

Owner

Resolution

Done: Deleted PushNotifier, NullNotifier, GreenAssertFailureSidecar, ReportRenderer, Daemon::Connection and their tests (nine files).

Evidence: Commit 53397919 on crc-pass-os-sdlc; grep for each constant across plugins/os-sdlc returns nothing; suite 1300 runs 0 failures.

Follow-ups: none

## Resolution **Done:** Deleted PushNotifier, NullNotifier, GreenAssertFailureSidecar, ReportRenderer, Daemon::Connection and their tests (nine files). **Evidence:** Commit 53397919 on crc-pass-os-sdlc; grep for each constant across plugins/os-sdlc returns nothing; suite 1300 runs 0 failures. **Follow-ups:** none

jared closed this issue

2026-09-28 01:18:12 +00:00

jared referenced this issue

2026-09-28 01:18:29 +00:00

Move agent-handoff batch to concept roots and add a Tracker root per roles-agent-handoff.md #785

jared referenced this issue from a commit

2026-09-28 12:37:51 +00:00

refactor(os-sdlc): delete five dead units found by the CRC pass (#782)