Delete inward_dependency_test ratchet when the CRC refactor ends

jared commented

2026-09-26 17:31:45 +00:00

Owner

Problem

The inward-dependency baseline (currently 73) is a ratchet test — a temporary upper bound that prevents accidental increases in complexity. Ratchets must exit when the underlying refactor completes.

Reproduce

n/a: Exit condition for a ratchet test, not a bug.

Approach

Required work:

Delete the baseline constant and either drop the test or reduce it to a single directional assertion with no count

Acceptance criteria

Given the CRC/role-morph refactor of os-sdlc is complete (HANDOFF.md next steps 3-5 done), when the inward_dependency_test is run, then the ratchet baseline is deleted and replaced with a single directional assertion.

Origin

Trigger: Procedure step 6, filed as part of #747 closure during 2026-09-26 session
Improvised this session: none
Chain: CRC refactor completion → ratchet exit → test simplification (DESIGN: HANDOFF.md next steps)
Root candidate: n/a — this is an exit condition
Where: plugins/os-sdlc/tests/inward_dependency_test.rb

## Problem The inward-dependency baseline (currently 73) is a ratchet test — a temporary upper bound that prevents accidental increases in complexity. Ratchets must exit when the underlying refactor completes. ## Reproduce n/a: Exit condition for a ratchet test, not a bug. ## Approach Required work: 1. Delete the baseline constant and either drop the test or reduce it to a single directional assertion with no count ## Acceptance criteria 1. Given the CRC/role-morph refactor of os-sdlc is complete (HANDOFF.md next steps 3-5 done), when the inward_dependency_test is run, then the ratchet baseline is deleted and replaced with a single directional assertion. ## Origin - Trigger: Procedure step 6, filed as part of #747 closure during 2026-09-26 session - Improvised this session: none - Chain: CRC refactor completion → ratchet exit → test simplification (DESIGN: HANDOFF.md next steps) - Root candidate: n/a — this is an exit condition - Where: plugins/os-sdlc/tests/inward_dependency_test.rb

jared added the

plugin/os-sdlc

filed-by/agent

labels

2026-09-26 17:31:45 +00:00

jared commented

2026-09-26 18:12:01 +00:00

Author

Owner

Moved 2026-09-26: the ratchet is now bin/lint-inward-dependencies, a hand-run signal with no baseline (commit 083901a7). Exit condition unchanged: delete the script and its class when the CRC role-morph refactor ends.

Moved 2026-09-26: the ratchet is now bin/lint-inward-dependencies, a hand-run signal with no baseline (commit 083901a7). Exit condition unchanged: delete the script and its class when the CRC role-morph refactor ends.

jared referenced this issue from a commit

2026-09-27 11:25:29 +00:00

refactor(os-sdlc): inward-dependency ratchet becomes bin/lint-inward-dependencies, a signal not a test (#748)

jared referenced this issue from a commit

2026-09-27 11:25:29 +00:00

refactor(os-sdlc): add lint-inward-dependencies script and class (#748)

jared referenced this issue

2026-09-29 16:52:27 +00:00

os-sdlc: audit every lib file for ownership and naming (responsibility audit + ADR-0247 names) #835

jared referenced this issue

2026-09-30 16:47:16 +00:00

Replace shell Required-work checks with typed present/absent checks that Ruby evaluates #843

jared referenced this issue

2026-09-30 17:49:33 +00:00

Replace shell Required-work checks with typed present/absent checks that Ruby evaluates #843

jared added the

category/code-change

label

2026-10-10 13:32:01 +00:00

jared commented

2026-10-16 16:22:26 +00:00

Author

Owner

Folded in #798. Still live on this branch: resolve in plugins/os-sdlc/lib/os_sdlc/lint/inward_dependencies.rb (lines ~98-106) falls back to the first segment for a qualified constant chain such as Project::Yaml::TEST_DIR_CANDIDATES, so a model to adapter edge goes unreported. Fix: try the longest known prefix before the first-segment fallback. Do it before this ticket deletes or simplifies the ratchet, because the fix may raise the baseline count.

jared referenced this issue

2026-10-16 16:22:27 +00:00

inward-dependency lint misses qualified constant chains such as Project::Yaml::TEST_DIR_CANDIDATES, so model to adapter edges go unreported #798

jared commented

2026-10-16 16:51:20 +00:00

Author

Owner

Folding #741 into this ticket (ruling (d), 2026-10-16). The live problem of #741: bin/lint-inward-dependencies prints 'unmapped' lines, IssueSource is split between adapter/issue_source/ and command/issue_source.rb, and no baseline gate exists. Phase 7 of docs/crc/PLAN.md deletes the inward-dependency ratchet, so the problem goes away with this ticket.

jared referenced this issue

2026-10-16 16:51:21 +00:00

Shrink the inward-dependency baseline and re-layer IssueSource, Map, Records #741

jared referenced this issue from a commit

2026-10-17 00:13:42 +00:00

docs(crc): Phase 1 rulings recorded, triage done

jared commented

2026-10-17 02:50:08 +00:00

Author

Owner

Resolution

Done: The ratchet baseline and tests/inward_dependency_test.rb are gone. Per predicted ruling (o) the inward lint itself stays: its prefix bug is fixed and it now fails when a file is unmapped.

Evidence: commit 6e50fc6a on main; plugins/os-sdlc/tests/inward_dependency_test.rb absent; lint-inward-dependencies exits 0 with 0 unmapped on docs/crc/os-sdlc/ledger.tsv; docs/crc/PLAN.md ruling (o).

Follow-ups: The 54 outward edges go to Jared in the Phase 7 handoff before any ticket (ruling o).

## Resolution **Done:** The ratchet baseline and tests/inward_dependency_test.rb are gone. Per predicted ruling (o) the inward lint itself stays: its prefix bug is fixed and it now fails when a file is unmapped. **Evidence:** commit 6e50fc6a on main; plugins/os-sdlc/tests/inward_dependency_test.rb absent; lint-inward-dependencies exits 0 with 0 unmapped on docs/crc/os-sdlc/ledger.tsv; docs/crc/PLAN.md ruling (o). **Follow-ups:** The 54 outward edges go to Jared in the Phase 7 handoff before any ticket (ruling o).

jared closed this issue

2026-10-17 02:50:08 +00:00

jared referenced this issue from a commit

2026-10-17 02:58:07 +00:00

docs(os-sdlc): gate step 3 drops the deleted inward baseline (#748)

jared referenced this issue

2026-10-17 10:40:23 +00:00

Port the inward-dependency lint to a rubocop cop #1073