jared/cc-os

Watch

Fork 0

Guard test for concepts whose namespace root is missing or outside model/ (ADR-0222 item 3) #745

New issue

Closed

opened 2026-09-26 14:43:21 +00:00 by jared · 3 comments

jared commented

2026-09-26 14:43:21 +00:00

Owner

Problem

ADR-0222 says a concept's namespace root is defined by its model file, and a concept with role-object files but no model file is a defect. Under plugins/os-sdlc/lib/os_sdlc today, 2 concepts have no root at all (Git, GateHandoff), and 30 concepts have a root outside model/ (for example pipeline/map.rb, which has 15 child files across 4 roles). 17 concepts comply. Zeitwerk creates implicit namespaces for all of these, so none of them fail at load time; nothing catches the drift.

Approach

Write a test shaped like inward_dependency_test.rb: list every concept that has role-object files, locate its root via OsSdlc.loader.all_expected_cpaths, and fail on any entry not in a recorded KNOWN_ROOTLESS baseline. The baseline shrinks as concepts are morphed into ADR-0222 layout, the same pattern inward_dependency_test.rb uses for KNOWN_VIOLATIONS.

Required work:

Enumerate concepts with role-object files under plugins/os-sdlc/lib/os_sdlc and resolve each one's root via OsSdlc.loader.all_expected_cpaths.
Fail the test for any concept whose root is missing or sits outside model/, unless it is listed in a KNOWN_ROOTLESS baseline.
Seed KNOWN_ROOTLESS from the current count: 2 rootless concepts (Git, GateHandoff) plus the 30 with a root outside model/.
Wire the new test into the same suite/gate inward_dependency_test.rb runs under.

Rejected: relying on Zeitwerk to catch this — Zeitwerk's implicit namespaces make a rootless or misplaced-root concept load successfully, so it produces no signal on its own.

Acceptance criteria

Given a concept with role-object files and no model file, when the test runs, then it fails unless that concept is in KNOWN_ROOTLESS.
Given a concept whose root sits outside model/ (for example pipeline/map.rb), when the test runs, then it fails unless that concept is in KNOWN_ROOTLESS.
Given a concept morphed into ADR-0222 layout and removed from KNOWN_ROOTLESS, when the test runs, then it passes without that entry.
Given the 17 concepts that already comply, when the test runs, then none of them appear in KNOWN_ROOTLESS or cause a failure.

Owner sketch

class ConceptRootTest
  def rootless_concepts
  end
end

Origin

Trigger: user review of ADR-0222 item 3 compliance across plugins/os-sdlc/lib/os_sdlc, 2026-09-26.
Improvised this session: none.
Chain: rootless and misplaced-root concepts go undetected ← Zeitwerk's implicit namespaces load them successfully regardless of root location ← DESIGN, ADR-0222 defines the concept-root rule but no test enforces it yet.
Root candidate: this ticket.
Where: plugins/os-sdlc/lib/os_sdlc (concept roots generally); example plugins/os-sdlc/lib/os_sdlc/pipeline/map.rb
Session: d0c72a0b-34c7-4dae-bf3b-7400ef21ad4a
Transcript: not available in this invocation

## Problem ADR-0222 says a concept's namespace root is defined by its model file, and a concept with role-object files but no model file is a defect. Under plugins/os-sdlc/lib/os_sdlc today, 2 concepts have no root at all (Git, GateHandoff), and 30 concepts have a root outside model/ (for example pipeline/map.rb, which has 15 child files across 4 roles). 17 concepts comply. Zeitwerk creates implicit namespaces for all of these, so none of them fail at load time; nothing catches the drift. ## Approach Write a test shaped like inward_dependency_test.rb: list every concept that has role-object files, locate its root via `OsSdlc.loader.all_expected_cpaths`, and fail on any entry not in a recorded KNOWN_ROOTLESS baseline. The baseline shrinks as concepts are morphed into ADR-0222 layout, the same pattern inward_dependency_test.rb uses for KNOWN_VIOLATIONS. Required work: 1. Enumerate concepts with role-object files under plugins/os-sdlc/lib/os_sdlc and resolve each one's root via `OsSdlc.loader.all_expected_cpaths`. 2. Fail the test for any concept whose root is missing or sits outside model/, unless it is listed in a KNOWN_ROOTLESS baseline. 3. Seed KNOWN_ROOTLESS from the current count: 2 rootless concepts (Git, GateHandoff) plus the 30 with a root outside model/. 4. Wire the new test into the same suite/gate inward_dependency_test.rb runs under. Rejected: relying on Zeitwerk to catch this — Zeitwerk's implicit namespaces make a rootless or misplaced-root concept load successfully, so it produces no signal on its own. ## Acceptance criteria 1. Given a concept with role-object files and no model file, when the test runs, then it fails unless that concept is in KNOWN_ROOTLESS. 2. Given a concept whose root sits outside model/ (for example pipeline/map.rb), when the test runs, then it fails unless that concept is in KNOWN_ROOTLESS. 3. Given a concept morphed into ADR-0222 layout and removed from KNOWN_ROOTLESS, when the test runs, then it passes without that entry. 4. Given the 17 concepts that already comply, when the test runs, then none of them appear in KNOWN_ROOTLESS or cause a failure. ## Owner sketch ```ruby class ConceptRootTest def rootless_concepts end end ``` ## Origin - Trigger: user review of ADR-0222 item 3 compliance across plugins/os-sdlc/lib/os_sdlc, 2026-09-26. - Improvised this session: none. - Chain: rootless and misplaced-root concepts go undetected ← Zeitwerk's implicit namespaces load them successfully regardless of root location ← DESIGN, ADR-0222 defines the concept-root rule but no test enforces it yet. - Root candidate: this ticket. - Where: plugins/os-sdlc/lib/os_sdlc (concept roots generally); example plugins/os-sdlc/lib/os_sdlc/pipeline/map.rb - Session: d0c72a0b-34c7-4dae-bf3b-7400ef21ad4a - Transcript: not available in this invocation

jared added the

plugin/os-sdlc

filed-by/user

labels

2026-09-26 14:43:21 +00:00

jared referenced this issue

2026-09-26 14:43:26 +00:00

Shrink the inward-dependency baseline and re-layer IssueSource, Map, Records #741

jared commented

2026-09-26 14:46:32 +00:00

Author

Owner

Started on branch crc-pass-os-sdlc.

jared commented

2026-09-26 14:46:40 +00:00

Author

Owner

Resolution

Done: Added concept_root_test.rb (baseline 33 entries) guarding ADR-0222's model/ namespace-root rule; full suite 1430 runs/3246 assertions, 2 pre-existing failures unrelated to this change (in-progress edit to inward_dependency_test.rb by another agent).

Evidence: commit fc0289fa3b; suite line: 1430 runs, 3246 assertions, 2 failures, 0 errors, 10 skips

Follow-ups: none

## Resolution **Done:** Added concept_root_test.rb (baseline 33 entries) guarding ADR-0222's model/ namespace-root rule; full suite 1430 runs/3246 assertions, 2 pre-existing failures unrelated to this change (in-progress edit to inward_dependency_test.rb by another agent). **Evidence:** commit fc0289fa3bd9c9e4dcaea61a59bc6436215bbc71; suite line: 1430 runs, 3246 assertions, 2 failures, 0 errors, 10 skips **Follow-ups:** none

jared closed this issue

2026-09-26 14:46:40 +00:00

jared referenced this issue

2026-09-26 15:23:23 +00:00

concept_root_test enforces ADR-0223 ownership rule: missing roots and mis-scoped constants, not roots outside model/ #747

jared commented

2026-09-26 17:31:16 +00:00

Author

Owner

Withdrawn in effect: concept_root_test.rb deleted in d76058a5. A structure test on constant placement fails on refactors that change no behavior. Ownership heuristic moves to a living principles document.

Withdrawn in effect: concept_root_test.rb deleted in d76058a5. A structure test on constant placement fails on refactors that change no behavior. Ownership heuristic moves to a living principles document.

jared referenced this issue from a commit

2026-09-27 11:25:29 +00:00

test(os-sdlc): concept-root guard records concepts whose namespace root is missing or outside model/ (#745, ADR-0222)

jared referenced this issue from a commit

2026-09-27 11:25:29 +00:00

test(os-sdlc): delete concept_root_test; structure tests pin placement, not behavior (#745, #747)