refactorer receives the full change-auditor report in the ticket map but reads only WORK-MISSING items from the contract-auditor handoff #689

New issue

Closed

opened 2026-09-24 17:11:25 +00:00 by jared · 2 comments

jared commented

2026-09-24 17:11:25 +00:00

Owner

Problem

poodr-ticket-implementation.yaml:142 adds change-auditor to the refactorer enrich list. The refactorer charter reads WORK-MISSING items from the contract-auditor handoff (refactorer.md:25) and never names change-auditor. The contract-auditor derives WORK-MISSING from the change-auditor WORK list itself (contract-auditor.md:15). So the refactorer gets the full change-auditor report (median 1,587 chars, max 8,497) and uses none of it directly.

Reproduce

n/a: design audit finding, not a runtime defect.

Approach

Remove change-auditor from poodr-ticket-implementation.yaml:142. If a later run shows the refactorer needs WORK item text beyond what contract-auditor forwards, add a work_items fact that keeps only WORK: lines.

Required work:

Map edit at the line above.

Evidence

Audit row from #676: refactorer | change-auditor | TRIM | refactorer.md:11 Input sentence names contract-auditor handoff, not change-auditor.

Origin

Trigger: #676 enrich-fact audit, run in session 9434289b
Improvised this session: none
Chain: oversized or duplicated brief facts <- enrich lists chosen per node without a per-role byte audit <- DESIGN (map enrich model)
Root candidate: this ticket
Where: the map/charter/composer paths named in the draft
Parent: #676
Session: 9434289b-c48f-4a8a-8add-0d82068e2c3f
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/9434289b-c48f-4a8a-8add-0d82068e2c3f.jsonl

Skeptic verdict: CREATE (os-backlog:ticket-skeptic, session 9434289b, citations verified).

## Problem poodr-ticket-implementation.yaml:142 adds `change-auditor` to the refactorer enrich list. The refactorer charter reads WORK-MISSING items from the contract-auditor handoff (refactorer.md:25) and never names change-auditor. The contract-auditor derives WORK-MISSING from the change-auditor WORK list itself (contract-auditor.md:15). So the refactorer gets the full change-auditor report (median 1,587 chars, max 8,497) and uses none of it directly. ## Reproduce n/a: design audit finding, not a runtime defect. ## Approach Remove `change-auditor` from poodr-ticket-implementation.yaml:142. If a later run shows the refactorer needs WORK item text beyond what contract-auditor forwards, add a `work_items` fact that keeps only `WORK:` lines. Required work: - [ ] Map edit at the line above. ## Evidence Audit row from #676: refactorer | change-auditor | TRIM | refactorer.md:11 Input sentence names contract-auditor handoff, not change-auditor. ## Origin - Trigger: #676 enrich-fact audit, run in session 9434289b - Improvised this session: none - Chain: oversized or duplicated brief facts <- enrich lists chosen per node without a per-role byte audit <- DESIGN (map enrich model) - Root candidate: this ticket - Where: the map/charter/composer paths named in the draft - Parent: #676 - Session: 9434289b-c48f-4a8a-8add-0d82068e2c3f - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/9434289b-c48f-4a8a-8add-0d82068e2c3f.jsonl Skeptic verdict: CREATE (os-backlog:ticket-skeptic, session 9434289b, citations verified).

jared added the

plugin/os-sdlc

filed-by/agent

labels

2026-09-24 17:11:25 +00:00

jared referenced this issue

2026-09-24 17:11:30 +00:00

Audit each os-sdlc map node's enrich facts against what its role acts on #676

jared referenced this issue

2026-09-24 17:12:03 +00:00

Audit each os-sdlc map node's enrich facts against what its role acts on #676

jared commented

2026-09-24 17:45:29 +00:00

Author

Owner

Second-opinion review (Codex, session 9434289b): RISK HIGH. plugins/os-sdlc/tests/poodr_ticket_implementation_map_work_list_test.rb:12 requires every downstream judging node, refactorer included, to receive the change-auditor fact. This ticket reverses a tested design decision. Do not ship as written; either close, or first find the ADR behind that test and supersede it.

jared commented

2026-09-24 18:14:43 +00:00

Author

Owner

Resolution

Done: Withdrawn. Not implemented; no code changed. The proposal removes change-auditor from the refactorer enrich list, which reverses ADR-0209 (change-auditor work list reaches every judging node).

Evidence: plugins/os-sdlc/tests/poodr_ticket_implementation_map_work_list_test.rb:12 test_every_judging_node_after_change_auditor_enriches_from_it asserts refactorer is enriched from change-auditor; commit c3ec4ea7 (#643); docs/adr/0209. Codex second opinion in session 9434289b rated the ticket RISK HIGH for this reason.

Follow-ups: none. If the change-auditor fact later trips the hook cap, file a new ticket that trims the fact content (keep WORK: lines) for all eight nodes, with a seam-designer evidence check in the body.

## Resolution **Done:** Withdrawn. Not implemented; no code changed. The proposal removes change-auditor from the refactorer enrich list, which reverses ADR-0209 (change-auditor work list reaches every judging node). **Evidence:** plugins/os-sdlc/tests/poodr_ticket_implementation_map_work_list_test.rb:12 test_every_judging_node_after_change_auditor_enriches_from_it asserts refactorer is enriched from change-auditor; commit c3ec4ea7 (#643); docs/adr/0209. Codex second opinion in session 9434289b rated the ticket RISK HIGH for this reason. **Follow-ups:** none. If the change-auditor fact later trips the hook cap, file a new ticket that trims the fact content (keep WORK: lines) for all eight nodes, with a seam-designer evidence check in the body.

jared closed this issue

2026-09-24 18:14:44 +00:00