Correct stale 'graphify does not honor .gitignore' premise in ADR-017 + graphify handbook #67

New Issue

Open

opened 2026-07-16 18:44:12 +00:00 by jared · 0 comments

jared commented

2026-07-16 18:44:12 +00:00

Owner

ADR-017's DECISION still stands (a per-project, human-confirmed .graphifyignore is still the right cost lever, and is now MORE important, not less). Only the factual premise is wrong — so this is a Context/Consequences correction, likely an ADR addendum rather than a superseding ADR.

Sharper fact that should replace it: the lookup is either/or per directory (if .graphifyignore absent, use that dir's .gitignore) — never a merge. Adding a partial .graphifyignore SHADOWS that directory's .gitignore entirely and can silently re-expose node_modules/ etc. Also only the ancestor chain from VCS root down to the scan root is read, so extracting at repo root reads exactly ONE ignore file; nested subdirectory .gitignore files are never honored (unlike git).

Also check docs/graphify/02-installation-setup.md for the same claim. Corrected source-verified semantics are already written up in the vault note 2026-06-08-graphify-installation-setup.md, section 'How graphify resolves ignore files'.

Migrated 2026-07-16 from Planka board cc-os, column Backlog (ADR-0042, change retire-planka-git-issues-only).

Verified against installed graphifyy 0.8.31 source (graphify/detect.py:682-717) on 2026-07-14 while resolving wayfinder ticket #44 (forgejo jared/cc-os): graphify DOES fall back to .gitignore per-directory when no .graphifyignore is present (upstream issue #945). ADR-017's Context (docs/adr/0017-*.md:17) and Consequences (:26) both assert 'graphify does NOT honor .gitignore' — now stale. ADR-017's DECISION still stands (a per-project, human-confirmed .graphifyignore is still the right cost lever, and is now MORE important, not less). Only the factual premise is wrong — so this is a Context/Consequences correction, likely an ADR addendum rather than a superseding ADR. Sharper fact that should replace it: the lookup is either/or per directory (if .graphifyignore absent, use that dir's .gitignore) — never a merge. Adding a partial .graphifyignore SHADOWS that directory's .gitignore entirely and can silently re-expose node_modules/ etc. Also only the ancestor chain from VCS root down to the scan root is read, so extracting at repo root reads exactly ONE ignore file; nested subdirectory .gitignore files are never honored (unlike git). Also check docs/graphify/02-installation-setup.md for the same claim. Corrected source-verified semantics are already written up in the vault note 2026-06-08-graphify-installation-setup.md, section 'How graphify resolves ignore files'. --- Migrated 2026-07-16 from Planka board cc-os, column Backlog (ADR-0042, change retire-planka-git-issues-only).