os-sdlc map: route a red diff-test caused by a test-file change to a role that may edit tests

jared commented

2026-09-24 12:39:05 +00:00

Owner

Problem

After implementation, the os-sdlc map routes every red diff-test to programmer-repair. The programmer role may not edit tests. When the only remaining red is a test-file change that the ticket's Required work names, the pipeline runs two repair rounds with no progress and stops on the user's stop-and-ask rule. No route exists from a red test-file diff to a role that may edit tests (test-writer or wiring). This is an architecture-level change to the map and needs an ADR.

Observed

Session 007cbccc, ticket #641, implementation 18. Required work item 3 named the conversion of CliTestHelpers#run_cli in test/test_cli.rb and test/test_cli_edge_cases.rb from Open3.capture3 to in-process PluginConfig::Cli.run. The seam test test_only_smoke_test_file_uses_open3_across_test_cli_files stayed red. Programmer-repair ran twice and changed nothing. The session labeled #641 waiting. The user hand-finished #641 on 2026-09-24.

Reproduce

Run /os-sdlc:implement on a ticket whose Required work includes a post-implementation test-helper edit and whose test set asserts on test-file content.
Observe the red diff-test route to programmer-repair twice, then stop.

Origin

Trigger: os-sdlc implementation round 18 on ticket #641
Improvised this session: user hand-finished the ticket
Chain: red diff-test on test-file change ← os-sdlc map routes all red diff-tests to programmer-repair ← programmer role cannot edit tests
Root candidate: architecture change to os-sdlc map routing rules
Where: plugins/os-sdlc map (implementation node repair edges)
Session: 5bc3486e-d1a8-4574-b4fb-46b6e03c5de1
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-ticket-641/5bc3486e-d1a8-4574-b4fb-46b6e03c5de1.jsonl

## Problem After implementation, the os-sdlc map routes every red diff-test to programmer-repair. The programmer role may not edit tests. When the only remaining red is a test-file change that the ticket's Required work names, the pipeline runs two repair rounds with no progress and stops on the user's stop-and-ask rule. No route exists from a red test-file diff to a role that may edit tests (test-writer or wiring). This is an architecture-level change to the map and needs an ADR. ## Observed Session 007cbccc, ticket #641, implementation 18. Required work item 3 named the conversion of `CliTestHelpers#run_cli` in `test/test_cli.rb` and `test/test_cli_edge_cases.rb` from `Open3.capture3` to in-process `PluginConfig::Cli.run`. The seam test `test_only_smoke_test_file_uses_open3_across_test_cli_files` stayed red. Programmer-repair ran twice and changed nothing. The session labeled #641 `waiting`. The user hand-finished #641 on 2026-09-24. ## Reproduce - [ ] Run `/os-sdlc:implement` on a ticket whose Required work includes a post-implementation test-helper edit and whose test set asserts on test-file content. - [ ] Observe the red diff-test route to programmer-repair twice, then stop. ## Origin - Trigger: os-sdlc implementation round 18 on ticket #641 - Improvised this session: user hand-finished the ticket - Chain: red diff-test on test-file change ← os-sdlc map routes all red diff-tests to programmer-repair ← programmer role cannot edit tests - Root candidate: architecture change to os-sdlc map routing rules - Where: plugins/os-sdlc map (implementation node repair edges) - Session: 5bc3486e-d1a8-4574-b4fb-46b6e03c5de1 - Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os--claude-worktrees-ticket-641/5bc3486e-d1a8-4574-b4fb-46b6e03c5de1.jsonl

jared added the

plugin/os-sdlc

filed-by/user

labels

2026-09-24 12:39:05 +00:00

jared referenced this issue

2026-09-24 12:42:18 +00:00

cc-architect: PluginConfig::Cli moves out of bin/plugin-config, takes an Invocation (cwd, env HOME); CLI tests run in-process #641

jared referenced this issue from a commit

2026-09-24 12:50:10 +00:00

refactor(cc-architect): PluginConfig::Cli moves out of bin/plugin-config and takes an Invocation; CLI tests run in-process (#641)

jared referenced this issue

2026-09-24 13:03:33 +00:00

Repo-wide guard against forks of this repo's own bin/ executables in tests; hook-test harness runner calls in-process; hang-guard 30 s -> 5 s #642

jared referenced this issue

2026-09-24 13:14:10 +00:00

Repo-wide guard against forks of this repo's own bin/ executables in tests; hook-test harness runner calls in-process; hang-guard 30 s -> 5 s #642

jared referenced this issue

2026-09-24 13:14:31 +00:00

Repo-wide guard against forks of this repo's own bin/ executables in tests; hook-test harness runner calls in-process; hang-guard 30 s -> 5 s #642

jared referenced this issue

2026-09-24 14:13:34 +00:00

code.path is the target path; no lib/ default #655

jared referenced this issue

2026-09-24 14:30:28 +00:00

code.path is the target path; no lib/ default #655

jared referenced this issue

2026-09-24 14:38:34 +00:00

Rename tests that break the S2 layout convention #656

jared referenced this issue

2026-09-24 14:38:35 +00:00

Rename tests that break the S2 layout convention #656

jared referenced this issue

2026-09-24 15:15:48 +00:00

Pass Project/Dispatch objects instead of project_root strings #657

jared referenced this issue

2026-09-24 15:44:00 +00:00

Pass Project/Dispatch objects instead of project_root strings #657

jared referenced this issue

2026-09-24 15:44:24 +00:00

CLI invocation seam + in-process CLI tests #631

jared referenced this issue from a commit

2026-09-24 16:58:03 +00:00

test(os-sdlc): guard against forks of repo bin/ executables in tests; hook tests run the runner in-process; hang guard 5 s (#642)

jared referenced this issue from a commit

2026-09-24 16:58:03 +00:00

test(os-sdlc): retire tests of the removed code_path/root_path API; fixtures use path: (#655)

jared referenced this issue from a commit

2026-09-24 16:58:03 +00:00

test: rename 26 tests to the S2 layout across os-sdlc, os-aidd-lint, os-backlog (#656)

jared referenced this issue from a commit

2026-09-24 16:58:03 +00:00

test(os-sdlc): fixtures follow Project#path and the keyword GateCommands/ViolationRecorder signatures; objection scenario uses Entry hashes (#657)

jared referenced this issue

2026-09-24 19:27:55 +00:00

gate_verdicts fact replaces gate_results for contract-auditor in both poodr maps and reviewer in coding.yaml #686

jared referenced this issue

2026-09-24 20:11:45 +00:00

programmer diff-test gate silently runs the full suite when any changed file is unmapped #625

jared referenced this issue from a commit

2026-09-24 20:17:27 +00:00

feat(os-sdlc): gate_verdicts fact replaces gate_results for contract-auditor and reviewer (#686)

jared referenced this issue

2026-09-24 21:36:50 +00:00

poodr-ticket-implementation map: a red diff-test caused by a test-file defect after the green phase has no route to test-writer; three programmer-repair rounds are spent for nothing #709

jared commented

2026-09-25 16:58:35 +00:00

Author

Owner

New case 2026-09-25 (#712, implementation 47): #712 removed the spawner: and lifecycle: keywords; tests/lsp_probe/cli_test.rb and tests/model/implementation_complete_stamp_test.rb outside the diff still passed them, the gate went red in programmer-repair, and the map offered only programmer-repair again. The orchestrator hand-edited the tests. Ticket-skeptic verdict: DROP as a new ticket; same routing gap as this issue and #709.

jared referenced this issue

2026-09-25 16:58:43 +00:00

Route the ruby-lsp daemon lifecycle through the procman gem (ADR-0219 slice 1) #712

jared referenced this issue

2026-09-28 19:32:56 +00:00

Show start, finish and duration in os-sdlc implementation runs #804

jared commented

2026-09-29 15:41:24 +00:00

Author

Owner

Another case on 2026-09-29, #802 implementation 77. The change-auditor PINS list and the test-writer both missed tests/ticket_573_lint_config_test.rb, which called Project::Lint.new(paths: []). suite-check returned error and the Runner went to implementation_failed. No node could edit the test, so the run was hand-finished (escalation step 4).

jared referenced this issue

2026-09-29 15:41:25 +00:00

Delete lint_paths: a target lints only its own path (T6, coding map) #802

jared added the

category/owner-ruling

label

2026-10-10 13:32:04 +00:00

jared referenced this issue

2026-10-18 18:58:40 +00:00

Pipeline cannot converge when a red suite-check needs a test-side edit #544

jared commented

2026-10-18 18:59:19 +00:00