Collapse Implementation#fail! and #escalate! onto one private terminate! method #661

New issue

Closed

opened 2026-09-24 01:15:24 +00:00 by jared · 2 comments

jared commented

2026-09-24 01:15:24 +00:00

Owner

Problem

lib/os_sdlc/model/implementation/instance_methods.rb:33 and :38 differ by one symbol. Both methods call stamp! with the same position/reason transformation and then lifecycle.close(root). The rule "close the LSP daemon on a terminal state" (ADR-0201) is written twice. flay reports Similar, mass 46.

Reproduce

n/a: refactor ticket, no runtime defect

Approach

Add a private terminate!(column, position:, reason:, root: nil, lifecycle: Pipeline::LspDaemonLifecycle) holding the sequence. fail! and escalate! become one-line delegations that pass :failed_at or :escalated_at. Public signatures unchanged.

Required work:

add private terminate!
fail! and escalate! delegate
tests/model/implementation_test.rb green

Acceptance criteria

flay no longer lists the pair
tests/model green
rubocop clean on touched file

Owner sketch

A private terminate! in lib/os_sdlc/model/implementation/instance_methods.rb owns the terminal-state sequence: stamp the column, record the reason, close the LSP daemon.

def fail!(**opts) = terminate!(:failed_at, **opts)
def escalate!(**opts) = terminate!(:escalated_at, **opts)

private

def terminate!(column, position:, reason:, root: nil, lifecycle: Pipeline::LspDaemonLifecycle)
  stamp!(column, position: Model::NodeName.parse(position).to_s, failed_reason: reason)
  lifecycle.close(root)
end

Public signatures of fail! and escalate! are unchanged.

Origin

Session: 24f1de09-c081-4958-902b-0512a5d86e04
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/24f1de09-c081-4958-902b-0512a5d86e04.jsonl
Where: lib/os_sdlc/model/implementation/instance_methods.rb
Source: flay duplication sweep (bin/dup-sweep) run 2026-09-23 on plugins/os-sdlc; lib+bin score 726.

## Problem lib/os_sdlc/model/implementation/instance_methods.rb:33 and :38 differ by one symbol. Both methods call stamp! with the same position/reason transformation and then lifecycle.close(root). The rule "close the LSP daemon on a terminal state" (ADR-0201) is written twice. flay reports Similar, mass 46. ## Reproduce n/a: refactor ticket, no runtime defect ## Approach Add a private `terminate!(column, position:, reason:, root: nil, lifecycle: Pipeline::LspDaemonLifecycle)` holding the sequence. fail! and escalate! become one-line delegations that pass :failed_at or :escalated_at. Public signatures unchanged. Required work: 1. add private terminate! 2. fail! and escalate! delegate 3. tests/model/implementation_test.rb green ## Acceptance criteria 1. flay no longer lists the pair 2. tests/model green 3. rubocop clean on touched file ## Owner sketch A private `terminate!` in `lib/os_sdlc/model/implementation/instance_methods.rb` owns the terminal-state sequence: stamp the column, record the reason, close the LSP daemon. ```ruby def fail!(**opts) = terminate!(:failed_at, **opts) def escalate!(**opts) = terminate!(:escalated_at, **opts) private def terminate!(column, position:, reason:, root: nil, lifecycle: Pipeline::LspDaemonLifecycle) stamp!(column, position: Model::NodeName.parse(position).to_s, failed_reason: reason) lifecycle.close(root) end ``` Public signatures of `fail!` and `escalate!` are unchanged. ## Origin Session: 24f1de09-c081-4958-902b-0512a5d86e04 Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/24f1de09-c081-4958-902b-0512a5d86e04.jsonl Where: lib/os_sdlc/model/implementation/instance_methods.rb Source: flay duplication sweep (bin/dup-sweep) run 2026-09-23 on plugins/os-sdlc; lib+bin score 726.

jared added the

plugin/os-sdlc

filed-by/user

labels

2026-09-24 01:15:24 +00:00

jared commented

2026-09-24 01:42:46 +00:00

Author

Owner

Work started via /os-sdlc:implement on branch ticket-661 (session 24f1de09), coding.yaml map: behavior-preserving refactor, no red test.

jared commented

2026-09-24 01:52:10 +00:00

Author

Owner

Resolution

Done: fail! and escalate! are one-line delegations to a private terminate!(column, ...) that stamps, records the reason, and closes the LSP daemon. Public signatures unchanged.

Evidence: Pipeline impl 1 on coding.yaml: programmer gates test+lint green twice, reviewer fail then pass. flay lib+bin 598 -> 552; pair no longer listed. Branch ticket-661.

Follow-ups: none

## Resolution **Done:** fail! and escalate! are one-line delegations to a private terminate!(column, ...) that stamps, records the reason, and closes the LSP daemon. Public signatures unchanged. **Evidence:** Pipeline impl 1 on coding.yaml: programmer gates test+lint green twice, reviewer fail then pass. flay lib+bin 598 -> 552; pair no longer listed. Branch ticket-661. **Follow-ups:** none

jared closed this issue

2026-09-24 01:52:11 +00:00

jared referenced this issue

2026-09-24 01:54:58 +00:00

implement skill names no map for a behavior-preserving refactor; ticket-implementation map escalates on unexpected_pass #663

~~jared referenced this issue 2026-09-24 01:55:08 +00:00~~

capture body-style rules say checklists are - [ ] but the template and Required-work parsers require numbered lines #664

jared referenced this issue from a commit

2026-09-24 12:38:26 +00:00

refactor(os-sdlc): fail! and escalate! delegate to one private terminate! (#661)