Move BriefComposer construction to one owner instead of two pipeline copies #660

New issue

Closed

opened 2026-09-24 01:15:17 +00:00 by jared · 2 comments

jared commented

2026-09-24 01:15:17 +00:00

Owner

Problem

lib/os_sdlc/pipeline/brief_lookup.rb:47 and lib/os_sdlc/pipeline/start_subagent.rb:41 contain byte-identical code for the composer method. Both classes know how to derive map_dir from an implementation and build a BriefComposer. That knowledge is duplicated. flay reports IDENTICAL, mass*2 = 64.

Reproduce

n/a: refactor ticket, no runtime defect

Approach

Add a class method BriefComposer.for(implementation, node:, handoff:, facts:) in lib/os_sdlc/pipeline/brief_composer.rb that derives map_dir itself. Both callers delegate to it and drop their private composer method.

Required work:

add BriefComposer.for
BriefLookup and StartSubagent call it
delete both composer methods
existing tests green

Acceptance criteria

flay no longer lists the pair
tests/pipeline green
rubocop clean on touched files

Owner sketch

OsSdlc::Pipeline::BriefComposer.for in lib/os_sdlc/pipeline/brief_composer.rb owns the derivation of map_dir from an implementation.

def self.for(implementation, node:, handoff:, facts:)
  new(node: node, handoff: handoff, facts: facts, map_dir: File.dirname(implementation.map_path))
end

BriefLookup and StartSubagent call BriefComposer.for(implementation, node: node, handoff: handoff, facts: facts) and delete their private composer methods.

Origin

Session: 24f1de09-c081-4958-902b-0512a5d86e04
Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/24f1de09-c081-4958-902b-0512a5d86e04.jsonl
Where: lib/os_sdlc/pipeline/
Source: flay duplication sweep (bin/dup-sweep) run 2026-09-23 on plugins/os-sdlc; lib+bin score 726.

## Problem lib/os_sdlc/pipeline/brief_lookup.rb:47 and lib/os_sdlc/pipeline/start_subagent.rb:41 contain byte-identical code for the composer method. Both classes know how to derive map_dir from an implementation and build a BriefComposer. That knowledge is duplicated. flay reports IDENTICAL, mass*2 = 64. ## Reproduce n/a: refactor ticket, no runtime defect ## Approach Add a class method `BriefComposer.for(implementation, node:, handoff:, facts:)` in lib/os_sdlc/pipeline/brief_composer.rb that derives map_dir itself. Both callers delegate to it and drop their private composer method. Required work: 1. add BriefComposer.for 2. BriefLookup and StartSubagent call it 3. delete both composer methods 4. existing tests green ## Acceptance criteria 1. flay no longer lists the pair 2. tests/pipeline green 3. rubocop clean on touched files ## Owner sketch `OsSdlc::Pipeline::BriefComposer.for` in `lib/os_sdlc/pipeline/brief_composer.rb` owns the derivation of `map_dir` from an implementation. ```ruby def self.for(implementation, node:, handoff:, facts:) new(node: node, handoff: handoff, facts: facts, map_dir: File.dirname(implementation.map_path)) end ``` `BriefLookup` and `StartSubagent` call `BriefComposer.for(implementation, node: node, handoff: handoff, facts: facts)` and delete their private `composer` methods. ## Origin Session: 24f1de09-c081-4958-902b-0512a5d86e04 Transcript: /home/jared/.claude/projects/-home-jared-dev-cc-os/24f1de09-c081-4958-902b-0512a5d86e04.jsonl Where: lib/os_sdlc/pipeline/ Source: flay duplication sweep (bin/dup-sweep) run 2026-09-23 on plugins/os-sdlc; lib+bin score 726.

jared added the

plugin/os-sdlc

filed-by/user

labels

2026-09-24 01:15:17 +00:00

jared commented

2026-09-24 01:39:17 +00:00

Author

Owner

Work started via /os-sdlc:implement on branch ticket-660 (session 24f1de09), coding.yaml map: behavior-preserving refactor, no red test.

jared commented

2026-09-24 01:41:49 +00:00

Author

Owner

Resolution

Done: BriefComposer.for(implementation, node:, handoff:, facts:) derives map_dir; BriefLookup and StartSubagent delegate to it and their private composer methods are deleted.

Evidence: Pipeline impl 1 on coding.yaml: programmer gate test+lint green, reviewer pass. flay lib+bin 662 -> 598; pair no longer listed. Branch ticket-660.

Follow-ups: none

## Resolution **Done:** BriefComposer.for(implementation, node:, handoff:, facts:) derives map_dir; BriefLookup and StartSubagent delegate to it and their private composer methods are deleted. **Evidence:** Pipeline impl 1 on coding.yaml: programmer gate test+lint green, reviewer pass. flay lib+bin 662 -> 598; pair no longer listed. Branch ticket-660. **Follow-ups:** none

jared closed this issue

2026-09-24 01:41:49 +00:00

jared referenced this issue

2026-09-24 01:54:58 +00:00

implement skill names no map for a behavior-preserving refactor; ticket-implementation map escalates on unexpected_pass #663

~~jared referenced this issue 2026-09-24 01:55:08 +00:00~~

capture body-style rules say checklists are - [ ] but the template and Required-work parsers require numbered lines #664

jared referenced this issue from a commit

2026-09-24 12:38:26 +00:00

refactor(os-sdlc): BriefComposer.for owns map_dir derivation (#660)